Skip to content

Commit 98c5d95

Browse files
committed
docs(review): post one plain-language review
Each pass was posting its own GitHub review, so one diff showed up as a comment and an approval. Dispatch now waits for every pass and posts a single review: plain language first, then path and failure mode.
1 parent e8e6130 commit 98c5d95

1 file changed

Lines changed: 12 additions & 8 deletions

File tree

  • plugins/corbits-skills/skills/review

‎plugins/corbits-skills/skills/review/SKILL.md‎

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -59,22 +59,26 @@ Raise what helps the author. Flag real defects and architecture that would const
5959

6060
## 6. Report and post
6161

62-
Summarize with the findings. When the target has an open GitHub PR, post the finished review on it; a review that only lives in chat is not done. Post when the operator asked for a PR review, when `/implement`'s whole-branch gate runs on a branch with an open PR, or when a record on the PR is the purpose. Do not post a private local read, and do not reopen the analysis while writing the body.
62+
Summarize with the findings. When the target has an open GitHub PR, post the finished review on it; a review that only lives in chat is not done. Post when the operator asked for a PR review, when `/implement`'s whole-branch gate runs on a branch with an open PR, or when a record on the PR is the purpose. Do not post a private local read. Do not implement fixes. Do not reopen the analysis while writing the body.
63+
64+
Wait until every pass Dispatch started has reported. Passes do not post to GitHub and do not approve, comment, or request changes.
65+
66+
Then post exactly one review with `gh pr review`. One verdict for the whole diff. Use one of `--approve`, `--comment`, or `--request-changes`, and swap that flag to match the verdict:
6367

6468
```bash
6569
gh pr review <number-or-url> --comment --body-file <file>
6670
```
6771

68-
Use `--approve` or `--request-changes` for the verdict. Shape:
72+
The body is for a person first. Open with what the branch does now, in plain language. Then what goes wrong, in plain language. Do not name the passes. Do not use finder jargon (no "trust check", "lens", "nullMeansUnset", "injected parser").
6973

70-
```markdown
71-
## Review · <Approve | Comment | Request changes>
74+
Under that, each finding is one bullet an agent can act on: `path:line`, then the concrete failure mode. A clean review says "No findings." after the plain summary. No throat-clearing, praise to soften a finding, emoji, or "nit:" taste.
7275

73-
<one line: what the branch does>
76+
```markdown
77+
<what the branch does now, in plain language>
7478

75-
### Findings
79+
<what goes wrong, in plain language>
7680

77-
- `path/to/file.ts:12` — concrete problem and why it matters
81+
- `path/to/file.ts:12` — concrete failure mode
7882
```
7983

80-
A clean review says "No findings." after the one line. No throat-clearing, praise to soften a finding, emoji, or "nit:" taste. When more than one lens produced a distinct judgment (reviewer, planner waiver, warden), each posts its own labelled review, and only the lens that owns the merge verdict may approve. Paste the review URL back to the operator. Posting does not change Linear state. Remove the PR worktree afterward.
84+
The note back to the operator is that same body plus the review URL. Do not write a second, more technical summary in chat. Posting does not change Linear state. Remove the PR worktree afterward.

0 commit comments

Comments
 (0)