Skip to content

Commit 987264a

Browse files
committed
Yield emil report format to the scaffold-owned worker envelope
The shared scaffold owns Summary / Findings / Blockers / Paths, so the restored CMO report content is carried as Findings sub-bullets instead of re-specified headings. Deviation comment 5 updated to match.
1 parent b71f6f7 commit 987264a

2 files changed

Lines changed: 26 additions & 58 deletions

File tree

‎src/agent/directors/emil/package.test.ts‎

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -92,17 +92,21 @@ describe("emilPackage", () => {
9292
expect(p).toMatch(/hit area minimums/i);
9393
});
9494

95-
test("systemPrompt restores the full report format (CL-7801)", () => {
95+
test("systemPrompt defers to the scaffold envelope and carries report content as Findings sub-bullets (CL-7801)", () => {
9696
const p = emilPackage.systemPrompt;
97-
expect(p).toMatch(/# Report format/i);
98-
expect(p).toMatch(/## Summary/);
99-
expect(p).toMatch(/## Findings/);
100-
expect(p).toMatch(/## Test results/);
97+
expect(p).toMatch(/# Report\n/);
98+
expect(p).toMatch(/scaffold owns its shape/i);
99+
expect(p).not.toMatch(/# Report format/);
100+
expect(p).not.toMatch(/## Summary/);
101+
expect(p).not.toMatch(/## Findings/);
102+
expect(p).not.toMatch(/## Test results/);
103+
expect(p).not.toMatch(/## Observations/);
104+
expect(p).not.toMatch(/## Blockers/);
105+
expect(p).not.toMatch(/## Paths/);
101106
expect(p).toMatch(/Recommended tests for permanent inclusion/i);
102-
expect(p).toMatch(/## Observations/);
103-
expect(p).toMatch(/## Blockers/);
104-
expect(p).toMatch(/## Paths/);
105-
expect(p).toMatch(/Confidence.*VERIFIED \/ HIGH \/ MEDIUM/);
107+
expect(p).toMatch(/confidence.*VERIFIED \/ HIGH \/ MEDIUM/i);
108+
expect(p).toMatch(/severity.*Critical.*Major.*Minor/i);
109+
expect(p).toMatch(/Observations: patterns across findings/);
106110
});
107111

108112
test("systemPrompt restores guidelines and negative constraints (CL-7801)", () => {

‎src/agent/directors/emil/package.ts‎

Lines changed: 13 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import { REVIEW_TOOLS } from "../tool-sets.js";
1212
* The CL-7031 overhaul had narrowed the prompt to a design-eng-laws digest;
1313
* this restore ports back every dropped section: capabilities, the Thinking &
1414
* Reasoning laws, the Boy Scout Rule, the design-engineering cross-reference
15-
* checklist, temp-test workflow steps, the full report format, guidelines,
15+
* checklist, temp-test workflow steps, the report content, guidelines,
1616
* and the negative constraints.
1717
*
1818
* Deviations from the source (deliberate, exhaustive):
@@ -28,8 +28,11 @@ import { REVIEW_TOOLS } from "../tool-sets.js";
2828
* 4. `skills: brand-identity` has no Corbits skill equivalent, so it stays
2929
* prose: the design-engineering reference substance is inlined (craft
3030
* section + cross-reference checklist) instead of mounted.
31-
* 5. Report format gains Blockers/Paths — the Corbits worker envelope
32-
* requires them; source sections otherwise restored in full.
31+
* 5. Report format yields to the scaffold-owned Corbits worker envelope
32+
* (Summary / Findings / Blockers / Paths) — the source's report sections
33+
* are carried as Findings sub-bullets (per-issue law/location/evidence/
34+
* confidence/severity, test results, recommended tests, observations)
35+
* instead of re-specified headings.
3336
* 6. Temp-test path `tmp/critique-tests/` kept verbatim (repo has tmp/).
3437
* 7. "Do not commit changes" kept verbatim; fleet commits stay parent-owned.
3538
*
@@ -166,53 +169,14 @@ When asked to critique:
166169
6. **Assess confidence** — VERIFIED (proven by tests), HIGH (strong evidence but not testable), MEDIUM (plausible but uncertain). Discard LOW confidence.
167170
7. **Report findings** — clear, evidence-based critique. Every finding cites a law.
168171
169-
# Report format
172+
# Report
170173
171-
## Summary
172-
173-
- High-level assessment of design engineering quality
174-
- Critical violations found (if any)
175-
- Which laws are most violated across the codebase
176-
177-
## Findings
178-
179-
For each issue:
180-
181-
- **Law violated**: which principle and why
182-
- **Location**: specific file and line references
183-
- **Evidence**: test results, code examples, or observable behavior
184-
- **Confidence**: VERIFIED / HIGH / MEDIUM
185-
- **Severity**: Critical (breaks things), Major (degrades quality), Minor (polish)
186-
187-
Only report issues you have verified or have high confidence in. Do not report speculative concerns. No implementation prescriptions — cite expected craft vs actual, not patch recipes.
188-
189-
## Test results
190-
191-
- Existing test outcomes
192-
- Temporary test findings
193-
- What the tests revealed about code behavior
194-
195-
## Recommended tests for permanent inclusion
196-
197-
If you wrote temporary tests that should be permanent, document:
198-
199-
1. **File path** in \`tmp/critique-tests/\`
200-
2. **What it tests** — specific scenarios or edge cases
201-
3. **Why it's valuable** — uncovered functionality, regression prevention, non-obvious behavior documentation
202-
203-
## Observations
204-
205-
- Patterns across findings (e.g., "the codebase consistently violates Law of Demeter in API handlers")
206-
- Areas that need attention but aren't specific violations
207-
- Positive observations — things done well
208-
209-
## Blockers
210-
211-
- Missing context, out-of-lane asks, unreadable artifacts.
212-
213-
## Paths
214-
215-
- Files inspected.
174+
When done, stop calling tools and reply with ONLY the Corbits report envelope — the shared scaffold owns its shape (Summary / Findings / Blockers / Paths, in that order), so this package does not re-specify it. Findings for this lane:
175+
- Per issue: law violated and why, location (file and line references), evidence (test results, code examples, or observable behavior), confidence (VERIFIED / HIGH / MEDIUM), severity (Critical breaks things, Major degrades quality, Minor polish).
176+
- Test results: existing test outcomes, temporary test findings, what the tests revealed about code behavior.
177+
- Recommended tests for permanent inclusion: file path in tmp/critique-tests/, what it tests, why it is valuable.
178+
- Observations: patterns across findings, areas needing attention that are not specific violations, positives — things done well.
179+
Only report issues you have verified or have high confidence in. Do not report speculative concerns. No implementation prescriptions — cite expected craft vs actual, not patch recipes. Blockers: missing context, out-of-lane asks, unreadable artifacts. Paths: files inspected.
216180
217181
# Guidelines
218182

0 commit comments

Comments
 (0)