refactor(agent): drop tool-set digest narration

Author: TheGreatAxios

src/agent/director.ts

@@ -59,12 +59,6 @@ const logger = getLogger([LOG_NAMESPACE_ROOT, "agent", "director"]);
 // (mount, description edit, reorder) drops the next turn's cache hit. The
 // digest stays deterministic — it only moves when discovery grows the set.
 // Hashed: MCP descriptions are arbitrary server text, not log material.
-//
-// Pure by design: the memoization lives on the director (_toolSetDigest), the
-// only production caller, so the module keeps no per-array state. Callers swap
-// tool arrays wholesale (constructor, updateToolDefinitions) without in-place
-// mutation; mutating an installed array in place would leave the director's
-// cached digest stale.
 export function toolSetDigest(tools: readonly ToolDefinition[]): string {
   const shape = tools
     .map(
@@ -481,12 +475,6 @@ class ChatDirectorImpl extends DefaultDirector {
   private readonly askOperatorCalls = new Set<string>();
   private readonly _systemPrompt: string;
   private _toolDefinitions: ToolDefinition[];
-  // Digest of the installed _toolDefinitions, stored when the array is set so
-  // updateToolDefinitions can compare an incoming set without re-hashing the
-  // current one. One slot per director — the digest is only consumed by the
-  // next update on this instance, never by shared/static context (all
-  // production call sites are here). Stale only if a caller mutates the
-  // installed array in place; callers swap arrays wholesale instead.
   private _toolSetDigest: string | undefined;
   private inactivityTimeoutMs: number | undefined;
   private totalTimeoutMs: number | undefined;
@@ -712,9 +700,6 @@ class ChatDirectorImpl extends DefaultDirector {
   }
 
   updateToolDefinitions(toolDefinitions: ToolDefinition[]): void {
-    // The stored digest covers the current set (installed by the constructor
-    // or a prior update); only the very first update has to hash it, and the
-    // fallback runs once per director.
     const before = this._toolSetDigest ?? toolSetDigest(this._toolDefinitions);
     const after = toolSetDigest(toolDefinitions);
     this._toolDefinitions = toolDefinitions;

src/agent/tool-set-digest.test.ts

@@ -1,12 +1,6 @@
 import { describe, expect, test } from "bun:test";
 import { withMockedModule } from "../../testkit/mock-module.js";
 
-// Spy on createHash to prove toolSetDigest memoizes per director: installing
-// a tool set runs the sha256 exactly once for that set, and comparing a later
-// update against the stored per-director digest must not re-hash the previous
-// set. The mock delegates to the real implementation (captured before mocking)
-// so behavior is unchanged; hashCalls only measures the delta around each
-// assertion.
 let hashCalls = 0;
 await withMockedModule<typeof import("node:crypto")>(
   import.meta.resolve("node:crypto"),
@@ -19,7 +13,6 @@ await withMockedModule<typeof import("node:crypto")>(
   }),
 );
 
-// Dynamic import so director.ts resolves node:crypto through the mock above.
 const { createChatDirector } = await import("./director.js");
 
 const base = {
@@ -34,11 +27,8 @@ describe("toolSetDigest memoization", () => {
     const tools = [{ ...base }];
     const changed = [{ ...base, description: "changed" }];
 
-    // Warm-up installs `tools`; its digest is stored on the director.
     director.updateToolDefinitions(tools);
     hashCalls = 0;
-    // The previous set's digest comes from the per-director field (no re-hash);
-    // only the incoming set is hashed.
     director.updateToolDefinitions(changed);
     expect(hashCalls).toBe(1);
   });
@@ -51,9 +41,6 @@ describe("toolSetDigest memoization", () => {
     director.updateToolDefinitions(tools);
     director.updateToolDefinitions(changed);
     hashCalls = 0;
-    // A fresh reference (even with identical content) misses the stored slot
-    // and re-runs the hash; the digest gates the tool-set-changed log, so
-    // identical content still logs nothing.
     director.updateToolDefinitions([{ ...base }]);
     expect(hashCalls).toBe(1);
   });