Merge pull request #1399 from corbitsdev/cl-10513-config-telemetry-dead-guards

refactor(config): drop dead guards and duplicate profile expression

Author: TheGreatAxios

src/config/index.ts

@@ -757,9 +757,7 @@ export class CliHelpError extends Error {
 }
 
 /** Printed for `corbits --version` / `-V`. Matches `package.json` version. */
-export const CLI_VERSION_TEXT = `${COMMAND_NAME} v${
-  typeof pkg.version === "string" ? pkg.version : "0.0.0"
-}`;
+export const CLI_VERSION_TEXT = `${COMMAND_NAME} v${pkg.version}`;
 
 /**
  * Thrown when the operator asked for the CLI version. Entry points must print

src/config/profiles.ts

@@ -113,7 +113,7 @@ export async function resolveProfile(
       merged.summarizerTimeoutMs = projectProfile.summarizerTimeoutMs;
   }
 
-  const resolvedName = profileName ?? projectProfile?.profile;
+  const resolvedName = namedProfileName;
   if (resolvedName !== undefined) merged.profile = resolvedName;
 
   return merged;

src/exec/runner.ts

@@ -646,9 +646,10 @@ export async function runExec(config: Config): Promise<ExecResult> {
         });
       },
     });
-    const sessionMode: SessionMode =
-      resolveSessionMode(config.settings, localSettingsForMode) ??
-      "orchestrator";
+    const sessionMode: SessionMode = resolveSessionMode(
+      config.settings,
+      localSettingsForMode,
+    );
 
     const interactive = resolveExecInteractive({
       stdinTTY: input.isTTY,