polish settings warn wording and drop redundant cast

Author: TheGreatAxios

src/config/settings.test.ts

@@ -711,12 +711,15 @@ test("settings load warns and still loads when a provider carries ignored fields
     expect(loaded).not.toBeNull();
     expect(loaded?.providers.external).toBeDefined();
     expect(stderr.output()).toContain(
-      '"external" sets fields that are not honored by Corbits and are ignored',
+      '"external" sets fields that are not honored by Corbits and will be ignored',
     );
     expect(stderr.output()).toContain("supportsThinkingTokenBudget");
     expect(stderr.output()).toContain("thinkingLevelMap");
     expect(stderr.output()).toContain("samplingParams");
-    expect(stderr.output()).toContain("compat.supportsReasoningEffort");
+    expect(stderr.output()).toContain("compat → supportsReasoningEffort");
+    expect(stderr.output()).toContain(
+      "These fields are not yet supported; configure effort/thinking via provider/model-level settings.",
+    );
   } finally {
     stderr.restore();
     await rm(cwd, { recursive: true, force: true });
@@ -750,8 +753,8 @@ test("settings load does not warn for a normal provider block", async () => {
   }
 });
 
-// CL-10226 (Part 1): the same warn must surface on the config path (--config /
-// global settings), which routes through loadSettings... → normalizeParsedSettings.
+// The same warn must surface on the config path (--config / global settings),
+// which routes through loadSettings... → normalizeParsedSettings.
 test("loadConfig warns and still loads when a provider carries ignored fields", async () => {
   const cwd = await mkdtemp(join(tmpdir(), "ic-unit-config-ignored-config-"));
   const globalSettingsPath = join(cwd, "global.json");

src/config/settings.ts

@@ -1039,21 +1039,28 @@ function settingsSchemaError(path: string): Error {
 // Provider blocks from some external tools carry fields Corbits does not
 // honor: compat.supportsReasoningEffort, supportsThinkingTokenBudget,
 // thinkingLevelMap, samplingParams. ProviderSettingsSchema does not reject
-// unknown keys, so they pass validation and are silently dropped. Warn so the
-// ignore is never silent. CL-10226 (Part 1): field mappings are a separate
-// follow-up — this only surfaces the warn.
+// unknown keys, so they pass validation and are silently dropped. Warn when
+// any are present so the ignore is never silent.
 const IGNORED_PROVIDER_FIELDS: {
-  key: string;
+  display: string;
   path: (p: Record<string, unknown>) => unknown;
 }[] = [
   {
-    key: "supportsThinkingTokenBudget",
+    display: "supportsThinkingTokenBudget",
     path: (p) => p.supportsThinkingTokenBudget,
   },
-  { key: "thinkingLevelMap", path: (p) => p.thinkingLevelMap },
-  { key: "samplingParams", path: (p) => p.samplingParams },
   {
-    key: "compat.supportsReasoningEffort",
+    display: "thinkingLevelMap",
+    path: (p) => p.thinkingLevelMap,
+  },
+  {
+    display: "samplingParams",
+    path: (p) => p.samplingParams,
+  },
+  {
+    // Rendered as the nested arrow form so it is not mistaken for a bare
+    // provider-level key (the JSON nests it under the provider's "compat").
+    display: "compat → supportsReasoningEffort",
     path: (p) => {
       const compat = p.compat as Record<string, unknown> | undefined;
       return compat?.supportsReasoningEffort;
@@ -1062,15 +1069,17 @@ const IGNORED_PROVIDER_FIELDS: {
 ];
 
 function warnOnIgnoredProviderFields(
-  providers: Record<string, Record<string, unknown>>,
+  path: string,
+  providers: Record<string, ProviderSettings>,
 ): void {
   for (const [name, provider] of Object.entries(providers)) {
+    const p = provider as unknown as Record<string, unknown>;
     const present = IGNORED_PROVIDER_FIELDS.filter(
-      (field) => field.path(provider) !== undefined,
-    ).map((field) => field.key);
+      (field) => field.path(p) !== undefined,
+    ).map((field) => field.display);
     if (present.length > 0) {
       process.stderr.write(
-        `settings: provider "${name}" sets fields that are not honored by Corbits and are ignored: ${present.join(", ")}. These will not be applied.\n`,
+        `settings: ${path}: provider "${name}" sets fields that are not honored by Corbits and will be ignored: ${present.join(", ")}. These fields are not yet supported; configure effort/thinking via provider/model-level settings.\n`,
       );
     }
   }
@@ -1081,9 +1090,7 @@ function normalizeParsedSettings(path: string, parsed: unknown): Settings {
     throw settingsSchemaError(path);
   }
   const s = parsed as unknown as Record<string, unknown>;
-  warnOnIgnoredProviderFields(
-    s.providers as Record<string, Record<string, unknown>>,
-  );
+  warnOnIgnoredProviderFields(path, parsed.providers);
   // These keys were removed when plugins moved to discovery; they are now
   // silently dropped on the next save. Warn so a user who relied on them knows
   // to re-enable the equivalent plugins in /plugins instead of losing the