Skip to content

Commit 40e1ca0

Browse files
committed
fix(prompts): synthesize requirements in planner card
1 parent 596e138 commit 40e1ca0

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

‎packages/prompt-fragments/src/cards.ts‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,10 @@ Core artifacts:
8080
Workflow:
8181
1. Clarify requirements: read the brief's goals and success_criteria. If critical unknowns remain, ask the parent via ask_director; otherwise resolve ambiguity under explicit Assumptions.
8282
2. Inspect the codebase: read relevant paths, existing contracts, and test patterns to ground the plan in reality.
83-
3. Produce the plan: author the requested artifacts (PRD.md / SOLUTION_SCOPE.md / BUILD_PLAN.md when requested, or include the structured plan directly in Findings).
84-
4. Report: use the standard ${REPORT_ENVELOPE_SHAPE} report envelope. Findings must carry the complete ordered plan, acceptance criteria, non-goals, and risks.
83+
3. Synthesize, do not append: consolidate iterative operator turns and feedback into a coherent domain model and unified requirement set instead of mechanically appending each conversational idea as a separate chronological row or section.
84+
4. State scope boundaries once: declare non-goals and deferred scope once in SOLUTION_SCOPE.md (or a single section header); never repeat multi-sentence negative-scope disclaimers inside every requirement or concept row.
85+
5. Produce the plan: author the requested artifacts (PRD.md / SOLUTION_SCOPE.md / BUILD_PLAN.md when requested, or include the structured plan directly in Findings).
86+
6. Report: use the standard ${REPORT_ENVELOPE_SHAPE} report envelope. Findings must carry the complete ordered plan, acceptance criteria, non-goals, and risks.
8587
8688
${outOfLane("shipping product implementation code, executing test suites for product verification, fleet orchestration or spawning, becoming Coder or Reviewer as primary")}`;
8789

‎src/agent/directors/prompt-card.test.ts‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,12 @@ describe("director cards compose from prompt-fragments", () => {
3636
),
3737
);
3838
expect(DIRECTOR_CARDS.dispatch).toContain(dispatchRouteSection());
39+
expect(DIRECTOR_CARDS.planner.startsWith(identityLine("Planner"))).toBe(
40+
true,
41+
);
42+
expect(DIRECTOR_CARDS.planner).toContain(REPORT_ENVELOPE_SHAPE);
43+
expect(DIRECTOR_CARDS.planner).toMatch(/Synthesize, do not append/i);
44+
expect(DIRECTOR_CARDS.planner).toMatch(/State scope boundaries once/i);
3945
expect(DISPATCH_ROUTE_ROWS.map((row) => row.lane).sort()).toEqual(
4046
DIRECTOR_IDS.filter((id) => id !== "dispatch").sort(),
4147
);

0 commit comments

Comments
 (0)