style(config): tighten ignored-provider-fields warn

Author: TheGreatAxios

src/config/settings.ts

@@ -1039,9 +1039,9 @@ function settingsSchemaError(path: string): Error {
 // Provider blocks from some external tools carry fields Corbits does not
 // honor: compat.supportsReasoningEffort, supportsThinkingTokenBudget,
 // thinkingLevelMap, samplingParams. ProviderSettingsSchema does not reject
-// unknown keys, so they pass validation and are silently dropped. Warn when
-// any are present so the ignore is never silent. CL-10226 (Part 1): the field
-// mappings themselves are separate follow-ups — this only surfaces the warn.
+// unknown keys, so they pass validation and are silently dropped. Warn so the
+// ignore is never silent. CL-10226 (Part 1): field mappings are a separate
+// follow-up — this only surfaces the warn.
 const IGNORED_PROVIDER_FIELDS: {
   key: string;
   path: (p: Record<string, unknown>) => unknown;
@@ -1054,31 +1054,19 @@ const IGNORED_PROVIDER_FIELDS: {
   { key: "samplingParams", path: (p) => p.samplingParams },
   {
     key: "compat.supportsReasoningEffort",
-    path: (p) =>
-      typeof p.compat === "object" &&
-      p.compat !== null &&
-      (p.compat as Record<string, unknown>).supportsReasoningEffort !==
-        undefined
-        ? (p.compat as Record<string, unknown>).supportsReasoningEffort
-        : undefined,
+    path: (p) => {
+      const compat = p.compat as Record<string, unknown> | undefined;
+      return compat?.supportsReasoningEffort;
+    },
   },
 ];
 
-function warnOnIgnoredProviderFields(providers: unknown): void {
-  if (
-    providers === undefined ||
-    typeof providers !== "object" ||
-    providers === null
-  ) {
-    return;
-  }
-  for (const [name, provider] of Object.entries(
-    providers as Record<string, unknown>,
-  )) {
-    if (typeof provider !== "object" || provider === null) continue;
-    const p = provider as Record<string, unknown>;
+function warnOnIgnoredProviderFields(
+  providers: Record<string, Record<string, unknown>>,
+): void {
+  for (const [name, provider] of Object.entries(providers)) {
     const present = IGNORED_PROVIDER_FIELDS.filter(
-      (field) => field.path(p) !== undefined,
+      (field) => field.path(provider) !== undefined,
     ).map((field) => field.key);
     if (present.length > 0) {
       process.stderr.write(
@@ -1093,7 +1081,9 @@ function normalizeParsedSettings(path: string, parsed: unknown): Settings {
     throw settingsSchemaError(path);
   }
   const s = parsed as unknown as Record<string, unknown>;
-  warnOnIgnoredProviderFields(s.providers);
+  warnOnIgnoredProviderFields(
+    s.providers as Record<string, Record<string, unknown>>,
+  );
   // These keys were removed when plugins moved to discovery; they are now
   // silently dropped on the next save. Warn so a user who relied on them knows
   // to re-enable the equivalent plugins in /plugins instead of losing the