feat(reviewer): ship reviewer as a workspace agent package

Extract @corbits/agent-reviewer following the agents/explorer precedent
(PR #1339): byte-identical prompt, order-identical tools, registry imports
the workspace dep, in-tree package.ts deleted with no shim, co-located
drift test, tsconfig paths + workspaces dep + bun.lock.

Fixes CL-9799

Author: TheGreatAxios

agents/reviewer/package.json

@@ -0,0 +1,13 @@
+{
+  "name": "@corbits/agent-reviewer",
+  "version": "0.1.0",
+  "private": true,
+  "type": "module",
+  "license": "SEE LICENSE IN LICENSE.md",
+  "exports": {
+    ".": {
+      "types": "./src/index.ts",
+      "default": "./src/index.ts"
+    }
+  }
+}

src/agent/directors/reviewer/package.ts agents/reviewer/src/index.tssrc/agent/directors/reviewer/package.ts renamed to agents/reviewer/src/index.ts

@@ -1,12 +1,49 @@
-import type { DirectorPackage } from "../types.js";
-import { BUILD_TOOLS } from "../tool-sets.js";
-
 /**
  * Reviewer worker: code defect review + verify-by-temporary-test workflow.
  * Finds defects with reproducible evidence, validates hypotheses with temp tests,
  * and checks API contracts and hygiene without modifying product code.
+ *
+ * Ships as the @corbits/agent-reviewer workspace package: the tool allowlist
+ * lives here so the package stays importable without the app. Drift against
+ * the app build surface fails src/agent/directors/reviewer/package.test.ts.
  */
-export const reviewerPackage: DirectorPackage = {
+export type AgentPackage = {
+  readonly id: "reviewer";
+  readonly primaryIntent: string;
+  readonly outOfLane: readonly string[];
+  readonly description: string;
+  readonly systemPrompt: string;
+  /** Unset — reviewer never attaches skill bodies at spawn. */
+  readonly attachedSkills?: readonly string[];
+  /** Unset — reviewer declares no skill scope. */
+  readonly optionalSkills?: readonly string[];
+  readonly tools: {
+    readonly allow: readonly string[];
+  };
+  readonly spawn: {
+    readonly maySpawn: false;
+  };
+  readonly modelRole: "review";
+  readonly tier: "leaf";
+};
+
+const REVIEWER_TOOLS = [
+  "read_file",
+  "grep",
+  "search_files",
+  "list_dir",
+  "lsp",
+  "run_shell",
+  "web_fetch",
+  "web_search",
+  "skill_search",
+  "use_skill",
+  "write_file",
+  "edit_file",
+  "delete_file",
+] as const;
+
+export const reviewerPackage: AgentPackage = {
   id: "reviewer",
   primaryIntent:
     "Evidence-based code defect review and verification via temporary reproduction tests; never fix product code",
@@ -19,10 +56,6 @@ export const reviewerPackage: DirectorPackage = {
   ],
   description:
     "Code quality and defect reviewer — evidence-based findings with temp test verification",
-  tools: { allow: BUILD_TOOLS },
-  spawn: { maySpawn: false },
-  tier: "leaf",
-  modelRole: "review",
   systemPrompt: `You are ReviewerDirector (Reviewer), a specialist in Corbits Code.
 
 PRIMARY INTENT: evidence-based code review and defect verification. Find defects with evidence; verify suspected bugs with temporary tests; never fix product code. Cite path, line or symbol, what breaks, and the concrete input or sequence that triggers the failure.
@@ -52,4 +85,8 @@ Report envelope:
 - Report "This diff is genuinely clean" when no actionable defects exist.
 
 OUT OF LANE: implementing product fixes (route to coder), visual styling / DESIGN.md (route to designer), fleet orchestration or spawning.`,
+  tools: { allow: [...REVIEWER_TOOLS] },
+  spawn: { maySpawn: false },
+  tier: "leaf",
+  modelRole: "review",
 };

bun.lock

@@ -86,6 +86,7 @@
     "tar": "^7.5.1"
   },
   "dependencies": {
+    "@corbits/agent-reviewer": "workspace:*",
     "@corbits/codex-provider": "0.1.1",
     "@corbits/oauth-core": "0.2.0",
     "@corbits/openai-responses": "0.2.1",

package.json

@@ -1,3 +1,4 @@
+import { reviewerPackage } from "@corbits/agent-reviewer";
 import type { AgentProfile, CapabilityFilter } from "../profile-types.js";
 import { director as artistDirector } from "@corbits/code-agent-artist";
 import { coderPackage } from "./coder/package.js";
@@ -7,7 +8,6 @@ import { explorerPackage } from "./explorer/package.js";
 import { plannerPackage } from "./planner/package.js";
 import { proberPackage } from "./prober/package.js";
 import { qaLeadPackage } from "./qa-lead/package.js";
-import { reviewerPackage } from "./reviewer/package.js";
 import { shakespearePackage } from "./shakespeare/package.js";
 import { wardenPackage } from "./warden/package.js";
 import { formatDirectorSystemPrompt } from "./identity.js";

src/agent/directors/registry.ts

@@ -0,0 +1,26 @@
+import { describe, expect, test } from "bun:test";
+
+import { reviewerPackage } from "@corbits/agent-reviewer";
+import { BUILD_TOOLS } from "../tool-sets.js";
+import { DIRECTOR_REGISTRY } from "../registry.js";
+import type { DirectorPackage } from "../types.js";
+
+describe("reviewerPackage", () => {
+  test("workspace package satisfies the director contract and feeds the registry", () => {
+    const asDirector: DirectorPackage = reviewerPackage;
+    expect(asDirector.id).toBe("reviewer");
+    expect(DIRECTOR_REGISTRY.reviewer).toBe(reviewerPackage);
+    expect([...reviewerPackage.tools.allow]).toEqual([...BUILD_TOOLS]);
+  });
+
+  test("extracted copy stays review-scoped and non-spawning", () => {
+    expect(reviewerPackage.tools.allow).toContain("write_file");
+    expect(reviewerPackage.tools.allow).toContain("edit_file");
+    expect(reviewerPackage.tools.allow).toContain("delete_file");
+    expect(reviewerPackage.tools.allow).not.toContain("spawn_agent");
+    expect(reviewerPackage.tools.allow).not.toContain("ask_operator");
+    expect(reviewerPackage.spawn.maySpawn).toBe(false);
+    expect(reviewerPackage.tier).toBe("leaf");
+    expect(reviewerPackage.modelRole).toBe("review");
+  });
+});

src/agent/directors/reviewer/package.test.ts

@@ -6,6 +6,7 @@
     "baseUrl": ".",
     "paths": {
       "@corbits/code-agent-artist": ["./agents/artist/src/index.ts"],
+      "@corbits/agent-reviewer": ["./agents/reviewer/src/index.ts"],
       "@corbits/provider-opencode-go": ["./packages/opencode-go/src/index.ts"],
       "@corbits/first-class-providers": [
         "./packages/first-class-providers/src/index.ts"
@@ -18,6 +19,7 @@
     "src/**/*.ts",
     "testkit/**/*.ts",
     "packages/**/*.ts",
+    "agents/**/*.ts",
     "e2e/**/*.ts",
     "evals/**/*.ts",
     "scripts/**/*.ts",