Merge pull request #1439 from corbitsdev/cl-10669-agentdirector-consolidation-one-definition-one

refactor(agents): one toolset source, one nudge runtime, one lifecycle projection

Author: TheGreatAxios

agents/artist/README.md

@@ -3,25 +3,18 @@
 ## What this is
 
 Ready `@corbits/code-agent-artist` agent + independently importable components:
-`agent`, `defineAgent`, `director`, `tools`, `systemPrompt`, `config`.
-
-## Consume (runLocal)
-
-```ts
-import { agent } from "@corbits/code-agent-artist";
-const run = runLocal(defining(agent), env);
-```
-
-## Consume (deploy runWorkflow / hub / sidecar)
-
-Hand the same `AgentDefinition` to a workflow — the package never exports a
-workflow itself.
+`director`, `tools`, `systemPrompt`, `config`.
 
 ## Remix components
 
 ```ts
-import { director, tools, systemPrompt, config } from "@corbits/code-agent-artist";
-defineAgent({ director, ... }); // or swap tools / systemPrompt / config
+import {
+  director,
+  tools,
+  systemPrompt,
+  config,
+} from "@corbits/code-agent-artist";
+// or swap tools / systemPrompt / config
 ```
 
 Each of `director`, `tools`, `systemPrompt`, and `config` is a named,
@@ -30,6 +23,6 @@ independently importable part.
 ## Single authority
 
 `prompt.ts` `systemPrompt.build()` is byte-stable (the raw card, no formatting).
-`toolset.ts` `tools` literal equals the `REVIEW_TOOLS` surface constant in
+`toolset.ts` `tools` re-exports the `REVIEW_TOOLS` surface constant in
 `src/agent/directors/tool-sets.ts`; drift is enforced by the in-tree drift-guard
 `src/agent/directors/artist/package.test.ts`.

agents/artist/src/agent.ts

@@ -1,4 +1,3 @@
-export { agent, defineAgent } from "./agent.js";
 export { director } from "./director.js";
 export { tools } from "./toolset.js";
 export { systemPrompt } from "./prompt.js";

agents/artist/src/index.ts

@@ -1,15 +1,3 @@
-export const tools: readonly string[] = [
-  "read_file",
-  "grep",
-  "search_files",
-  "list_dir",
-  "lsp",
-  "run_shell",
-  "web_fetch",
-  "web_search",
-  "skill_search",
-  "use_skill",
-  "write_file",
-  "edit_file",
-  "delete_file",
-] as const;
+import { REVIEW_TOOLS } from "../../../src/agent/directors/tool-sets.js";
+
+export const tools = REVIEW_TOOLS;

agents/artist/src/toolset.ts

@@ -3,35 +3,28 @@
 ## What this is
 
 Ready `@corbits/code-agent-coder` agent + independently importable components:
-`agent`, `defineAgent`, `director`, `tools`, `systemPrompt`, `config`. Coder is
+`director`, `tools`, `systemPrompt`, `config`. Coder is
 the implementation specialist: minimal safe diffs, root-cause fixes at the proper
 layer, zero unnecessary abstractions, tests landed with changes, repo check gate.
 
-## Consume (runLocal)
-
-```ts
-import { agent } from "@corbits/code-agent-coder";
-const run = runLocal(defining(agent), env);
-```
-
-## Consume (deploy runWorkflow / hub / sidecar)
-
-Hand the same `AgentDefinition` to a workflow — the package never exports a
-workflow itself.
-
 ## Remix components
 
 ```ts
-import { director, tools, systemPrompt, config } from "@corbits/code-agent-coder";
-defineAgent({ director, ... }); // or swap tools / systemPrompt / config
+import {
+  director,
+  tools,
+  systemPrompt,
+  config,
+} from "@corbits/code-agent-coder";
+// or swap tools / systemPrompt / config
 ```
 
-Each of `agent`, `defineAgent`, `director`, `tools`, `systemPrompt`, `config` is a
+Each of `director`, `tools`, `systemPrompt`, `config` is a
 named, independently importable part.
 
 ## Single authority
 
 `prompt.ts` `systemPrompt.build()` is byte-stable (the raw card, no formatting).
-`toolset.ts` `tools` literal equals the `BUILD_TOOLS` surface constant in
+`toolset.ts` `tools` re-exports the `BUILD_TOOLS` surface constant in
 `src/agent/directors/tool-sets.ts`; drift is enforced by the in-tree drift-guard
 `src/agent/directors/coder/package.test.ts`.

agents/coder/README.md

@@ -1,4 +1,3 @@
-export { agent, defineAgent } from "./agent.js";
 export { director } from "./director.js";
 export { tools } from "./toolset.js";
 export { systemPrompt } from "./prompt.js";

agents/coder/src/agent.ts

@@ -1,17 +1,3 @@
-// BUILD_TOOLS literal; drift-guarded against src/agent/directors/tool-sets.ts.
+import { BUILD_TOOLS } from "../../../src/agent/directors/tool-sets.js";
 
-export const tools = [
-  "read_file",
-  "grep",
-  "search_files",
-  "list_dir",
-  "lsp",
-  "run_shell",
-  "web_fetch",
-  "web_search",
-  "skill_search",
-  "use_skill",
-  "write_file",
-  "edit_file",
-  "delete_file",
-] as const;
+export const tools = BUILD_TOOLS;

agents/coder/src/index.ts

@@ -3,25 +3,18 @@
 ## What this is
 
 Ready `@corbits/code-agent-designer` agent + independently importable components:
-`agent`, `defineAgent`, `director`, `tools`, `systemPrompt`, `config`.
-
-## Consume (runLocal)
-
-```ts
-import { agent } from "@corbits/code-agent-designer";
-const run = runLocal(defining(agent), env);
-```
-
-## Consume (deploy runWorkflow / hub / sidecar)
-
-Hand the same `AgentDefinition` to a workflow — the package never exports a
-workflow itself.
+`director`, `tools`, `systemPrompt`, `config`.
 
 ## Remix components
 
 ```ts
-import { director, tools, systemPrompt, config } from "@corbits/code-agent-designer";
-defineAgent({ director, ... }); // or swap tools / systemPrompt / config
+import {
+  director,
+  tools,
+  systemPrompt,
+  config,
+} from "@corbits/code-agent-designer";
+// or swap tools / systemPrompt / config
 ```
 
 Each of `director`, `tools`, `systemPrompt`, and `config` is a named,
@@ -30,6 +23,6 @@ independently importable part.
 ## Single authority
 
 `prompt.ts` `systemPrompt.build()` is byte-stable (the raw card, no formatting).
-`toolset.ts` `tools` literal equals the `REVIEW_TOOLS` surface constant in
+`toolset.ts` `tools` re-exports the `REVIEW_TOOLS` surface constant in
 `src/agent/directors/tool-sets.ts`; drift is enforced by the in-tree drift-guard
 `src/agent/directors/designer/package.test.ts`.