Skip to content

Commit 08663bc

Browse files
committed
docs(config): correct the topP test comment
1 parent bc5a04b commit 08663bc

2 files changed

Lines changed: 7 additions & 7 deletions

File tree

‎src/config.test.ts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1467,11 +1467,11 @@ describe("buildOpenAISource", () => {
14671467
});
14681468
});
14691469

1470-
test("flows temperature and top_p together when both are present (CL-10760)", () => {
1471-
// The temperature/topP exclusion lives in the settings schema (load
1472-
// rejects both); buildOpenAISource itself merges whatever it is given, so
1473-
// provider-mandated pairs (e.g. DeepSeek V4 model-card defaults) still
1474-
// reach the wire.
1470+
test("flows temperature and top_p together when both are present", () => {
1471+
// Settings load rejects both knobs. This builder still forwards a pair
1472+
// it is given. DeepSeek V4 model-card defaults reach the wire because
1473+
// the adapter writes top_p 0.95 and temperature 1.0 when each body
1474+
// field is absent, not because this merge supplies those defaults.
14751475
const source = buildOpenAISource({
14761476
id: "fp",
14771477
baseURL: "https://fp/v1",

‎src/config/settings.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,8 @@ test("provider settings reject simultaneous sampling fields but preserve zero",
8585
expect(isSettings({ providers: { custom: { ...provider, topP: 0 } } })).toBe(
8686
false,
8787
);
88-
// CL-10760: the exclusion is enforced at load, not just by isSettings —
89-
// a persisted file with both knobs fails to load.
88+
// The exclusion is enforced at load, not just by isSettings — a persisted
89+
// file with both knobs fails to load.
9090
const cwd = await mkdtemp(join(tmpdir(), "both-sampling-knobs-"));
9191
try {
9292
const path = join(cwd, "settings.json");

0 commit comments

Comments
 (0)