Skip to content

Commit 049ee93

Browse files
committed
Review skill recommends the fleet instead of routing it
Skills do not route the fleet: classify-and-recommend, primary dispatches. Worktree checkout belongs to pull-request-review.
1 parent 573a314 commit 049ee93

2 files changed

Lines changed: 18 additions & 6 deletions

File tree

‎plugins/corbits-skills/skills/review/SKILL.md‎

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,12 @@ description: Perform a code review or pull request review on a branch
77

88
Use this skill when performing code reviews or pull request reviews.
99

10-
## Classify, Then Dispatch a Selected Fleet
10+
## Classify, Then Recommend a Selected Fleet
1111

12-
First classify the review target, then dispatch only the fleet the
13-
target warrants. Do not fan out a default wide fleet.
12+
First classify the review target, then recommend only the fleet the
13+
target warrants. Do not fan out a default wide fleet. This skill does
14+
not route the fleet — the primary (Skywalker orchestrator) dispatches;
15+
the classification below tells it which lenses the target warrants.
1416

1517
Classify the review target as one of:
1618

@@ -19,15 +21,14 @@ Classify the review target as one of:
1921
- Interview: only when the review object or base is genuinely missing.
2022
Never run interview as ritual.
2123

22-
Then dispatch a selected fleet with `spawn_agent`, one target per wave:
24+
Then the primary dispatches the warranted lenses with `spawn_agent`, one target per wave:
2325

2426
- Critic always.
2527
- Greybeard when architecture, API, or approach is at stake.
2628
- Draper, Emil, Gaasbot, Bruckheimer, or Neckbeard only when the
2729
touched files warrant that lens.
2830

29-
When the target is a PR, read the PR tree (fetch the PR branch into a
30-
worktree) — never review the local checkout as a stand-in for the PR.
31+
When the target is a PR, read the PR tree from the worktree — worktree checkout belongs to `/pull-request-review`; never review the local checkout as a stand-in for the PR.
3132

3233
## Base Branch Determination
3334

‎tests/unit/corbits-skills-catalog.test.ts‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -193,6 +193,17 @@ test("review skill is the classify-then-selected-fleet recipe", async () => {
193193
expect(skill).not.toContain("deep-agent-review");
194194
});
195195

196+
test("review skill recommends the fleet but does not route it or own the worktree", async () => {
197+
const skill = await Bun.file(
198+
join(pluginRoot, "skills/review/SKILL.md"),
199+
).text();
200+
expect(skill).toContain("does\nnot route the fleet");
201+
expect(skill).toContain("the primary (Skywalker orchestrator) dispatches");
202+
expect(skill).toContain(
203+
"worktree checkout belongs to `/pull-request-review`",
204+
);
205+
});
206+
196207
test("review skill gates interview as exception, never ritual", async () => {
197208
const skill = await Bun.file(
198209
join(pluginRoot, "skills/review/SKILL.md"),

0 commit comments

Comments
 (0)