diff --git a/apps/web/src/config.ts b/apps/web/src/config.ts index db60e02b..00462016 100644 --- a/apps/web/src/config.ts +++ b/apps/web/src/config.ts @@ -709,8 +709,6 @@ export const wording = { actions: { design_app: { approve: "Start the design", - /** Later design starts in this project's run go ahead without a card. */ - approveAlways: "Start designs without asking", deny: "Not yet", }, } as Record< diff --git a/apps/web/src/pages/workspace/document-decision.tsx b/apps/web/src/pages/workspace/document-decision.tsx index 1cda6ab6..b7408adc 100644 --- a/apps/web/src/pages/workspace/document-decision.tsx +++ b/apps/web/src/pages/workspace/document-decision.tsx @@ -22,10 +22,6 @@ import type { ApprovalOutcome, DocumentApproval } from "./transcript.tsx"; const text = wording.approval; const INSTRUCTION_ASKS = new Set(["instruct_coder"]); const FOLDED_INSTRUCTION_ASKS = new Set(["design_app"]); -// Asks that record no approval of document versions, where the native standing -// grant only lets later calls in the run go ahead. Every other card records an -// approval of the exact versions shown, so it hides the library's Approve always. -const STANDING_ASKS = new Set(["design_app"]); function shortName(approval: DocumentApproval): string | undefined { const { document } = approval; @@ -118,7 +114,6 @@ export function DocumentDecision({ disabled = false, error, onYes, - onAlways, onNo, countdown, }: { @@ -149,10 +144,8 @@ export function DocumentDecision({ }; const instruction = approval.instruction; const tool = approval.toolName ?? ""; - const standing = STANDING_ASKS.has(tool); const decide = (decision: ToolApprovalDecision) => { if (decision.outcome === "rejected") onNo(); - else if (standing && decision.scope === "always") onAlways(); else onYes(); }; const sources = approval.sources ?? []; @@ -184,11 +177,7 @@ export function DocumentDecision({ ); return ( { expect(html).not.toContain("sha256"); }); + test("a design start does not offer to go ahead without asking", () => { + const html = renderToStaticMarkup( + {}} + onAlways={() => {}} + onNo={() => {}} + />, + ); + expect(html).toContain("document-decision-once"); + expect(html).toContain(">Start the design<"); + expect(html).not.toContain("Start designs without asking"); + }); + test("Not yet denies the approval and then takes the person to the composer", () => { const calls: string[] = []; const thread = RoomThread({ diff --git a/docs/USER_MANUAL.md b/docs/USER_MANUAL.md index af53c43b..663f3278 100644 --- a/docs/USER_MANUAL.md +++ b/docs/USER_MANUAL.md @@ -246,8 +246,6 @@ Before any designer starts, a card asks **Ready to start the design?** and lists the **Design concepts to compare** it will make. - **Start the design** lets it begin. -- **Start designs without asking** also lets later design starts in this - project go ahead without a card. - **Not yet** stops it so you can say what to change. If you asked to explore, you get as many concepts as **Design concepts to