fix(pptx): allow animating grouped elements again

The rule rested on an unreproduced claim about PowerPoint.

Author: TheGreatAxios

packages/pptx/src/deck.ts

@@ -618,7 +618,6 @@ function freeSlideIssues(slide: Slide, index: number): DeckIssue[] {
   if (slide.layout !== "free") return [];
   const issues: DeckIssue[] = [];
   const ids = new Set<string>();
-  const grouped = new Set<string>();
   const slidePath = ["slides", index, "elements"];
   for (const [element, path] of freeElements(slide.elements, slidePath)) {
     if (element.id !== undefined && ids.has(element.id))
@@ -629,8 +628,6 @@ function freeSlideIssues(slide: Slide, index: number): DeckIssue[] {
         ),
       );
     if (element.id !== undefined) ids.add(element.id);
-    if (element.id !== undefined && path.length > slidePath.length + 1)
-      grouped.add(element.id);
     if (element.type === "group") continue;
     if (element.type === "image" && element.crop) {
       const { top, right, bottom, left } = element.crop;
@@ -664,13 +661,6 @@ function freeSlideIssues(slide: Slide, index: number): DeckIssue[] {
           `names "${animation.target}", which no element on this slide has as its id`,
         ),
       );
-    if (grouped.has(animation.target))
-      issues.push(
-        issueAt(
-          [...path, "target"],
-          `names "${animation.target}", which is inside a group; only elements directly on the slide animate`,
-        ),
-      );
     if (animation.trigger === "afterPrevious" && endless)
       issues.push(
         issueAt(

packages/pptx/test/fixture.ts

@@ -282,6 +282,7 @@ export const deck: DeckInput = {
               opacity: 0.8,
               children: [
                 {
+                  id: "divider",
                   type: "shape",
                   geometry: "line",
                   x: 120,
@@ -292,51 +293,51 @@ export const deck: DeckInput = {
                 },
               ],
             },
-          ],
-        },
-        {
-          id: "headline",
-          type: "text",
-          x: 120,
-          y: 240,
-          w: 480,
-          h: 160,
-          anchor: "middle",
-          insets: { top: 4, right: 8, bottom: 4, left: 8 },
-          link: 0,
-          paragraphs: [
             {
-              lineHeight: 64,
-              runs: [
+              id: "headline",
+              type: "text",
+              x: 120,
+              y: 240,
+              w: 480,
+              h: 160,
+              anchor: "middle",
+              insets: { top: 4, right: 8, bottom: 4, left: 8 },
+              link: 0,
+              paragraphs: [
                 {
-                  text: "Designed\nslides",
-                  font: "Georgia",
-                  size: 56,
-                  weight: 800,
-                  letterSpacing: -1,
-                  color: {
-                    type: "linear",
-                    angle: 90,
-                    stops: [
-                      { color: "primary", at: 0 },
-                      { color: "secondary", at: 100 },
-                    ],
-                  },
+                  lineHeight: 64,
+                  runs: [
+                    {
+                      text: "Designed\nslides",
+                      font: "Georgia",
+                      size: 56,
+                      weight: 800,
+                      letterSpacing: -1,
+                      color: {
+                        type: "linear",
+                        angle: 90,
+                        stops: [
+                          { color: "primary", at: 0 },
+                          { color: "secondary", at: 100 },
+                        ],
+                      },
+                    },
+                  ],
                 },
-              ],
-            },
-            {
-              align: "center",
-              spaceBefore: 12,
-              runs: [
-                "Text, ",
-                { text: "italic", italic: true, weight: 300 },
-                " and a ",
                 {
-                  text: "link",
-                  link: "https://corbits.dev",
-                  color: "#0EA5E9",
-                  underline: true,
+                  align: "center",
+                  spaceBefore: 12,
+                  runs: [
+                    "Text, ",
+                    { text: "italic", italic: true, weight: 300 },
+                    " and a ",
+                    {
+                      text: "link",
+                      link: "https://corbits.dev",
+                      color: "#0EA5E9",
+                      underline: true,
+                    },
+                  ],
                 },
               ],
             },
@@ -407,7 +408,7 @@ export const deck: DeckInput = {
         },
         { target: "cover", effect: "zoom", kind: "entrance", duration: 700 },
         {
-          target: "tag",
+          target: "divider",
           effect: "wipe",
           kind: "entrance",
           side: "left",
@@ -420,7 +421,7 @@ export const deck: DeckInput = {
           trigger: "withPrevious",
         },
         { target: "tag", effect: "pulse", repeat: 3 },
-        { target: "card", effect: "scale", scale: 1.1 },
+        { target: "card-back", effect: "scale", scale: 1.1 },
         {
           target: "glow",
           effect: "path",

packages/pptx/test/pptx.test.ts

@@ -217,10 +217,6 @@ test("a free slide names the element of every problem, and groups past ten level
         "slides[1].animations[0].easing",
         "has accel and decel adding up past 1",
       ),
-      at(
-        "slides[1].animations[1].target",
-        'names "c", which is inside a group; only elements directly on the slide animate',
-      ),
       at(
         "slides[1].animations[3].trigger",
         "waits for an animation that repeats indefinitely and never ends",