fix(web): keep a sent message as mail delivers it

Mail delivery drops spaces and tabs at the end of each line, so a
message with them never matched the conversation's copy and showed
twice. One shared rule gives the text mail delivers, and the page sends
and keeps that text for a message, words with files and the opening
idea. A hub test runs the text through Interchange's mail encoding and
decoding, with and without a file, so a change in how mail treats it
fails there.

Author: TheGreatAxios

apps/hub/src/mail/conversation-turns.test.ts

@@ -3,6 +3,13 @@ import { mkdir, mkdtemp, rm, writeFile } from "node:fs/promises";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
 import { $ } from "bun";
+import {
+  assembleSignedContent,
+  decodePartBytes,
+  extractPartByPath,
+  parseMimePart,
+} from "@intx/mime";
+import { deliveredText } from "@corbits-builder/schemas/conversation";
 import { resumeMessage } from "../config/resume.ts";
 import { specialistEndedMessage } from "../config/specialist-ended.ts";
 import { readDurableConversationTurns } from "./conversation-turns.ts";
@@ -98,3 +105,36 @@ test("a resumed message reads back without its held context", async () => {
   const dir = await runRepo([resumeMessage(context, "Line one\n\nLine two")]);
   expect(await personTexts(dir)).toEqual(["Line one\n\nLine two"]);
 });
+
+// The page keeps `deliveredText`; mail must carry it unchanged for the page to recognise its copy.
+const delivered = (text: string, withFile: boolean) => {
+  const file = {
+    name: "notes.txt",
+    contentType: "text/plain",
+    data: new TextEncoder().encode("notes"),
+  };
+  const signed = assembleSignedContent({
+    kind: "conversation",
+    text,
+    ...(withFile ? { attachments: [file] } : {}),
+  });
+  const part = parseMimePart(extractPartByPath(signed, "1"));
+  return new TextDecoder()
+    .decode(decodePartBytes(part.body, part.headers))
+    .replace(/\r\n?/g, "\n");
+};
+
+test("the text a person sends survives mail delivery unchanged", () => {
+  const typed = [
+    "First line  \nsecond line\t\n\nthird ",
+    "On the brief:\n\n> keep it short  ",
+    "café  \nnaïve",
+    `${"a".repeat(80)} \nb`,
+    "tide times \u2028with alerts",
+    "old \rline \r\nbreaks",
+  ];
+  for (const text of typed.map(deliveredText)) {
+    expect(delivered(text, false)).toBe(text);
+    expect(delivered(text, true)).toBe(text);
+  }
+});

apps/web/src/pages/projects.tsx

@@ -30,6 +30,7 @@ import { COMPOSER_BOX_CLASS } from "./workspace/pane-classes.ts";
 import { HOME_COMPOSER_PLACEHOLDER, canStartProject } from "./home-view.ts";
 import "./home-layout.css";
 import type { ProjectImport } from "@corbits-builder/schemas/project-import";
+import { deliveredText } from "@corbits-builder/schemas/conversation";
 
 export function Projects({
   onOpen,
@@ -56,11 +57,11 @@ export function Projects({
     }
     setBusy("start");
     try {
+      const opening = deliveredText(problem);
       const created = await createProject({
-        problemStatement: problem.trim(),
+        problemStatement: opening,
         ...(profile === undefined ? {} : { profile }),
       });
-      const opening = problem.trim();
       setProblem("");
       onChanged();
       // The hub mailed the opening sentence to the coordinator; the workspace

apps/web/src/pages/workspace/index.tsx

@@ -55,6 +55,7 @@ import { ProductApiError, type ProjectArtifact } from "@corbits-builder/client";
 import type { InFlightRun } from "@corbits-builder/schemas/artifact";
 import { toast } from "sonner";
 import { sendMessage, type ConversationTurn } from "../../api/conversation.ts";
+import { deliveredText } from "@corbits-builder/schemas/conversation";
 import { subscribeWorkflowRun } from "../../api/run-stream.ts";
 import { workspaceTenantId } from "../../api/auth.ts";
 import {
@@ -169,7 +170,8 @@ function openingDraft(
   projectId: string,
   openingMessage: string | undefined,
 ): ChatMessage[] {
-  const text = openingMessage?.trim() ?? "";
+  if (openingMessage === undefined) return [];
+  const text = deliveredText(openingMessage);
   if (text.length === 0) return [];
   return [
     {
@@ -669,7 +671,7 @@ export function StageWorkspace({
     body: string,
     clearComposer = false,
   ): Promise<boolean> => {
-    const text = body.trim();
+    const text = deliveredText(body);
     if (text.length === 0 || sending) return false;
     setSending(true);
     setSendFailed(false);
@@ -736,7 +738,7 @@ export function StageWorkspace({
 
   const deliverFiles = async (): Promise<boolean> => {
     if (sending) return false;
-    const text = value.trim();
+    const text = deliveredText(value);
     const attached = files;
     setSending(true);
     setSendFailed(false);

packages/schemas/src/conversation.ts

@@ -8,6 +8,18 @@ export type ConversationMessage = Readonly<{
     Readonly<{ mimeType: string; data: string; name?: string }>
   >;
 }>;
+
+/**
+ * A person's words as mail delivers them and the conversation reads them back: LF line breaks, no
+ * spaces or tabs at the end of a line, trimmed. The page sends and keeps this text, so it recognises
+ * the conversation's copy.
+ */
+export const deliveredText = (text: string) =>
+  text
+    .replace(/\r\n?/g, "\n")
+    .replace(/[ \t]+(?=\n|$)/g, "")
+    .trim();
+
 export const ConversationReceipt = type({
   runId: "string",
   address: "string",