Skip to content

Hide the Settings entry from the profile popover #104

Description

@a-effort

/app/settings already has a permanent home in the sidebar footer (Sidebar.tsx:66), and the profile popover carries no profile-specific actions yet, so the entry is a duplicate affordance. Remove it and leave theme, language and Logout.

On the method, since the ask was to reuse how not-ready pages are hidden: the sidebar uses a hidden?: boolean on its NavItem entries, filtered at render (Sidebar.tsx:37 and :78). That is a good fit there because the nav is array driven, the entry stays visible in source, and restoring it is a one-line change.

It does not transfer here. The popover renders its actions as buttons inline, not from a filtered array, so the same flag would mean building scaffolding for a single element. The app also already has a second mechanism in src/config/features.ts (VITE_ENABLE_TOOL_PREVIEW), and a third shape would make the pattern harder to follow. Prefer deleting the button: git history restores it in one revert. When profile actions do arrive (profile, tokens, password change) the popover gets a real list, and it can adopt whichever flag pattern has settled by then.

Worth knowing for whoever picks this up: hidden: true removes the affordance only. /app/agents is still a live route (App.tsx:107) and still mapped in HeaderQuickNav.tsx:38, so the flag does not gate a page. That does not matter for Settings, whose route stays either way.

Depends on #103, which converts the dropdown to a popover and touches the same block.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions