From a7ef310c1b017ecbe17aa89611f4698ed38b2dc8 Mon Sep 17 00:00:00 2001 From: LucaCappelletti94 Date: Sat, 24 Oct 2026 15:00:03 +0200 Subject: [PATCH] Update the echoes action to v1.10.4 v1.10.4 resolves the review threads of copies a later commit removes and dismisses superseded requests for changes, which needs contents: write on the posting job. Context and reuse comments also get the wrong-review link. --- .github/workflows/echoes-post.yml | 4 +++- .github/workflows/echoes.yml | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/echoes-post.yml b/.github/workflows/echoes-post.yml index 2a0f6b40e..f7c9c3c64 100644 --- a/.github/workflows/echoes-post.yml +++ b/.github/workflows/echoes-post.yml @@ -20,6 +20,8 @@ jobs: timeout-minutes: 5 permissions: actions: read + # Resolving the review threads of copies that are gone needs contents: write. + contents: write pull-requests: write strategy: fail-fast: false @@ -38,7 +40,7 @@ jobs: run-id: ${{ github.event.workflow_run.id }} github-token: ${{ github.token }} - - uses: LucaCappelletti94/cargo-echoes@fe825077e5322a8bd3fa82c8c5a55f2d49cbe016 # v1.10.2 + - uses: LucaCappelletti94/cargo-echoes@14ca2c9fa250b4eb8cd59c47f187b1f2281fb484 # v1.10.4 with: mode: post payload: ${{ runner.temp }}/echoes-payload diff --git a/.github/workflows/echoes.yml b/.github/workflows/echoes.yml index f911dead3..21fd121a0 100644 --- a/.github/workflows/echoes.yml +++ b/.github/workflows/echoes.yml @@ -37,7 +37,7 @@ jobs: with: persist-credentials: false - - uses: LucaCappelletti94/cargo-echoes@fe825077e5322a8bd3fa82c8c5a55f2d49cbe016 # v1.10.2 + - uses: LucaCappelletti94/cargo-echoes@14ca2c9fa250b4eb8cd59c47f187b1f2281fb484 # v1.10.4 with: cwd: ${{ matrix.cwd }} version: 0.9.0