Skip to content

Commit d3dbea5

Browse files
committed
Add preinstall setup to build
Already had this in the release build step, not sure why it is not in the main build step. But we started getting errors building native modules in ci, and this might be why.
1 parent 03f52fd commit d3dbea5

1 file changed

Lines changed: 7 additions & 2 deletions

File tree

‎.github/workflows/build.yaml‎

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -198,9 +198,14 @@ jobs:
198198
- name: Build vscode
199199
if: steps.cache-vscode.outputs.cache-hit != 'true'
200200
run: |
201-
pushd lib/vscode
201+
cd lib/vscode/build
202202
npm ci
203-
popd
203+
cd ..
204+
source ./build/azure-pipelines/linux/setup-env.sh
205+
# Run preinstall script before root dependencies are installed
206+
# so that v8 headers are patched correctly for native modules.
207+
node build/npm/preinstall.ts
208+
cd ../..
204209
npm run build:vscode
205210
# Push up an artifact containing the linux-x64 release.
206211
- run: KEEP_MODULES=1 npm run release

0 commit comments

Comments
 (0)