Skip to content

make prefix a required arg on AWSS3Source etc #52

Description

@tmchartrand

AWSS3Source, AWSS3Target, and GCPCloudStorageSource all have default=None for the prefix field. While the field should certainly be allowed to be empty (ie of type Optional[str]), sending an empty prefix is quite risky for a default behavior and can easily cause unintended consequences.
To prevent this, the default should be removed so that the user must specify default=None or default="" if that is actually desired.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions