refactor: fix remaining not found methods

Author: paulbalandan

system/Images/Handlers/BaseHandler.php

@@ -23,6 +23,8 @@
  * Base image handling implementation.
  *
  * @template T of object
+ *
+ * @method string getPathname()
  */
 abstract class BaseHandler implements ImageHandlerInterface
 {

tests/system/CodeIgniterTest.php

@@ -63,6 +63,7 @@ protected function setUp(): void
         $this->codeigniter = new MockCodeIgniter(new App());
 
         $response = service('response');
+        $this->assertInstanceOf(Response::class, $response);
         $response->pretend();
     }
 
@@ -981,10 +982,7 @@ public function testStartControllerPermitsInvoke(): void
         $startController = self::getPrivateMethodInvoker($this->codeigniter, 'startController');
 
         $this->setPrivateProperty($this->codeigniter, 'method', '__invoke');
-        $startController();
-
-        // No PageNotFoundException
-        $this->expectNotToPerformAssertions();
+        $this->assertNull($startController());
     }
 
     public function testRouteAttributeCacheIntegration(): void

tests/system/Images/GDHandlerTest.php

@@ -346,9 +346,12 @@ public function testImageCopy(): void
             $this->handler->save($this->start . 'work/ci-logo.' . $type);
             $this->assertTrue($this->root->hasChild('work/ci-logo.' . $type));
 
+            /** @var vfsStreamFile $child */
+            $child = $this->root->getChild('work/ci-logo.' . $type);
+
             $this->assertNotSame(
                 file_get_contents($this->origin . 'ci-logo.' . $type),
-                $this->root->getChild('work/ci-logo.' . $type)->getContent(),
+                $child->getContent(),
             );
         }
     }
@@ -380,9 +383,12 @@ public function testImageCompressionGetResource(): void
             $this->handler->save($this->start . 'work/ci-logo.' . $type);
             $this->assertTrue($this->root->hasChild('work/ci-logo.' . $type));
 
+            /** @var vfsStreamFile $child */
+            $child = $this->root->getChild('work/ci-logo.' . $type);
+
             $this->assertNotSame(
                 file_get_contents($this->origin . 'ci-logo.' . $type),
-                $this->root->getChild('work/ci-logo.' . $type)->getContent(),
+                $child->getContent(),
             );
         }
     }
@@ -401,9 +407,12 @@ public function testImageCompressionWithResource(): void
 
             $this->assertTrue($this->root->hasChild('work/ci-logo.' . $type));
 
+            /** @var vfsStreamFile $child */
+            $child = $this->root->getChild('work/ci-logo.' . $type);
+
             $this->assertNotSame(
                 file_get_contents($this->origin . 'ci-logo.' . $type),
-                $this->root->getChild('work/ci-logo.' . $type)->getContent(),
+                $child->getContent(),
             );
         }
     }

tests/system/Models/FindModelTest.php

@@ -133,7 +133,7 @@ public function testFindClearsBinds(): void
         $binds = $this->model->builder()->getBinds();
         $this->assertCount(0, $binds);
 
-        $query = $this->model->getLastQuery();
+        $query = $this->model->db->getLastQuery();
         $this->assertCount(1, $this->getPrivateProperty($query, 'binds'));
     }
 

tests/system/Models/GeneralModelTest.php

@@ -83,7 +83,8 @@ public function testUndefinedModelMethod(): void
     {
         $this->expectException(BadMethodCallException::class);
         $this->expectExceptionMessage('Call to undefined method Tests\Support\Models\UserModel::undefinedMethodCall');
-        $this->createModel(UserModel::class)->undefinedMethodCall();
+
+        $this->createModel(UserModel::class)->undefinedMethodCall(); // @phpstan-ignore method.notFound (Testing Model::__call() fallback)
     }
 
     public function testSetAllowedFields(): void

tests/system/RESTful/ResourceControllerTest.php

@@ -80,6 +80,7 @@ private function createCodeigniter(): void
         $this->codeigniter = new MockCodeIgniter($config);
 
         $response = service('response');
+        $this->assertInstanceOf(Response::class, $response);
         $response->pretend();
     }
 

utils/phpstan-baseline/loader.neon

@@ -1,4 +1,4 @@
-# total 153 errors
+# total 145 errors
 
 includes:
     - argument.type.neon
@@ -8,7 +8,6 @@ includes:
     - function.resultUnused.neon
     - method.childParameterType.neon
     - method.childReturnType.neon
-    - method.notFound.neon
     - missingType.iterableValue.neon
     - missingType.parameter.neon
     - property.defaultValue.neon