fix: make fetchFromArray protected and avoid short ternary

- fetchFromArray() must be protected so IncomingRequest (a subclass) can
  call it.
- Replace the short ternary in getRequestData() with explicit checks to
  satisfy the static analysis rules.
- Drop the cookie assertion from the test since request_order defaults
  to GP (no cookies).

Author: rahul05ranjan

system/HTTP/RequestTrait.php

@@ -305,7 +305,7 @@ public function fetchGlobal(string $name, $index = null, ?int $filter = null, $f
      *
      * @return mixed
      */
-    private function fetchFromArray(array $data, $index = null, ?int $filter = null, $flags = null)
+    protected function fetchFromArray(array $data, $index = null, ?int $filter = null, $flags = null)
     {
         // Null filters cause null values to return.
         $filter ??= FILTER_UNSAFE_RAW;

system/Superglobals.php

@@ -401,7 +401,13 @@ public function setRequestArray(array $array): self
      */
     public function getRequestData(): array
     {
-        $requestOrder = ini_get('request_order') ?: ini_get('variables_order') ?: 'GP';
+        $requestOrder = ini_get('request_order');
+        if ($requestOrder === false || $requestOrder === '') {
+            $requestOrder = ini_get('variables_order');
+        }
+        if ($requestOrder === false || $requestOrder === '') {
+            $requestOrder = 'GP';
+        }
 
         $request = [];
 

tests/system/SuperglobalsTest.php

@@ -302,17 +302,15 @@ public function testRequestSetArray(): void
         $this->assertSame($data, $_REQUEST);
     }
 
-    public function testGetRequestDataMergesGetPostCookie(): void
+    public function testGetRequestDataMergesGetAndPost(): void
     {
         $this->superglobals->setGetArray(['get_key' => 'get_value']);
         $this->superglobals->setPostArray(['post_key' => 'post_value']);
-        $this->superglobals->setCookieArray(['cookie_key' => 'cookie_value']);
 
         $data = $this->superglobals->getRequestData();
 
         $this->assertSame('get_value', $data['get_key']);
         $this->assertSame('post_value', $data['post_key']);
-        $this->assertSame('cookie_value', $data['cookie_key']);
     }
 
     public function testGetRequestDataReflectsGetChanges(): void