From 253ffbf75c081608c30f919481c014c079f01794 Mon Sep 17 00:00:00 2001 From: antoinetoussaint-byte <312536060+antoinetoussaint-byte@users.noreply.github.com> Date: Sun, 25 Oct 2026 21:19:30 -0400 Subject: [PATCH] fix(test): the Connect-only sync test owns its containers `codefly publish` runs the source tests below the agent process, so the test binary inherits the agent's CODEFLY_CONTAINER_RECOVERY_SCOPE marker, which names a pid that is neither the test binary nor its parent. Core refuses to create a container under it, so TestConnectOnlyServiceSyncs (4c35bc0, #113) failed release-grade agent CI with "container recovery marker does not belong to this process or its launching parent" and aborted the 0.0.122 publish. GitHub CI sets no marker, so main was green. The test now calls ownTestContainers, as every other container-backed test here does, and takes a scope of its own. Verified: with a foreign marker in the environment the test fails with that refusal before this change; after it, the refusal is gone in both the marker and no-marker runs. Both runs then stop at Buf's BSR rate limit ("resource_exhausted: too many requests", no BSR login on this machine), and the unchanged test fails the same way with no marker, so that stop is environmental and not this change. Co-Authored-By: Claude Opus 5.5 --- connect_only_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/connect_only_test.go b/connect_only_test.go index faa60e8..f6c110b 100644 --- a/connect_only_test.go +++ b/connect_only_test.go @@ -142,6 +142,7 @@ func TestConnectOnlyServiceSyncs(t *testing.T) { if err := exec.Command("docker", "info").Run(); err != nil { t.Skipf("docker is not available, Buf cannot run: %v", err) } + ownTestContainers(t) ctx := context.Background() created, root := createConnectOnlyService(t) identity, err := created.Identity.Proto()