From 4ff476473aaf13a223c3eb1aeabf6c0181bdeefb Mon Sep 17 00:00:00 2001 From: Antoine Toussaint <312536060+antoinetoussaint-byte@users.noreply.github.com> Date: Tue, 3 Nov 2026 22:29:28 -0500 Subject: [PATCH] fix(lint): check the three return values errcheck found in accounts and store tests The Go lint job added in #1297 was clean at its own head, but #1298 (accounts) and #1295's base (store) landed test code written before that job existed. golangci-lint v2.14.0 reports three errcheck findings on main: - accounts rpc_policy_denied_test.go:95 dropped recordPolicyDenial's return. The function passes the refusal through, and the sibling tests in the same file assert exactly that, so this one now asserts it too. - store migration_65_scope_settings_test.go:93 and :164 deferred runner.Close and rows.Close bare; both now use the idiom every other migration test in the package already uses. No exclusion, no nolint. Both modules report 0 issues under the CI command. Co-Authored-By: Claude Fable 5.1 --- .../accounts/code/pkg/adapters/rpc_policy_denied_test.go | 2 +- .../services/store/code/migration_65_scope_settings_test.go | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/module/services/accounts/code/pkg/adapters/rpc_policy_denied_test.go b/module/services/accounts/code/pkg/adapters/rpc_policy_denied_test.go index d1c781efd..63a9881a5 100644 --- a/module/services/accounts/code/pkg/adapters/rpc_policy_denied_test.go +++ b/module/services/accounts/code/pkg/adapters/rpc_policy_denied_test.go @@ -92,7 +92,7 @@ func TestUnauthenticatedCentralRefusalIsCounted(t *testing.T) { reader := deniedReader(t) refusal := membershipLookupStatus("verify central org scope", auth.ErrVerifiedDatabaseIdentityRequired) require.Equal(t, codes.Unauthenticated, status.Code(refusal)) - recordPolicyDenial(context.Background(), deniedMethod, denialReasonCentral, refusal) + require.Equal(t, refusal, recordPolicyDenial(context.Background(), deniedMethod, denialReasonCentral, refusal)) require.Equal(t, int64(1), deniedPoints(t, reader)[deniedMethod+" "+denialReasonCentral]) } diff --git a/module/services/store/code/migration_65_scope_settings_test.go b/module/services/store/code/migration_65_scope_settings_test.go index 7f904bb24..50675a363 100644 --- a/module/services/store/code/migration_65_scope_settings_test.go +++ b/module/services/store/code/migration_65_scope_settings_test.go @@ -90,7 +90,7 @@ func TestMigration65RenamesEveryScopeSettingAndNothingElse(t *testing.T) { if err != nil { t.Fatal(err) } - defer runner.Close() + defer func() { _, _ = runner.Close() }() if err := runner.Steps(-1); err != nil { t.Fatal(err) } @@ -161,7 +161,7 @@ SELECT line FROM ( if err != nil { t.Fatal(err) } - defer rows.Close() + defer func() { _ = rows.Close() }() var out []string for rows.Next() { var line string