Skip to content

Commit 8d4d191

Browse files
authored
Merge pull request #645 from codefirst/optimize-memory-usage
Optimize memory usage in LogsController#create by checking Script existence before reading log files
2 parents 2490bee + 1b4601d commit 8d4d191

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

app/controllers/logs_controller.rb

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,21 +14,18 @@ def create
1414
return
1515
end
1616

17-
@log = Log.new(host: params[:host], result: params[:log_file].read)
1817
script = Script.find_by(guid: params[:guid])
1918
unless script
2019
render json: {message: "scripts not found. GUID: #{params[:guid]}"}.to_json, status: 500
2120
return
2221
end
2322

24-
script.logs << @log
23+
@log = Log.new(host: params[:host], result: params[:log_file].read, script: script)
2524

26-
respond_to do |format|
27-
if @log.save
28-
format.html { render plain: "log registration successful\n", status: :created}
29-
else
30-
format.html { render plain: "log registration failure\n", status: 500 }
31-
end
25+
if @log.save
26+
render plain: "log registration successful\n", status: :created
27+
else
28+
render plain: "log registration failure\n", status: 500
3229
end
3330
end
3431

0 commit comments

Comments
 (0)