Fix response for AR Wrappers w/ bad ID

Author: jamesprior

lib/oai/provider/model/activerecord_wrapper.rb

@@ -61,7 +61,7 @@ def find(selector, options={})
           find_scope.where(conditions)
         end
       else
-        find_scope.where(conditions).find_by!(identifier_field => selector)
+        find_scope.where(conditions).where(identifier_field => selector).first
       end
     end
 

test/activerecord_provider/tc_ar_provider.rb

@@ -142,6 +142,21 @@ def test_handles_empty_collections
       REXML::Document.new(@provider.list_records(:metadata_prefix => 'oai_dc'))
     end
   end
+  
+  def test_bad_id_raises_exception
+    badIdentifiers = [
+      'invalid"id',
+      'oai:test/5000',
+      'oai:test/-1',
+      'oai:test/one',
+      'oai:test/\\$1\1!']
+    badIdentifiers.each do |id|
+      assert_raise(OAI::IdException) do
+        @provider.get_record(:identifier => id, :metadata_prefix => 'oai_dc')
+      end
+    end
+  end
+  
 
   def setup
     @provider = ARProvider.new