From 265eed476203062a67290e1520b007e5d08455f1 Mon Sep 17 00:00:00 2001
From: Furkan Bora Murat <64507603+FurkaanBoraa@users.noreply.github.com>
Date: Thu, 25 Jun 2026 18:27:49 +0300
Subject: [PATCH] fix(renderer): keep the key bindings hover row readable on
 dark themes (#4719)

Element Plus paints the hovered table row with --el-table-row-hover-bg-color,
which defaults to the light --el-fill-color-light. On dark themes that renders
as a near-white bar, hiding the now theme-coloured row text (from #3937).

Override the variable for the key bindings table to the theme's own
--selectionColor so the hovered row stays readable on every theme. This
replaces the previous tr.hover-row background rule, which did not override
Element Plus's variable-driven hover colour.
---
 .../renderer/src/prefComponents/keybindings/index.vue | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/packages/desktop/src/renderer/src/prefComponents/keybindings/index.vue b/packages/desktop/src/renderer/src/prefComponents/keybindings/index.vue
index 675db1ea3b..8db2deccf2 100644
--- a/packages/desktop/src/renderer/src/prefComponents/keybindings/index.vue
+++ b/packages/desktop/src/renderer/src/prefComponents/keybindings/index.vue
@@ -335,11 +335,12 @@ const dumpKeyboardInformation = (): void => {
 .pref-keybindings .el-table__fixed::before {
   background: var(--tableBorderColor);
 }
-.pref-keybindings .el-table__body tr.hover-row.current-row > td,
-.pref-keybindings .el-table__body tr.hover-row.el-table__row--striped.current-row > td,
-.pref-keybindings .el-table__body tr.hover-row.el-table__row--striped > td,
-.pref-keybindings .el-table__body tr.hover-row > td {
-  background: var(--selectionColor);
+/* Element Plus paints the hovered row via --el-table-row-hover-bg-color, which
+   defaults to the light --el-fill-color-light — a near-white bar that hides the
+   theme-coloured text on dark themes. Point it at the theme's own selection
+   colour so hovered rows stay readable on every theme (follow-up to #3937). */
+.pref-keybindings .el-table {
+  --el-table-row-hover-bg-color: var(--selectionColor);
 }
 .pref-keybindings .el-table .el-table__cell {
   padding: 2px 0;