Abandoned currencies are excluded from currency counts (#179)

Author: jeffyanta

ocp/data/currency/memory/store.go

@@ -328,7 +328,14 @@ func (s *store) CountMints(ctx context.Context) (uint64, error) {
 	s.mu.Lock()
 	defer s.mu.Unlock()
 
-	return uint64(len(s.metadataRecords)), nil
+	var count uint64
+	for _, item := range s.metadataRecords {
+		if item.State == currency.MetadataStateAbandoned {
+			continue
+		}
+		count++
+	}
+	return count, nil
 }
 
 func (s *store) IsNameAvailable(_ context.Context, name string) (bool, error) {

ocp/data/currency/postgres/model.go

@@ -532,7 +532,10 @@ func dbGetAllMints(ctx context.Context, db *sqlx.DB) ([]string, error) {
 
 func dbCountMints(ctx context.Context, db *sqlx.DB) (uint64, error) {
 	var count uint64
-	err := db.GetContext(ctx, &count, `SELECT COUNT(*) FROM `+metadataTableName)
+	err := db.GetContext(ctx, &count,
+		`SELECT COUNT(*) FROM `+metadataTableName+` WHERE state != $1`,
+		currency.MetadataStateAbandoned,
+	)
 	if err != nil {
 		return 0, err
 	}

ocp/data/currency/store.go

@@ -69,7 +69,8 @@ type Store interface {
 	// ErrNotFound is returned if no mints exist
 	GetAllMints(ctx context.Context) ([]string, error)
 
-	// CountMints returns the total number of currency creator mints
+	// CountMints returns the total number of currency creator mints,
+	// excluding those in the abandoned state.
 	CountMints(ctx context.Context) (uint64, error)
 
 	// IsNameAvailable checks whether a currency name is available for use.

ocp/data/currency/tests/tests.go

@@ -699,6 +699,14 @@ func testCountMints(t *testing.T, s currency.Store) {
 	count, err = s.CountMints(context.Background())
 	require.NoError(t, err)
 	assert.EqualValues(t, 2, count)
+
+	// Abandoned mints must not be counted
+	record2.State = currency.MetadataStateAbandoned
+	require.NoError(t, s.SaveMetadata(context.Background(), record2))
+
+	count, err = s.CountMints(context.Background())
+	require.NoError(t, err)
+	assert.EqualValues(t, 1, count)
 }
 
 func testCountMetadataByState(t *testing.T, s currency.Store) {