From 542c7d2ca576b793cb17ebef4be1341d9514540d Mon Sep 17 00:00:00 2001 From: Brandon McAnsh Date: Tue, 22 Sep 2026 13:34:51 -0400 Subject: [PATCH] fix(chat): ask for the group name instead of labelling the screen MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit EditGroupNameScreen headed its field "Set Name", which restates the row that opened it rather than asking for the value. NameEntryScreen is the same edit in the account flow and asks — "What's your name?" — and this screen already copies its layout, so it now copies the phrasing too. Drops the "Up to 64 characters" sublabel with it. The bound is still enforced in the view model before the EditChat call; it just no longer sits under the field. --- apps/flipcash/core/src/main/res/values/strings.xml | 7 +++---- .../internal/screens/profile/edit/EditGroupNameScreen.kt | 1 - 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/apps/flipcash/core/src/main/res/values/strings.xml b/apps/flipcash/core/src/main/res/values/strings.xml index 620954b09e..9cdc4b221d 100644 --- a/apps/flipcash/core/src/main/res/values/strings.xml +++ b/apps/flipcash/core/src/main/res/values/strings.xml @@ -1053,9 +1053,10 @@ + heads the field itself. The name screen also borrows that screen's phrasing — it heads a + focused field, so it asks for the value the way title_profileNameSelection does. --> Set Picture - Set Name + What\'s the group name? @@ -1065,8 +1066,6 @@ Change Group Picture? This will change the group picture for everyone in it Change Picture - - Up to 64 characters Can\'t Edit This Group You don\'t have permission to edit this group diff --git a/apps/flipcash/features/messenger/src/main/kotlin/com/flipcash/app/messenger/internal/screens/profile/edit/EditGroupNameScreen.kt b/apps/flipcash/features/messenger/src/main/kotlin/com/flipcash/app/messenger/internal/screens/profile/edit/EditGroupNameScreen.kt index 9e01b8b726..03be311429 100644 --- a/apps/flipcash/features/messenger/src/main/kotlin/com/flipcash/app/messenger/internal/screens/profile/edit/EditGroupNameScreen.kt +++ b/apps/flipcash/features/messenger/src/main/kotlin/com/flipcash/app/messenger/internal/screens/profile/edit/EditGroupNameScreen.kt @@ -122,7 +122,6 @@ internal fun EditGroupNameScreen(chatViewModel: ChatViewModel) { DisplayTextInput( state = state.titleFieldState, placeholder = stringResource(R.string.hint_groupName), - sublabel = stringResource(R.string.subtitle_groupNameLength), modifier = Modifier .fillMaxWidth() .focusRequester(focusRequester),