From 92a64d5fe7caf8af129a1ab316e58cdb7275ab23 Mon Sep 17 00:00:00 2001
From: Brandon McAnsh <git@bmcreations.dev>
Date: Mon, 31 Aug 2026 13:10:31 -0400
Subject: [PATCH] fix(profile): confirm the reversible profile changes in the
 grey banner
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

All four profile-change confirmations used showAlert, so a display name,
profile picture, or minimum tip edit got the red destructive banner and
"Are you sure you want to permanently change ...?" — the same treatment as
releasing a username, which is the only one of the four the user may not be
able to undo.

Those three move to showMessage (DEFAULT, bannerThemed grey) and state what
the change does instead of asking the user to be sure. Username keeps the red
banner and its extra sentence about losing the old handle.

Matches iOS, where DialogItem.confirmProfileChange already routes username to
.alert and the rest to .info on the same copy.
---
 apps/flipcash/core/src/main/res/values/strings.xml     | 10 ++++++----
 .../internal/mintip/MinimumTipEntryViewModel.kt        |  2 +-
 .../userprofile/internal/name/NameEntryViewModel.kt    |  2 +-
 .../internal/photo/PhotoSelectionViewModel.kt          |  2 +-
 4 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/apps/flipcash/core/src/main/res/values/strings.xml b/apps/flipcash/core/src/main/res/values/strings.xml
index 013f48346e..d90d40120c 100644
--- a/apps/flipcash/core/src/main/res/values/strings.xml
+++ b/apps/flipcash/core/src/main/res/values/strings.xml
@@ -967,18 +967,20 @@
     <!-- Confirmation before a profile edit is committed. Only shown on a change: a first display
          name, username, picture, or minimum tip overwrites nothing, so there is nothing to warn
          about. Username carries the extra sentence because the old handle is released on change
-         and someone else can claim it. -->
+         and someone else can claim it — the only one of the four the user may not be able to undo,
+         so the only one shown in the red banner. The rest state what the change does and confirm in
+         the grey one. -->
     <string name="prompt_title_changeDisplayName">Change Display Name?</string>
-    <string name="prompt_description_changeDisplayName">Are you sure you want to permanently change your display name?</string>
+    <string name="prompt_description_changeDisplayName">This will change your display name</string>
     <string name="action_changeDisplayName">Change Display Name</string>
     <string name="prompt_title_changeUsername">Change Username?</string>
     <string name="prompt_description_changeUsername">Are you sure you want to permanently change your username? You might not be able to get your old username back</string>
     <string name="action_changeUsername">Change Username</string>
     <string name="prompt_title_changeProfilePicture">Change Profile Picture?</string>
-    <string name="prompt_description_changeProfilePicture">Are you sure you want to permanently change your profile picture?</string>
+    <string name="prompt_description_changeProfilePicture">This will change your profile picture</string>
     <string name="action_changeProfilePicture">Change Profile Picture</string>
     <string name="prompt_title_changeMinimumTip">Change Minimum Tip?</string>
-    <string name="prompt_description_changeMinimumTip">Are you sure you want to permanently change your minimum tip?</string>
+    <string name="prompt_description_changeMinimumTip">This will change your minimum tip</string>
     <string name="action_changeMinimumTip">Change Minimum Tip</string>
 
     <!-- A tapped `flipcash.com/{username}` link that resolves to nothing. -->
diff --git a/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/mintip/MinimumTipEntryViewModel.kt b/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/mintip/MinimumTipEntryViewModel.kt
index e7008056f2..2248dc1589 100644
--- a/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/mintip/MinimumTipEntryViewModel.kt
+++ b/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/mintip/MinimumTipEntryViewModel.kt
@@ -173,7 +173,7 @@ internal class MinimumTipEntryViewModel @Inject constructor(
                     dispatchEvent(Event.CommitRequested(amount))
                     return@onEach
                 }
-                BottomBarManager.showAlert(
+                BottomBarManager.showMessage(
                     title = resources.getString(R.string.prompt_title_changeMinimumTip),
                     message = resources.getString(R.string.prompt_description_changeMinimumTip),
                     actions = listOf(
diff --git a/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/name/NameEntryViewModel.kt b/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/name/NameEntryViewModel.kt
index 828747a199..821fe07d18 100644
--- a/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/name/NameEntryViewModel.kt
+++ b/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/name/NameEntryViewModel.kt
@@ -110,7 +110,7 @@ class NameEntryViewModel @Inject constructor(
                     dispatchEvent(Event.CheckName(event.source))
                     return@onEach
                 }
-                BottomBarManager.showAlert(
+                BottomBarManager.showMessage(
                     title = resources.getString(R.string.prompt_title_changeDisplayName),
                     message = resources.getString(R.string.prompt_description_changeDisplayName),
                     actions = listOf(
diff --git a/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/photo/PhotoSelectionViewModel.kt b/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/photo/PhotoSelectionViewModel.kt
index 7730af93fd..63bd92d30d 100644
--- a/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/photo/PhotoSelectionViewModel.kt
+++ b/apps/flipcash/features/user-profile/src/main/kotlin/com/flipcash/app/userprofile/internal/photo/PhotoSelectionViewModel.kt
@@ -138,7 +138,7 @@ class PhotoSelectionViewModel @Inject constructor(
                     dispatchEvent(Event.CheckImage)
                     return@onEach
                 }
-                BottomBarManager.showAlert(
+                BottomBarManager.showMessage(
                     title = resources.getString(R.string.prompt_title_changeProfilePicture),
                     message = resources.getString(R.string.prompt_description_changeProfilePicture),
                     actions = listOf(