chore: audit use of showError vs showAlert; replace where makes sense

bmc08gt · bmc08gt · commit e7bb72710dc8 · 2026-04-13T12:00:47.000-04:00
Signed-off-by: Brandon McAnsh &lt;git@bmcreations.dev&gt;
diff --git a/apps/flipcash/features/backupkey/src/main/kotlin/com/flipcash/app/backupkey/internal/BackupKeyScreenContent.kt b/apps/flipcash/features/backupkey/src/main/kotlin/com/flipcash/app/backupkey/internal/BackupKeyScreenContent.kt
@@ -32,6 +32,7 @@ import androidx.compose.ui.draw.scale
 import androidx.compose.ui.graphics.asImageBitmap
 import androidx.compose.ui.layout.ContentScale
 import androidx.compose.ui.platform.LocalContext
+import androidx.compose.ui.platform.LocalResources
 import androidx.compose.ui.res.stringResource
 import androidx.compose.ui.text.style.TextAlign
 import androidx.compose.ui.unit.Dp
@@ -55,6 +56,7 @@ import com.getcode.util.permissions.rememberStoragePermission
 @Composable
 internal fun BackupKeyScreenContent(viewModel: BackupKeyScreenViewModel) {
     val context = LocalContext.current
+    val resources = LocalResources.current
     val dataState by viewModel.uiFlow.collectAsState()
 
     var isExportSeedRequested by remember { mutableStateOf(false) }
@@ -66,12 +68,12 @@ internal fun BackupKeyScreenContent(viewModel: BackupKeyScreenViewModel) {
 
         if (!isStoragePermissionGranted) {
             BottomBarManager.showError(
-                title = context.getString(R.string.error_title_failedToSave),
-                message = context.getString(R.string.error_description_failedToSave),
+                title = resources.getString(R.string.error_title_failedToSave),
+                message = resources.getString(R.string.error_description_failedToSave),
                 actions = listOf(
                     BottomBarAction.Ok,
                     BottomBarAction(
-                        text = context.getString(R.string.action_openSettings),
+                        text = resources.getString(R.string.action_openSettings),
                         style = BottomBarManager.BottomBarButtonStyle.Filled50,
                         onClick = { context.launchAppSettings() }
                     )
diff --git a/apps/flipcash/features/cash/src/main/kotlin/com/flipcash/app/cash/internal/CashScreenViewModel.kt b/apps/flipcash/features/cash/src/main/kotlin/com/flipcash/app/cash/internal/CashScreenViewModel.kt
@@ -168,7 +168,7 @@ internal class CashScreenViewModel @Inject constructor(
             currency.code?.let { stateFlow.value.limits?.sendLimitFor(it) } ?: SendLimit.Zero
         val isOverLimit = amount > sendLimit.nextTransaction
         if (isOverLimit) {
-            BottomBarManager.showError(
+            BottomBarManager.showAlert(
                 resources.getString(R.string.error_title_sendLimitReached),
                 resources.getString(R.string.error_description_sendLimitReached)
             )
diff --git a/apps/flipcash/features/contact-verification/src/main/kotlin/com/flipcash/app/contact/verification/internal/email/EmailVerificationViewModel.kt b/apps/flipcash/features/contact-verification/src/main/kotlin/com/flipcash/app/contact/verification/internal/email/EmailVerificationViewModel.kt
@@ -208,7 +208,7 @@ class EmailVerificationViewModel @Inject constructor(
         dispatchEvent(Event.OnSendingCodeChanged(loading = true))
         if (stateFlow.value.attempts >= 3) {
             dispatchEvent(Event.OnSendingCodeChanged())
-            BottomBarManager.showError(
+            BottomBarManager.showAlert(
                 title = resources.getString(R.string.error_title_maxAttemptsReached),
                 message = resources.getString(R.string.error_description_maxAttemptsReached),
             ) {
diff --git a/apps/flipcash/features/contact-verification/src/main/kotlin/com/flipcash/app/contact/verification/internal/phone/PhoneVerificationViewModel.kt b/apps/flipcash/features/contact-verification/src/main/kotlin/com/flipcash/app/contact/verification/internal/phone/PhoneVerificationViewModel.kt
@@ -202,7 +202,7 @@ internal class PhoneVerificationViewModel @Inject constructor(
         dispatchEvent(Event.OnSendingCodeChanged(loading = true))
         if (stateFlow.value.attempts >= 3) {
             dispatchEvent(Event.OnSendingCodeChanged())
-            BottomBarManager.showError(
+            BottomBarManager.showAlert(
                 title = resources.getString(R.string.error_title_maxAttemptsReached),
                 message = resources.getString(R.string.error_description_maxAttemptsReached),
             ) {
diff --git a/apps/flipcash/features/scanner/src/main/kotlin/com/flipcash/app/scanner/internal/bills/BillContainerView.kt b/apps/flipcash/features/scanner/src/main/kotlin/com/flipcash/app/scanner/internal/bills/BillContainerView.kt
@@ -32,6 +32,7 @@ import androidx.compose.ui.Alignment.Companion.BottomCenter
 import androidx.compose.ui.Modifier
 import androidx.compose.ui.graphics.Color
 import androidx.compose.ui.platform.LocalContext
+import androidx.compose.ui.platform.LocalResources
 import androidx.compose.ui.platform.testTag
 import androidx.compose.ui.unit.dp
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
@@ -71,15 +72,16 @@ internal fun BillContainer(
 ) {
     val session = LocalSessionController.current!!
     val context = LocalContext.current
+    val resources = LocalResources.current
     val onPermissionResult = { result: PermissionResult ->
         if (result == PermissionResult.PermanentlyDenied) {
-            BottomBarManager.showError(
-                title = context.getString(R.string.action_allowCameraAccess),
-                message = context.getString(R.string.error_description_cameraAccessRequired),
+            BottomBarManager.showAlert(
+                title = resources.getString(R.string.action_allowCameraAccess),
+                message = resources.getString(R.string.error_description_cameraAccessRequired),
                 actions = listOf(
                     BottomBarAction.Ok,
                     BottomBarAction(
-                        text = context.getString(R.string.action_openSettings),
+                        text = resources.getString(R.string.action_openSettings),
                         style = BottomBarManager.BottomBarButtonStyle.Filled50,
                         onClick = { context.launchAppSettings() }
 
diff --git a/apps/flipcash/features/withdrawal/src/main/kotlin/com/flipcash/app/withdrawal/WithdrawalViewModel.kt b/apps/flipcash/features/withdrawal/src/main/kotlin/com/flipcash/app/withdrawal/WithdrawalViewModel.kt
@@ -168,7 +168,7 @@ internal class WithdrawalViewModel @Inject constructor(
 
         val isOverBalance = enteredInUsdc > tokenBalance.rounded()
         if (isOverBalance || conversionRate == Rate.ignore) {
-            BottomBarManager.showError(
+            BottomBarManager.showAlert(
                 title = resources.getString(R.string.error_title_insufficientFunds),
                 message = resources.getString(R.string.error_description_insufficientFunds)
             )
diff --git a/apps/flipcash/shared/session/src/main/kotlin/com/flipcash/app/session/internal/RealSessionController.kt b/apps/flipcash/shared/session/src/main/kotlin/com/flipcash/app/session/internal/RealSessionController.kt
@@ -751,14 +751,14 @@ class RealSessionController @Inject constructor(
                     }
 
                     is ReceiveGiftTransactorError.AlreadyClaimed -> {
-                        BottomBarManager.showError(
+                        BottomBarManager.showAlert(
                             resources.getString(R.string.error_title_alreadyCollected),
                             resources.getString(R.string.error_description_alreadyCollected)
                         )
                     }
 
                     is ReceiveGiftTransactorError.Expired -> {
-                        BottomBarManager.showError(
+                        BottomBarManager.showAlert(
                             resources.getString(R.string.error_title_linkExpired),
                             resources.getString(R.string.error_description_linkExpired)
                         )

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ internal class CashScreenViewModel @Inject constructor(`
`168`	`168`	`currency.code?.let { stateFlow.value.limits?.sendLimitFor(it) } ?: SendLimit.Zero`
`169`	`169`	`val isOverLimit = amount > sendLimit.nextTransaction`
`170`	`170`	`if (isOverLimit) {`
`171`		`- BottomBarManager.showError(`
	`171`	`+ BottomBarManager.showAlert(`
`172`	`172`	`resources.getString(R.string.error_title_sendLimitReached),`
`173`	`173`	`resources.getString(R.string.error_description_sendLimitReached)`
`174`	`174`	`)`
Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ internal class WithdrawalViewModel @Inject constructor(`
`168`	`168`
`169`	`169`	`val isOverBalance = enteredInUsdc > tokenBalance.rounded()`
`170`	`170`	`if (isOverBalance \|\| conversionRate == Rate.ignore) {`
`171`		`- BottomBarManager.showError(`
	`171`	`+ BottomBarManager.showAlert(`
`172`	`172`	`title = resources.getString(R.string.error_title_insufficientFunds),`
`173`	`173`	`message = resources.getString(R.string.error_description_insufficientFunds)`
`174`	`174`	`)`
Original file line number	Diff line number	Diff line change
`@@ -751,14 +751,14 @@ class RealSessionController @Inject constructor(`
`751`	`751`	`}`
`752`	`752`
`753`	`753`	`is ReceiveGiftTransactorError.AlreadyClaimed -> {`
`754`		`- BottomBarManager.showError(`
	`754`	`+ BottomBarManager.showAlert(`
`755`	`755`	`resources.getString(R.string.error_title_alreadyCollected),`
`756`	`756`	`resources.getString(R.string.error_description_alreadyCollected)`
`757`	`757`	`)`
`758`	`758`	`}`
`759`	`759`
`760`	`760`	`is ReceiveGiftTransactorError.Expired -> {`
`761`		`- BottomBarManager.showError(`
	`761`	`+ BottomBarManager.showAlert(`
`762`	`762`	`resources.getString(R.string.error_title_linkExpired),`
`763`	`763`	`resources.getString(R.string.error_description_linkExpired)`
`764`	`764`	`)`