Skip to content

Commit e4e79fc

Browse files
bmc08gtbmc08gt
committed
chore: remove screen open analytics events
Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
1 parent c82bed3 commit e4e79fc

7 files changed

Lines changed: 1 addition & 169 deletions

File tree

‎api/src/main/java/com/getcode/analytics/AnalyticsManager.kt‎

Lines changed: 1 addition & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@ class AnalyticsManager @Inject constructor(
4040
Timber.i("App init time: " + (System.currentTimeMillis() - (timeAppInit ?: 0)))
4141
}
4242

43-
override fun open(screen: Screen) {
44-
track(Name.Open, Pair(Property.Screen, screen.value))
45-
}
46-
4743
override fun logout() {
4844
track(Name.Logout)
4945
}
@@ -279,9 +275,6 @@ class AnalyticsManager @Inject constructor(
279275
}
280276

281277
enum class Name(val value: String) {
282-
//Open
283-
Open("Open"),
284-
285278
//Account
286279
Logout("Logout"),
287280
Login("Login"),
@@ -312,7 +305,7 @@ class AnalyticsManager @Inject constructor(
312305
Recompute("Recompute"),
313306

314307
// App Settings
315-
AutoStartCamera("Auto Start Camera"),
308+
AutoStartCamera("Camera Auto Start"),
316309
RequireBiometrics("Require Biometrics")
317310
}
318311

@@ -352,25 +345,6 @@ class AnalyticsManager @Inject constructor(
352345
PercentDelta("Percent Delta"),
353346
}
354347

355-
enum class Screen(val value: String) {
356-
GetKin("Get Kin Screen"),
357-
GiveKin("Give Kin Screen"),
358-
RequestKin("Request Kin Screen"),
359-
Balance("Balance Screen"),
360-
Faq("FAQ Screen"),
361-
Settings("Settings Screen"),
362-
BuyAndSellKin("Buy and Sell Kin Screen"),
363-
Deposit("Deposit Screen"),
364-
Backup("Backup Screen"),
365-
Withdraw("Withdraw Screen"),
366-
Debug("Debug Screen"),
367-
Share("Share Screen"),
368-
AppSettings("App Settings"),
369-
ForceUpgrade("Force Upgrade"),
370-
BuyMoreKin("Buy More Kin Screen"),
371-
SendKin("Send Kin Screen"),
372-
}
373-
374348
enum class BillPresentationStyle(val value: String) {
375349
Pop("Pop"),
376350
Slide("Slide"),
@@ -385,5 +359,4 @@ class AnalyticsManager @Inject constructor(
385359
Hidden("Hidden"),
386360
TimedOut("Timed Out"),
387361
}
388-
389362
}

‎api/src/main/java/com/getcode/analytics/AnalyticsService.kt‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import com.getcode.solana.keys.PublicKey
99
interface AnalyticsService {
1010
fun onAppStart()
1111
fun onAppStarted()
12-
fun open(screen: AnalyticsManager.Screen)
1312
fun login(ownerPublicKey: String, autoCompleteCount: Int, inputChangeCount: Int)
1413
fun logout()
1514
fun createAccount(isSuccessful: Boolean, ownerPublicKey: String?)
@@ -55,7 +54,6 @@ interface AnalyticsService {
5554
class AnalyticsServiceNull : AnalyticsService {
5655
override fun onAppStart() = Unit
5756
override fun onAppStarted() = Unit
58-
override fun open(screen: AnalyticsManager.Screen) = Unit
5957
override fun login(ownerPublicKey: String, autoCompleteCount: Int, inputChangeCount: Int) = Unit
6058
override fun logout() = Unit
6159
override fun createAccount(isSuccessful: Boolean, ownerPublicKey: String?) = Unit

‎app/src/main/java/com/getcode/analytics/AnalyticsScreenWatcher.kt‎

Lines changed: 0 additions & 21 deletions
This file was deleted.

‎app/src/main/java/com/getcode/navigation/screens/ChatScreens.kt‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,8 @@ import coil3.request.ImageRequest
3434
import coil3.request.error
3535
import com.getcode.R
3636
import com.getcode.analytics.AnalyticsManager
37-
import com.getcode.analytics.AnalyticsScreenWatcher
3837
import com.getcode.model.ID
3938
import com.getcode.navigation.core.LocalCodeNavigator
40-
import com.getcode.theme.BrandLight
4139
import com.getcode.theme.CodeTheme
4240
import com.getcode.ui.components.SheetTitleDefaults
4341
import com.getcode.ui.components.SheetTitleText
@@ -126,11 +124,6 @@ data object BalanceModal : ChatGraph, ModalRoot {
126124
BalanceScreen(state = state, dispatch = viewModel::dispatchEvent)
127125
}
128126

129-
AnalyticsScreenWatcher(
130-
lifecycleOwner = LocalLifecycleOwner.current,
131-
event = AnalyticsManager.Screen.Balance
132-
)
133-
134127
LifecycleEffect(
135128
onDisposed = {
136129
val disposedScreen = navigator.lastItem

‎app/src/main/java/com/getcode/navigation/screens/MainScreens.kt‎

Lines changed: 0 additions & 62 deletions
Original file line numberDiff line numberDiff line change
@@ -1,60 +1,18 @@
11
package com.getcode.navigation.screens
22

3-
import androidx.compose.foundation.Image
4-
import androidx.compose.foundation.layout.Arrangement
5-
import androidx.compose.foundation.layout.Box
6-
import androidx.compose.foundation.layout.Column
7-
import androidx.compose.foundation.layout.Spacer
8-
import androidx.compose.foundation.layout.WindowInsets
9-
import androidx.compose.foundation.layout.fillMaxSize
10-
import androidx.compose.foundation.layout.fillMaxWidth
11-
import androidx.compose.foundation.layout.navigationBars
12-
import androidx.compose.foundation.layout.padding
13-
import androidx.compose.foundation.layout.windowInsetsPadding
14-
import androidx.compose.material.Text
153
import androidx.compose.runtime.Composable
16-
import androidx.compose.runtime.getValue
17-
import androidx.compose.runtime.mutableStateOf
18-
import androidx.compose.runtime.remember
19-
import androidx.compose.runtime.setValue
20-
import androidx.compose.ui.Alignment
21-
import androidx.compose.ui.Modifier
22-
import androidx.compose.ui.draw.alpha
23-
import androidx.compose.ui.geometry.Rect
24-
import androidx.compose.ui.layout.boundsInParent
25-
import androidx.compose.ui.layout.boundsInWindow
26-
import androidx.compose.ui.layout.onPlaced
27-
import androidx.compose.ui.platform.LocalContext
284
import androidx.compose.ui.platform.LocalLifecycleOwner
29-
import androidx.compose.ui.platform.LocalTextToolbar
30-
import androidx.compose.ui.platform.TextToolbar
31-
import androidx.compose.ui.res.painterResource
325
import androidx.compose.ui.res.stringResource
33-
import androidx.compose.ui.text.style.TextAlign
346
import androidx.lifecycle.Lifecycle
357
import cafe.adriel.voyager.core.screen.ScreenKey
368
import cafe.adriel.voyager.core.screen.uniqueScreenKey
379
import cafe.adriel.voyager.hilt.getViewModel
38-
import com.getcode.LocalDownloadQrCode
3910
import com.getcode.R
4011
import com.getcode.analytics.AnalyticsManager
41-
import com.getcode.analytics.AnalyticsScreenWatcher
4212
import com.getcode.model.KinAmount
4313
import com.getcode.navigation.core.LocalCodeNavigator
44-
import com.getcode.theme.CodeTheme
45-
import com.getcode.ui.components.ButtonState
46-
import com.getcode.ui.components.Cloudy
47-
import com.getcode.ui.components.CodeButton
48-
import com.getcode.ui.components.CodeCircularProgressIndicator
49-
import com.getcode.ui.components.Row
50-
import com.getcode.ui.components.SelectionContainer
51-
import com.getcode.ui.components.rememberSelectionState
5214
import com.getcode.ui.utils.RepeatOnLifecycle
5315
import com.getcode.ui.utils.getActivityScopedViewModel
54-
import com.getcode.ui.utils.rememberedLongClickable
55-
import com.getcode.ui.utils.swallowClicks
56-
import com.getcode.util.shareDownloadLink
57-
import com.getcode.util.vibration.LocalVibrator
5816
import com.getcode.utils.trace
5917
import com.getcode.view.download.ShareDownloadScreen
6018
import com.getcode.view.main.account.AccountHome
@@ -138,11 +96,6 @@ data object GiveKinModal : AppScreen(), MainGraph, ModalRoot {
13896
) {
13997
GiveKinScreen(getViewModel())
14098
}
141-
142-
AnalyticsScreenWatcher(
143-
lifecycleOwner = LocalLifecycleOwner.current,
144-
event = AnalyticsManager.Screen.GiveKin
145-
)
14699
}
147100
}
148101

@@ -190,11 +143,6 @@ data class RequestKinModal(
190143
content()
191144
}
192145
}
193-
194-
AnalyticsScreenWatcher(
195-
lifecycleOwner = LocalLifecycleOwner.current,
196-
event = AnalyticsManager.Screen.RequestKin
197-
)
198146
}
199147
}
200148

@@ -220,11 +168,6 @@ data object AccountModal : MainGraph, ModalRoot {
220168
) {
221169
AccountHome(viewModel)
222170
}
223-
224-
AnalyticsScreenWatcher(
225-
lifecycleOwner = LocalLifecycleOwner.current,
226-
event = AnalyticsManager.Screen.Settings
227-
)
228171
}
229172
}
230173

@@ -240,11 +183,6 @@ data object ShareDownloadLinkModal : MainGraph, ModalRoot {
240183
) {
241184
ShareDownloadScreen()
242185
}
243-
244-
AnalyticsScreenWatcher(
245-
lifecycleOwner = LocalLifecycleOwner.current,
246-
event = AnalyticsManager.Screen.Share
247-
)
248186
}
249187
}
250188

‎app/src/main/java/com/getcode/navigation/screens/ModalScreens.kt‎

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ import cafe.adriel.voyager.core.screen.uniqueScreenKey
99
import cafe.adriel.voyager.hilt.getViewModel
1010
import com.getcode.R
1111
import com.getcode.analytics.AnalyticsManager
12-
import com.getcode.analytics.AnalyticsScreenWatcher
1312
import com.getcode.navigation.core.LocalCodeNavigator
1413
import com.getcode.ui.utils.getActivityScopedViewModel
1514
import com.getcode.ui.utils.getStackScopedViewModel
@@ -52,11 +51,6 @@ data object DepositKinScreen : MainGraph, ModalContent {
5251
ModalContainer(backButtonEnabled = { it is DepositKinScreen }) {
5352
AccountDeposit()
5453
}
55-
56-
AnalyticsScreenWatcher(
57-
lifecycleOwner = LocalLifecycleOwner.current,
58-
event = AnalyticsManager.Screen.Deposit
59-
)
6054
}
6155
}
6256

@@ -73,11 +67,6 @@ data object FaqScreen : MainGraph, ModalContent {
7367
ModalContainer(backButtonEnabled = { it is FaqScreen }) {
7468
AccountFaq(getViewModel())
7569
}
76-
77-
AnalyticsScreenWatcher(
78-
lifecycleOwner = LocalLifecycleOwner.current,
79-
event = AnalyticsManager.Screen.Faq
80-
)
8170
}
8271
}
8372

@@ -94,11 +83,6 @@ data object AccountDebugOptionsScreen : MainGraph, ModalContent {
9483
ModalContainer(backButtonEnabled = { it is AccountDebugOptionsScreen }) {
9584
BetaFlagsScreen(getViewModel())
9685
}
97-
98-
AnalyticsScreenWatcher(
99-
lifecycleOwner = LocalLifecycleOwner.current,
100-
event = AnalyticsManager.Screen.Debug
101-
)
10286
}
10387
}
10488

@@ -115,11 +99,6 @@ data object AppSettingsScreen : MainGraph, ModalContent {
11599
ModalContainer(backButtonEnabled = { it is AppSettingsScreen }) {
116100
AppSettingsScreen(getViewModel())
117101
}
118-
119-
AnalyticsScreenWatcher(
120-
lifecycleOwner = LocalLifecycleOwner.current,
121-
event = AnalyticsManager.Screen.AppSettings
122-
)
123102
}
124103
}
125104

@@ -152,12 +131,6 @@ data object BackupScreen : MainGraph, ModalContent {
152131
ModalContainer(backButtonEnabled = { it is BackupScreen }) {
153132
BackupKey(getViewModel())
154133
}
155-
156-
157-
AnalyticsScreenWatcher(
158-
lifecycleOwner = LocalLifecycleOwner.current,
159-
event = AnalyticsManager.Screen.Backup
160-
)
161134
}
162135
}
163136

@@ -384,11 +357,6 @@ data class BuyMoreKinModal(
384357
content()
385358
}
386359
}
387-
388-
AnalyticsScreenWatcher(
389-
lifecycleOwner = LocalLifecycleOwner.current,
390-
event = AnalyticsManager.Screen.BuyMoreKin
391-
)
392360
}
393361
}
394362

@@ -483,11 +451,6 @@ data object GetKinModal : MainGraph, ModalRoot {
483451
) {
484452
GetKinSheet(viewModel)
485453
}
486-
487-
AnalyticsScreenWatcher(
488-
lifecycleOwner = LocalLifecycleOwner.current,
489-
event = AnalyticsManager.Screen.GetKin
490-
)
491454
}
492455
}
493456

@@ -501,10 +464,5 @@ data object BuySellScreen : MainGraph, ModalContent {
501464
ModalContainer(backButtonEnabled = { it is BuySellScreen }) {
502465
BuyAndSellKin(getViewModel())
503466
}
504-
505-
AnalyticsScreenWatcher(
506-
lifecycleOwner = LocalLifecycleOwner.current,
507-
event = AnalyticsManager.Screen.BuyAndSellKin
508-
)
509467
}
510468
}

‎app/src/main/java/com/getcode/navigation/screens/WithdrawalScreens.kt‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ import cafe.adriel.voyager.core.screen.ScreenKey
77
import cafe.adriel.voyager.core.screen.uniqueScreenKey
88
import cafe.adriel.voyager.hilt.getViewModel
99
import com.getcode.R
10-
import com.getcode.analytics.AnalyticsScreenWatcher
1110
import com.getcode.analytics.AnalyticsManager
1211
import com.getcode.view.main.account.withdraw.AccountWithdrawAddress
1312
import com.getcode.view.main.account.withdraw.AccountWithdrawAmount
@@ -32,12 +31,6 @@ internal data object WithdrawalAmountScreen : WithdrawalGraph, ModalContent {
3231
ModalContainer(backButtonEnabled = { it is WithdrawalAmountScreen }) {
3332
AccountWithdrawAmount(viewModel = getViewModel())
3433
}
35-
36-
AnalyticsScreenWatcher(
37-
lifecycleOwner = LocalLifecycleOwner.current,
38-
event = AnalyticsManager.Screen.Withdraw
39-
)
40-
4134
}
4235
}
4336

0 commit comments

Comments
 (0)