Skip to content

Commit d4a63f2

Browse files
committed
chore: enable share tweet by default
Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
1 parent 43f73c3 commit d4a63f2

3 files changed

Lines changed: 33 additions & 5 deletions

File tree

api/src/main/java/com/getcode/model/PrefBool.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,16 @@ data class PrefBool(
1111
val value: Boolean
1212
)
1313

14+
// Used internally to control logic and UI
1415
sealed interface InternalRouting
16+
// User setting exposed in Settings -> App Settings
1517
sealed interface AppSetting
18+
// Beta flag exposed in Settings -> Beta Flags to enable bleeding edge features
1619
sealed interface BetaFlag
20+
// Dev settings
1721
sealed interface DevSetting
22+
// Once a feature behind a beta flag is made public, it becomes immutable
23+
// This removes it from the UI in Settings -> Beta Flags
1824
sealed interface Immutable
1925

2026

@@ -52,7 +58,7 @@ sealed class PrefsBool(val value: String) {
5258
data object CONVERSATION_CASH_ENABLED: PrefsBool("convo_cash_enabled"), BetaFlag
5359
data object BALANCE_CURRENCY_SELECTION_ENABLED: PrefsBool("balance_currency_enabled"), BetaFlag, Immutable
5460
data object KADO_WEBVIEW_ENABLED : PrefsBool("kado_inapp_enabled"), BetaFlag
55-
data object SHARE_TWEET_TO_TIP : PrefsBool("share_tweet_to_tip"), BetaFlag
61+
data object SHARE_TWEET_TO_TIP : PrefsBool("share_tweet_to_tip"), BetaFlag, Immutable
5662
data object TIP_CARD_ON_HOMESCREEN: PrefsBool("tip_card_on_home_screen"), BetaFlag, Immutable
5763
}
5864

api/src/main/java/com/getcode/network/repository/BetaFlagsRepository.kt

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ data class BetaOptions(
3838
conversationCashEnabled = false,
3939
balanceCurrencySelectionEnabled = true,
4040
kadoWebViewEnabled = false,
41-
shareTweetToTip = false,
41+
shareTweetToTip = true,
4242
tipCardOnHomeScreen = true,
4343
)
4444
}
@@ -108,6 +108,29 @@ class BetaFlagsRepository @Inject constructor(
108108
}
109109

110110
suspend fun isEnabled(flag: PrefsBool): Boolean {
111-
return prefRepository.get(flag, false)
111+
return prefRepository.get(flag, default(flag))
112+
}
113+
114+
private fun default(flag: PrefsBool): Boolean {
115+
return with(BetaOptions.Defaults) {
116+
when (flag) {
117+
PrefsBool.BALANCE_CURRENCY_SELECTION_ENABLED -> balanceCurrencySelectionEnabled
118+
PrefsBool.BUCKET_DEBUGGER_ENABLED -> canViewBuckets
119+
PrefsBool.BUY_MODULE_ENABLED -> buyModuleEnabled
120+
PrefsBool.CHAT_UNSUB_ENABLED -> chatUnsubEnabled
121+
PrefsBool.CONVERSATIONS_ENABLED -> conversationsEnabled
122+
PrefsBool.CONVERSATION_CASH_ENABLED -> conversationCashEnabled
123+
PrefsBool.DISPLAY_ERRORS -> displayErrors
124+
PrefsBool.GIVE_REQUESTS_ENABLED -> giveRequestsEnabled
125+
PrefsBool.KADO_WEBVIEW_ENABLED -> kadoWebViewEnabled
126+
PrefsBool.LOG_SCAN_TIMES -> debugScanTimesEnabled
127+
PrefsBool.SHARE_TWEET_TO_TIP -> shareTweetToTip
128+
PrefsBool.SHOW_CONNECTIVITY_STATUS -> showNetworkDropOff
129+
PrefsBool.TIPS_ENABLED -> tipsEnabled
130+
PrefsBool.TIP_CARD_ON_HOMESCREEN -> tipCardOnHomeScreen
131+
PrefsBool.VIBRATE_ON_SCAN -> tickOnScan
132+
else -> false
133+
}
134+
}
112135
}
113136
}

app/src/main/AndroidManifest.xml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,14 +149,13 @@
149149
android:pathPattern="/x/.*"
150150
android:scheme="https" />
151151
</intent-filter>
152-
153152
</activity>
154153

155154
<activity-alias
156155
android:name="com.getcode.view.TweetShareHandler"
157156
android:exported="true"
158157
android:targetActivity="com.getcode.view.MainActivity"
159-
android:enabled="false">
158+
android:enabled="true">
160159
<intent-filter>
161160
<action android:name="android.intent.action.SEND"/>
162161
<category android:name="android.intent.category.DEFAULT"/>

0 commit comments

Comments
 (0)