refactor(auth): extract PushTokenProvider into shared/push module

Decouple AuthManager from FirebaseMessaging by introducing a
PushTokenProvider interface in a new shared/push module, with the
Firebase implementation living in shared/notifications. This
eliminates static mocking of FirebaseMessaging in AuthManagerTest.

Author: bmc08gt

apps/flipcash/shared/authentication/build.gradle.kts

@@ -7,16 +7,13 @@ android {
 }
 
 dependencies {
-    implementation(platform(libs.firebase.bom))
-    implementation(libs.firebase.messaging)
-    implementation(libs.bugsnag)
-
     implementation(libs.androidx.credentials)
     implementation(libs.androidx.credentials.play.auth)
     implementation(libs.androidx.datastore)
 
     implementation(project(":apps:flipcash:shared:appsettings"))
     implementation(project(":apps:flipcash:shared:persistence:provider"))
+    implementation(project(":apps:flipcash:shared:push"))
     implementation(project(":apps:flipcash:shared:featureflags"))
     implementation(project(":apps:flipcash:shared:tokens"))
     implementation(project(":apps:flipcash:shared:userflags"))

apps/flipcash/shared/authentication/src/main/kotlin/com/flipcash/app/auth/AuthManager.kt

@@ -1,13 +1,12 @@
 package com.flipcash.app.auth
 
 import androidx.core.app.NotificationManagerCompat
-import com.bugsnag.android.Bugsnag
 import com.flipcash.app.appsettings.AppSettingsCoordinator
 import com.flipcash.app.auth.internal.credentials.LookupResult
 import com.flipcash.app.auth.internal.credentials.PassphraseCredentialManager
-import com.flipcash.app.auth.internal.extensions.token
 import com.flipcash.app.featureflags.FeatureFlagController
 import com.flipcash.app.persistence.PersistenceProvider
+import com.flipcash.app.push.PushTokenProvider
 import com.flipcash.app.tokens.TokenCoordinator
 import com.flipcash.app.userflags.UserFlagsCoordinator
 import com.flipcash.services.controllers.AccountController
@@ -18,11 +17,9 @@ import com.flipcash.shared.authentication.BuildConfig
 import com.getcode.crypt.MnemonicPhrase
 import com.getcode.opencode.controllers.TokenController
 import com.getcode.opencode.model.core.ID
+import com.getcode.utils.TraceManager
 import com.getcode.utils.TraceType
 import com.getcode.utils.trace
-import com.google.firebase.Firebase
-import com.google.firebase.messaging.FirebaseMessaging
-import com.google.firebase.messaging.messaging
 import kotlinx.coroutines.CoroutineScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.coroutineScope
@@ -37,6 +34,7 @@ class AuthManager @Inject constructor(
     private val notificationManager: NotificationManagerCompat,
     private val accountController: AccountController,
     private val pushController: PushController,
+    private val pushTokenProvider: PushTokenProvider,
     private val tokenCoordinator: TokenCoordinator,
     private val persistence: PersistenceProvider,
     private val featureFlagController: FeatureFlagController,
@@ -212,7 +210,7 @@ class AuthManager @Inject constructor(
     private suspend fun resetStateForUser() {
         // Fire-and-forget slow network operations to avoid blocking navigation
         launch {
-            FirebaseMessaging.getInstance().deleteToken()
+            pushTokenProvider.deleteToken()
             pushController.deleteTokens()
         }
         notificationManager.cancelAll()
@@ -223,15 +221,15 @@ class AuthManager @Inject constructor(
         appSettings.reset()
         userFlags.clearAll()
 
-        if (!BuildConfig.DEBUG) Bugsnag.setUser(null, null, null)
+        if (!BuildConfig.DEBUG) TraceManager.userId = null
     }
 
     private suspend fun savePrefs() {
         updateFcmToken()
     }
 
     private suspend fun updateFcmToken() {
-        val pushToken = Firebase.messaging.token() ?: return
+        val pushToken = pushTokenProvider.getToken() ?: return
         pushController.addToken(pushToken)
             .onSuccess {
                 userManager.set(pushToken = pushToken)

apps/flipcash/shared/authentication/src/main/kotlin/com/flipcash/app/auth/internal/extensions/FirebaseMessaging.kt

@@ -1,22 +1,18 @@
 package com.flipcash.app.auth
 
-import android.app.Activity
 import androidx.core.app.NotificationManagerCompat
 import com.flipcash.app.appsettings.AppSettingsCoordinator
 import com.flipcash.app.auth.internal.credentials.AccountMetadata
 import com.flipcash.app.auth.internal.credentials.PassphraseCredentialManager
 import com.flipcash.app.featureflags.FeatureFlagController
 import com.flipcash.app.persistence.PersistenceProvider
+import com.flipcash.app.push.PushTokenProvider
 import com.flipcash.app.tokens.TokenCoordinator
 import com.flipcash.app.userflags.UserFlagsCoordinator
 import com.flipcash.services.controllers.AccountController
 import com.flipcash.services.controllers.PushController
 import com.flipcash.services.models.UserFlags
 import com.flipcash.services.user.UserManager
-import com.bugsnag.android.Bugsnag
-import com.google.android.gms.tasks.OnSuccessListener
-import com.google.android.gms.tasks.Task
-import com.google.firebase.messaging.FirebaseMessaging
 import io.mockk.coEvery
 import io.mockk.coVerify
 import io.mockk.every
@@ -51,6 +47,7 @@ class AuthManagerTest {
     private val notificationManager: NotificationManagerCompat = mockk(relaxed = true)
     private val accountController: AccountController = mockk(relaxed = true)
     private val pushController: PushController = mockk(relaxed = true)
+    private val pushTokenProvider: PushTokenProvider = mockk(relaxed = true)
     private val tokenCoordinator: TokenCoordinator = mockk(relaxed = true)
     private val persistence: PersistenceProvider = mockk(relaxed = true)
     private val featureFlagController: FeatureFlagController = mockk(relaxed = true)
@@ -65,30 +62,7 @@ class AuthManagerTest {
         mockkStatic("com.getcode.utils.LoggingKt")
         every { com.getcode.utils.trace(any(), any(), any(), any(), any()) } returns Unit
 
-        mockkStatic(Bugsnag::class)
-        every { Bugsnag.setUser(any(), any(), any()) } returns Unit
-
-        mockkStatic(FirebaseMessaging::class)
-        val mockMessaging: FirebaseMessaging = mockk(relaxed = true)
-        every { FirebaseMessaging.getInstance() } returns mockMessaging
-
-        // Make FirebaseMessaging.token Task invoke success listener immediately
-        // so the token() suspendCancellableCoroutine resolves
-        val mockTask = mockk<Task<String>>(relaxed = true)
-        every { mockMessaging.token } returns mockTask
-        every { mockTask.addOnCanceledListener(any()) } returns mockTask
-        every { mockTask.addOnFailureListener(any()) } returns mockTask
-        every { mockTask.addOnSuccessListener(any()) } answers {
-            val listener = firstArg<OnSuccessListener<String>>()
-            listener.onSuccess("fake-token")
-            mockTask
-        }
-        // Also handle the Activity variant
-        every { mockTask.addOnSuccessListener(any<Activity>(), any()) } answers {
-            val listener = secondArg<OnSuccessListener<String>>()
-            listener.onSuccess("fake-token")
-            mockTask
-        }
+        coEvery { pushTokenProvider.getToken() } returns "fake-token"
 
         // Default stubs for methods called during login/createAccount success paths
         coEvery { accountController.getUserFlags() } returns Result.success(UserFlags.Default)
@@ -102,6 +76,7 @@ class AuthManagerTest {
             notificationManager = notificationManager,
             accountController = accountController,
             pushController = pushController,
+            pushTokenProvider = pushTokenProvider,
             tokenCoordinator = tokenCoordinator,
             persistence = persistence,
             featureFlagController = featureFlagController,
@@ -114,8 +89,6 @@ class AuthManagerTest {
     fun tearDown() {
         Dispatchers.resetMain()
         unmockkStatic("com.getcode.utils.LoggingKt")
-        unmockkStatic(FirebaseMessaging::class)
-        unmockkStatic(Bugsnag::class)
     }
 
     @Test

apps/flipcash/shared/authentication/src/test/kotlin/com/flipcash/app/auth/AuthManagerTest.kt

@@ -8,6 +8,7 @@ android {
 
 dependencies {
     implementation(project(":apps:flipcash:shared:authentication"))
+    implementation(project(":apps:flipcash:shared:push"))
     implementation(project(":apps:flipcash:shared:tokens"))
     implementation(project(":services:flipcash"))
 

apps/flipcash/shared/notifications/build.gradle.kts

@@ -0,0 +1,26 @@
+package com.flipcash.app.notifications
+
+import com.flipcash.app.push.PushTokenProvider
+import com.getcode.utils.ErrorUtils
+import com.google.firebase.messaging.FirebaseMessaging
+import kotlinx.coroutines.suspendCancellableCoroutine
+import javax.inject.Inject
+import javax.inject.Singleton
+import kotlin.coroutines.resume
+
+@Singleton
+class FirebasePushTokenProvider @Inject constructor() : PushTokenProvider {
+    override suspend fun getToken(): String? = suspendCancellableCoroutine { cont ->
+        FirebaseMessaging.getInstance().token
+            .addOnCanceledListener { cont.resume(null) }
+            .addOnFailureListener {
+                ErrorUtils.handleError(it)
+                cont.resume(null)
+            }
+            .addOnSuccessListener { cont.resume(it) }
+    }
+
+    override suspend fun deleteToken() {
+        FirebaseMessaging.getInstance().deleteToken()
+    }
+}

apps/flipcash/shared/notifications/src/main/kotlin/com/flipcash/app/notifications/FirebasePushTokenProvider.kt

@@ -0,0 +1,15 @@
+package com.flipcash.app.notifications.inject
+
+import com.flipcash.app.notifications.FirebasePushTokenProvider
+import com.flipcash.app.push.PushTokenProvider
+import dagger.Binds
+import dagger.Module
+import dagger.hilt.InstallIn
+import dagger.hilt.components.SingletonComponent
+
+@Module
+@InstallIn(SingletonComponent::class)
+abstract class PushModule {
+    @Binds
+    abstract fun bindPushTokenProvider(impl: FirebasePushTokenProvider): PushTokenProvider
+}

apps/flipcash/shared/notifications/src/main/kotlin/com/flipcash/app/notifications/inject/PushModule.kt

@@ -0,0 +1,2 @@
+build/
+.gradle/

apps/flipcash/shared/push/.gitignore

@@ -0,0 +1,11 @@
+plugins {
+    alias(libs.plugins.flipcash.android.library)
+}
+
+android {
+    namespace = "${Gradle.flipcashNamespace}.shared.push"
+}
+
+dependencies {
+    implementation(libs.javax.inject)
+}

apps/flipcash/shared/push/build.gradle.kts

@@ -0,0 +1,6 @@
+package com.flipcash.app.push
+
+interface PushTokenProvider {
+    suspend fun getToken(): String?
+    suspend fun deleteToken()
+}