fix(nav3): dismiss sheet animation when navigator.hide() is called

bmc08gt · bmc08gt · commit bc92bb0f15b9 · 2026-03-18T19:17:32.000-04:00
hide() was calling popAll() which cleared the inner backstack without
triggering the sheet dismiss animation. Changed to call onRootReached()
which fires the sheetDismissDispatcher chain to properly animate out.

Signed-off-by: Brandon McAnsh &lt;git@bmcreations.dev&gt;
diff --git a/ui/navigation/src/main/kotlin/com/getcode/navigation/core/CodeNavigator.kt b/ui/navigation/src/main/kotlin/com/getcode/navigation/core/CodeNavigator.kt
@@ -207,7 +207,7 @@ data class CodeNavigator(
     }
 
     /** Hide/dismiss a sheet (pops the current route). */
-    fun hide() = popAll()
+    fun hide() = onRootReached()
 
     /** Replace the current route with a new one. */
     fun replace(route: NavKey) = navigate(route, NavOptions(popUpTo = NavOptions.PopUpTo.PopLast))

Original file line number	Diff line number	Diff line change
`@@ -207,7 +207,7 @@ data class CodeNavigator(`
`207`	`207`	`}`
`208`	`208`
`209`	`209`	`/** Hide/dismiss a sheet (pops the current route). */`
`210`		`- fun hide() = popAll()`
	`210`	`+ fun hide() = onRootReached()`
`211`	`211`
`212`	`212`	`/** Replace the current route with a new one. */`
`213`	`213`	`fun replace(route: NavKey) = navigate(route, NavOptions(popUpTo = NavOptions.PopUpTo.PopLast))`