Skip to content

Commit bbe3baf

Browse files
committed
fix(ui): ensure we compare double's with proper consideration for floating point values
Signed-off-by: Brandon McAnsh <git@bmcreations.dev>
1 parent e586c9b commit bbe3baf

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

  • ui/components/src/main/kotlin/com/getcode/ui/components/charts

ui/components/src/main/kotlin/com/getcode/ui/components/charts/Trends.kt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,15 @@ sealed interface TrendType {
6363
data object FirstVsLast: TrendType {
6464
override fun determineTrend(data: List<Double>): LineTrend {
6565
if (data.size < 2) return LineTrend.Up
66-
return if (data.first() <= data.last()) LineTrend.Up else LineTrend.Down
66+
val first = data.first()
67+
val last = data.last()
68+
return if (first.lessThanOrEqualTo(last)) LineTrend.Up else LineTrend.Down
6769
}
6870
}
6971

7072
fun determineTrend(data: List<Double>): LineTrend
73+
}
74+
75+
private fun Double.lessThanOrEqualTo(other: Double, epsilon: Double = 1e-6): Boolean {
76+
return this <= other + epsilon
7177
}

0 commit comments

Comments
 (0)