Merge pull request #188 from code-payments/chore/bugsnag-notify-in-more-scenarios

chore: notify bugsnag of any errors in more scenarios

Author: bmc08gt

api/build.gradle.kts

@@ -1,3 +1,4 @@
+import org.jetbrains.kotlin.cli.common.toBooleanLenient
 import java.util.Properties
 
 plugins {
@@ -8,21 +9,32 @@ plugins {
 }
 
 android {
-    namespace = "com.getcode.api"
+    namespace = "${Android.namespace}.api"
     compileSdk = Android.compileSdkVersion
     defaultConfig {
         minSdk = Android.minSdkVersion
         targetSdk = Android.targetSdkVersion
         buildToolsVersion = Android.buildToolsVersion
         testInstrumentationRunner = Android.testInstrumentationRunner
 
+        buildConfigField("Boolean", "NOTIFY_ERRORS", "false")
+
         javaCompileOptions {
             annotationProcessorOptions {
                 arguments += mapOf("room.schemaLocation" to "$projectDir/schemas")
             }
         }
     }
 
+    buildTypes {
+        getByName("release") {
+            buildConfigField("Boolean", "NOTIFY_ERRORS", "true")
+        }
+        getByName("debug") {
+            buildConfigField("Boolean", "NOTIFY_ERRORS", (System.getenv("NOTIFY_ERRORS").toBooleanLenient() ?: false).toString())
+        }
+    }
+
     java {
         toolchain {
             languageVersion.set(JavaLanguageVersion.of(17))

api/src/main/java/com/getcode/network/repository/MessagingRepository.kt

@@ -285,6 +285,7 @@ class MessagingRepository @Inject constructor(
                 }: result: ${it.result}"
             )
         }.onFailure {
+            ErrorUtils.handleError(it)
             Timber.e(t = it, message = "Failed to send rendezvous message.")
         }
     }

api/src/main/java/com/getcode/network/repository/PaymentRepository.kt

@@ -14,6 +14,7 @@ import com.getcode.network.client.establishRelationship
 import com.getcode.network.client.fetchLimits
 import com.getcode.network.client.transferWithResult
 import com.getcode.network.exchange.Exchange
+import com.getcode.utils.ErrorUtils
 import dagger.hilt.android.qualifiers.ApplicationContext
 import io.reactivex.rxjava3.core.Completable
 import kotlinx.coroutines.CoroutineScope
@@ -48,7 +49,7 @@ class PaymentRepository @Inject constructor(
 
             codeScanned(payload.rendezvous)
             return payload to loginAttempt
-        }.getOrNull()
+        }.onFailure { ErrorUtils.handleError(it) }.getOrNull()
     }
 
     suspend fun rejectLogin(rendezvousKey: KeyPair) {
@@ -174,6 +175,7 @@ class PaymentRepository @Inject constructor(
                     amount = paymentAmount,
                     successful = false
                 )
+                ErrorUtils.handleError(error)
                 cont.resumeWithException(error)
             }
         }

api/src/main/java/com/getcode/utils/ErrorUtils.kt

@@ -39,7 +39,7 @@ object ErrorUtils {
         }
 
         if (
-            !BuildConfig.DEBUG &&
+            BuildConfig.NOTIFY_ERRORS &&
             throwable !is UnknownHostException &&
             throwable !is TimeoutException &&
             throwable !is ConnectException
@@ -49,16 +49,18 @@ object ErrorUtils {
         }
     }
 
-    fun isNetworkError(throwable: Throwable): Boolean =
+    private fun isNetworkError(throwable: Throwable): Boolean =
         throwable is TimeoutException ||
                 throwable.cause is TimeoutException ||
                 throwable is UnknownHostException ||
                 throwable.cause is UnknownHostException
 
-    fun isRuntimeError(throwable: Throwable): Boolean =
+    private fun isRuntimeError(throwable: Throwable): Boolean =
         throwable is StatusRuntimeException ||
                 throwable.cause is StatusRuntimeException
 
-    fun isSuppressibleError(throwable: Throwable): Boolean =
-        throwable is SQLException || throwable is net.sqlcipher.SQLException
-}
+    private fun isSuppressibleError(throwable: Throwable): Boolean =
+        throwable is SQLException || throwable is net.sqlcipher.SQLException || throwable is SuppressibleException
+}
+
+data class SuppressibleException(override val message: String): Throwable(message)

app/build.gradle.kts

@@ -35,6 +35,7 @@ android {
         val properties = Properties()
         properties.load(propertiesFile.inputStream())
         buildConfigField("String", "MIXPANEL_API_KEY", "\"${properties.getProperty("MIXPANEL_API_KEY")}\"")
+        buildConfigField("Boolean", "NOTIFY_ERRORS", "false")
     }
 
     signingConfigs {

app/src/main/java/com/getcode/models/DeepLinkPaymentRequest.kt

@@ -4,6 +4,7 @@ import com.getcode.model.CurrencyCode
 import com.getcode.model.Fiat
 import com.getcode.network.repository.decodeBase64
 import com.getcode.solana.keys.PublicKey
+import com.getcode.utils.ErrorUtils
 import com.getcode.vendor.Base58
 import kotlinx.serialization.SerialName
 import kotlinx.serialization.Serializable
@@ -75,6 +76,7 @@ data class DeepLinkPaymentRequest(
             val destination = runCatching { PublicKey.fromBase58(destinationString) }
                 .getOrNull()
             if (destination == null) {
+                ErrorUtils.handleError(Throwable())
                 Timber.e("Invalid destination address")
                 return null
             }

app/src/main/java/com/getcode/view/main/home/HomeViewModel.kt

@@ -218,7 +218,7 @@ class HomeViewModel @Inject constructor(
                     historyController.fetchChats()
                 },
                 onFailure = {
-                    Timber.e(t = it, message = "Auto airdrop failed")
+                    ErrorUtils.handleError(it)
                     prefRepository.set(PrefsBool.IS_ELIGIBLE_GET_FIRST_KIN_AIRDROP, false)
                 }
             )
@@ -686,11 +686,12 @@ class HomeViewModel @Inject constructor(
             delay(1.seconds)
             cancelPayment(false)
         }.onFailure { error ->
-            error.printStackTrace()
             TopBarManager.showMessage(
                 resources.getString(R.string.error_title_payment_failed),
                 resources.getString(R.string.error_description_payment_failed),
             )
+
+            ErrorUtils.handleError(error)
             uiFlow.update { uiModel ->
                 uiModel.copy(
                     presentationStyle = PresentationStyle.Hidden,

ed25519/build.gradle.kts

@@ -3,7 +3,7 @@ plugins {
 }
 
 android {
-    namespace = "com.getcode.ed25519"
+    namespace = "${Android.namespace}.ed25519"
     compileSdk = Android.compileSdkVersion
     defaultConfig {
         minSdk = Android.minSdkVersion

scripts/internal-testing-build.sh

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+
+date="$(date '+%m.%d.%y')"
+
+export NOTIFY_ERRORS=true
+./gradlew assembleDebug
+
+outputDir="$(pwd)/app/build/outputs/apk/debug"
+mv "${outputDir}/app-debug.apk" "${outputDir}/app-${date}-debug.apk"
+
+unset NOTIFY_ERRORS