Merge pull request #106 from code-payments/fix/phone-link-hint-vis

fix(phone/link): ensure google hint only pops once per flow

Author: bmc08gt

app/src/main/java/com/getcode/view/login/PhoneVerify.kt

@@ -152,6 +152,7 @@ internal fun PhoneVerify(
         contract = ActivityResultContracts.StartIntentSenderForResult()
     ) {
         if (it.resultCode != Activity.RESULT_OK) {
+            viewModel.dismissedHint()
             return@rememberLauncherForActivityResult
         }
 
@@ -161,13 +162,13 @@ internal fun PhoneVerify(
         viewModel.setPhoneFromHint(phoneNum)
     }
 
-    LaunchedEffect(phoneNumberHintLauncher) {
+    LaunchedEffect(dataState.hasDismissedHint) {
         val request = GetPhoneNumberHintIntentRequest
             .builder()
             .build()
 
         val isSettled = navigator.lastItem == navigator.lastModalItem || arguments.isNewAccount
-        if (isSettled && dataState.phoneNumberFormatted.isEmpty()) {
+        if (isSettled && dataState.phoneNumberFormatted.isEmpty() && !dataState.hasDismissedHint) {
             Identity.getSignInClient(context)
                 .getPhoneNumberHintIntent(request)
                 .addOnSuccessListener {

app/src/main/java/com/getcode/view/login/PhoneVerifyViewModel.kt

@@ -51,6 +51,7 @@ data class PhoneVerifyUiModel(
     val entropyB64: String? = null,
     val isPhoneLinking: Boolean = false,
     val isNewAccount: Boolean = false,
+    val hasDismissedHint: Boolean = false,
 )
 
 @HiltViewModel
@@ -87,6 +88,8 @@ class PhoneVerifyViewModel @Inject constructor(
         uiFlow.update { it.copy(isNewAccount = isNewAccount) }
     }
 
+    fun dismissedHint() = uiFlow.update { it.copy(hasDismissedHint = true) }
+
     fun setCountryCode(countryLocale: PhoneUtils.CountryLocale) {
         uiFlow.update { it.copy(countryLocale = countryLocale) }
     }