feat: add UserFlagsCoordinator shared module for managing user flags with local overrides

Introduce :apps:flipcash:shared:userflags module that combines server-backed
user flags with DataStore-persisted local overrides for staff testing. Exposes
a single non-nullable resolvedFlags StateFlow with ResolvedFlag wrappers that
track server values alongside override state.

Move UserFlags model from internal to services/models for public access.
Migrate consumers (BillController, login ViewModels, AppUpdateController) from
UserManager.userFlags to the new coordinator. Simplify Result chaining in
login ViewModels and add override-aware update availability and reset support
in AppUpdateController.

Signed-off-by: Brandon McAnsh <git@bmcreations.dev>

Author: bmc08gt

apps/flipcash/app/src/main/kotlin/com/flipcash/app/internal/ui/navigation/MainRoot.kt

@@ -29,7 +29,7 @@ import com.flipcash.app.core.extensions.navigateTo
 import com.flipcash.app.core.extensions.resolveRoutes
 import com.flipcash.app.router.LocalRouter
 import com.flipcash.app.router.Router
-import com.flipcash.services.internal.model.account.UserFlags
+import com.flipcash.services.models.UserFlags
 import com.flipcash.services.user.AuthState
 import com.getcode.navigation.core.CodeNavigator
 import com.getcode.navigation.core.LocalCodeNavigator

apps/flipcash/core/build.gradle.kts

@@ -34,6 +34,7 @@ dependencies {
     api(project(":libs:permissions:public"))
     implementation(project(":libs:vibrator:public"))
 
+    implementation(project(":apps:flipcash:shared:userflags"))
     api(project(":apps:flipcash:shared:theme"))
 
     api(libs.sodium.bindings)

apps/flipcash/core/src/main/kotlin/com/flipcash/app/core/internal/bill/BillController.kt

@@ -1,6 +1,7 @@
 package com.flipcash.app.core.internal.bill
 
 import com.flipcash.app.core.bill.BillState
+import com.flipcash.app.userflags.UserFlagsCoordinator
 import com.flipcash.services.user.UserManager
 import com.getcode.opencode.internal.manager.VerifiedState
 import com.getcode.opencode.model.accounts.AccountCluster
@@ -19,7 +20,7 @@ import javax.inject.Singleton
 @Singleton
 class BillController @Inject constructor(
     private val transactionManager: BillTransactionManager,
-    private val userManager: UserManager,
+    private val userFlags: UserFlagsCoordinator,
 ) {
     private val _state = MutableStateFlow(BillState.Default)
     val state: StateFlow<BillState>
@@ -50,7 +51,7 @@ class BillController @Inject constructor(
         amount = amount,
         owner = owner,
         verifiedState = verifiedState,
-        billExchangeDataTimeout = userManager.userFlags?.billExchangeDataTimeout,
+        billExchangeDataTimeout = userFlags.resolvedFlags.value.billExchangeDataTimeout.effectiveValue,
         present = present,
         onGrabbed = onGrabbed,
         onTimeout = onTimeout,

apps/flipcash/features/appupdates/src/main/kotlin/com/flipcash/app/updates/UpdateRequiredView.kt

@@ -27,6 +27,7 @@ import androidx.compose.ui.tooling.preview.Preview
 import androidx.lifecycle.Lifecycle
 import androidx.lifecycle.compose.collectAsStateWithLifecycle
 import com.flipcash.app.theme.FlipcashPreview
+import com.flipcash.app.updates.internal.NoUpdateAvailableException
 import com.flipcash.features.appupdates.R
 import com.getcode.theme.CodeTheme
 import com.getcode.ui.biometrics.BiometricsState
@@ -68,6 +69,11 @@ fun UpdateRequiredBlockingView(
                         onClick = {
                             composeScope.launch {
                                 appUpdater.startUpdate()
+                                    .onFailure {
+                                        if (it is NoUpdateAvailableException) {
+                                            appUpdater.reset()
+                                        }
+                                    }
                             }
                         },
                         text = stringResource(id = R.string.action_updateNow),
@@ -130,24 +136,17 @@ fun UpdateRequiredBlockingView(
 private fun PreviewUpdateRequiredView() {
     FlipcashPreview {
         val appUpdater = remember {
-            object : AppUpdateController {
-                override val availableUpdate = MutableStateFlow<UpdateInfo?>(
-                    UpdateInfo(
-                        updateAvailability = UpdateAvailability.UPDATE_AVAILABLE,
-                        updatePriority = 5,
-                        clientVersionStalenessDays = null,
-                        bytesDownloaded = 0,
-                        totalBytesToDownload = 100,
-                        installStatus = InstallStatus.UNKNOWN,
-                        availableVersionCode = 3000
-                    )
+            StubAppUpdateController(
+                UpdateInfo(
+                    updateAvailability = UpdateAvailability.UPDATE_AVAILABLE,
+                    updatePriority = 5,
+                    clientVersionStalenessDays = null,
+                    bytesDownloaded = 0,
+                    totalBytesToDownload = 100,
+                    installStatus = InstallStatus.UNKNOWN,
+                    availableVersionCode = 3000
                 )
-
-                override suspend fun checkForUpdate() = Unit
-
-                override suspend fun startUpdate(): Result<Unit> = Result.success(Unit)
-
-            }
+            )
         }
         CompositionLocalProvider(LocalAppUpdater provides appUpdater) {
             UpdateRequiredBlockingView(

apps/flipcash/features/login/build.gradle.kts

@@ -18,6 +18,7 @@ dependencies {
     implementation(project(":apps:flipcash:shared:analytics"))
     implementation(project(":apps:flipcash:shared:authentication"))
     implementation(project(":apps:flipcash:shared:featureflags"))
+    implementation(project(":apps:flipcash:shared:userflags"))
     implementation(project(":libs:datetime"))
     implementation(project(":libs:messaging"))
     implementation(project(":libs:permissions:bindings"))

apps/flipcash/features/login/src/main/kotlin/com/flipcash/app/login/accesskey/LoginAccessKeyViewModel.kt

@@ -6,6 +6,7 @@ import com.flipcash.app.analytics.Button
 import com.flipcash.app.analytics.FlipcashAnalyticsService
 import com.flipcash.app.auth.AuthManager
 import com.flipcash.app.core.storage.MediaScanner
+import com.flipcash.app.userflags.UserFlagsCoordinator
 import com.flipcash.services.user.UserManager
 import com.getcode.libs.qr.QRCodeGenerator
 import com.getcode.opencode.managers.MnemonicManager
@@ -22,43 +23,35 @@ class LoginAccessKeyViewModel @Inject constructor(
     mnemonicManager: MnemonicManager,
     qrCodeGenerator: QRCodeGenerator,
     mediaScanner: MediaScanner,
-    private val userManager: UserManager,
+    userManager: UserManager,
+    private val userFlags: UserFlagsCoordinator,
     private val authManager: AuthManager,
     private val analytics: FlipcashAnalyticsService,
 ): BaseAccessKeyViewModel(resources, mnemonicManager, mediaScanner, userManager, qrCodeGenerator) {
 
-    suspend fun saveImage(): Result<Boolean> = trackButton(Button.SaveAccessKey)
-        .fold(
-            onSuccess = { saveBitmapToFile() },
-            onFailure = { Result.failure(it) }
-        )
-        .onSuccess { authManager.onUserAccessKeySeen() }
-        .map { authManager.presentCredentialStorage() }
-        .map { userManager.userFlags?.requiresIapForRegistration == true }
-        .map {
+    suspend fun onWroteDownInstead(): Result<Boolean> {
+        trackButton(Button.WroteAccessKey)
+        uiFlow.update { it.copy(skipState = LoadingSuccessState(loading = true)) }
+        return runCatching {
+            authManager.onUserAccessKeySeen()
+            authManager.presentCredentialStorage()
             delay(150)
-            uiFlow.update { s -> s.copy(exportState = LoadingSuccessState(success = true)) }
-            it
+            uiFlow.update { s -> s.copy(skipState = LoadingSuccessState(success = true)) }
+            userFlags.resolvedFlags.value.requiresIapForRegistration.effectiveValue
         }
+    }
 
-    suspend fun onWroteDownInstead(): Result<Boolean> = trackButton(Button.WroteAccessKey)
-        .map {
-            uiFlow.update { it.copy(skipState = LoadingSuccessState(loading = true)) }
-        }
-        .fold(
-            onSuccess = { authManager.onUserAccessKeySeen() },
-            onFailure = {
-                uiFlow.update { s -> s.copy(skipState = LoadingSuccessState()) }
-                Result.failure(it)
+    suspend fun saveImage(): Result<Boolean> {
+        trackButton(Button.SaveAccessKey)
+        return saveBitmapToFile()
+            .onSuccess { authManager.onUserAccessKeySeen() }
+            .mapCatching {
+                authManager.presentCredentialStorage()
+                delay(150)
+                uiFlow.update { s -> s.copy(exportState = LoadingSuccessState(success = true)) }
+                userFlags.resolvedFlags.value.requiresIapForRegistration.effectiveValue
             }
-        )
-        .map { authManager.presentCredentialStorage() }
-        .map { userManager.userFlags?.requiresIapForRegistration == true }
-        .map {
-            delay(150)
-            uiFlow.update { s -> s.copy(skipState = LoadingSuccessState(success = true)) }
-            it
-        }
+    }
 
     private fun trackButton(button: Button): Result<Unit> {
         analytics.buttonTapped(button)

apps/flipcash/features/login/src/main/kotlin/com/flipcash/app/login/seed/SeedInputViewModel.kt

@@ -5,9 +5,12 @@ import androidx.lifecycle.viewModelScope
 import com.flipcash.app.auth.AuthManager
 import com.flipcash.app.auth.internal.credentials.SelectCredentialError
 import com.flipcash.app.core.AppRoute
+import com.flipcash.app.userflags.ResolvedFlag
+import com.flipcash.app.userflags.ResolvedUserFlags
+import com.flipcash.app.userflags.UserFlagsCoordinator
 import com.flipcash.features.login.R
 import com.flipcash.services.controllers.AccountController
-import com.flipcash.services.internal.model.account.UserFlags
+import com.flipcash.services.models.UserFlags
 import com.flipcash.services.user.UserManager
 import com.getcode.crypt.MnemonicPhrase
 import com.getcode.manager.BottomBarAction
@@ -41,6 +44,7 @@ class SeedInputViewModel @Inject constructor(
     private val authManager: AuthManager,
     private val accountController: AccountController,
     private val userManager: UserManager,
+    private val userFlags: UserFlagsCoordinator,
     private val resources: ResourceHelper,
     private val mnemonicManager: MnemonicManager,
 ) : BaseViewModel(resources) {
@@ -105,11 +109,12 @@ class SeedInputViewModel @Inject constructor(
                     setState(isLoading = false, isSuccess = false, isContinueEnabled = true)
                 }
                 .onSuccess {
-                    val userFlags = userManager.userFlags
-                    if (userFlags == null) {
+                    val resolvedFlags = userFlags.resolvedFlags.value
+                    // check if we have server backed flags
+                    if (resolvedFlags.minimumVersion.serverValue == null) {
                         accountController.getUserFlags()
                             .onSuccess {
-                                postLoginNavigation(navigator, it)
+                                postLoginNavigation(navigator, userFlags.resolvedFlags.value)
                             }.onFailure {
                                 setState(isLoading = false, isSuccess = false, isContinueEnabled = false)
                                 BottomBarManager.showError(
@@ -118,20 +123,20 @@ class SeedInputViewModel @Inject constructor(
                                 )
                             }
                     } else {
-                        postLoginNavigation(navigator, userFlags)
+                        postLoginNavigation(navigator, resolvedFlags)
                     }
                 }
         }
     }
 
     private suspend fun postLoginNavigation(
         navigator: CodeNavigator,
-        flags: UserFlags,
+        flags: ResolvedUserFlags?,
     ) {
         setState(isLoading = false, isSuccess = true, isContinueEnabled = false)
         delay(1.seconds)
         when {
-            !flags.isRegistered && flags.requiresIapForRegistration -> {
+            flags?.isRegistered?.effectiveValue == true && flags.requiresIapForRegistration.effectiveValue -> {
                 navigator.push(AppRoute.Onboarding.Purchase(true))
             }
 

apps/flipcash/shared/appupdates/build.gradle.kts

@@ -10,4 +10,5 @@ dependencies {
     api(libs.google.play.app.updates.runtime)
     api(libs.google.play.app.updates.ktx)
 
+    implementation(project(":apps:flipcash:shared:userflags"))
 }

apps/flipcash/shared/appupdates/src/main/kotlin/com/flipcash/app/updates/AppUpdateController.kt

@@ -30,4 +30,5 @@ interface AppUpdateController {
     suspend fun checkForUpdate()
 
     suspend fun startUpdate(): Result<Unit>
+    suspend fun reset()
 }

apps/flipcash/shared/appupdates/src/main/kotlin/com/flipcash/app/updates/LocalAppUpdater.kt

@@ -6,12 +6,14 @@ import kotlinx.coroutines.flow.StateFlow
 
 val LocalAppUpdater = compositionLocalOf<AppUpdateController> { StubAppUpdateController() }
 
-private class StubAppUpdateController: AppUpdateController {
-    override val availableUpdate: StateFlow<UpdateInfo?> = MutableStateFlow(null)
+class StubAppUpdateController(updateInfo: UpdateInfo? = null): AppUpdateController {
+    override val availableUpdate: StateFlow<UpdateInfo?> = MutableStateFlow(updateInfo)
 
     override suspend fun checkForUpdate() = Unit
 
     override suspend fun startUpdate(): Result<Unit> {
         return Result.failure(Throwable("This is a stub implementation"))
     }
+
+    override suspend fun reset() = Unit
 }