Merge pull request #573 from code-payments/fix/handle-idempotency-properly-for-payment-failures

bmc08gt · web-flow · commit 8d4a842106d3 · 2024-09-19T18:48:44.000-04:00
fix(session): handle idempotencyKeys properly when hitting payment failures
diff --git a/app/src/main/java/com/getcode/SessionController.kt b/app/src/main/java/com/getcode/SessionController.kt
@@ -1290,6 +1290,9 @@ class SessionController @Inject constructor(
                 resources.getString(R.string.error_description_payment_failed),
             )
 
+            // Allow the payment request to be scanned again upon a failure state hit
+            scannedRendezvous.remove(paymentConfirmation.payload.rendezvous.publicKey)
+
             ErrorUtils.handleError(error)
             state.update { uiModel ->
                 uiModel.copy(

Original file line number	Diff line number	Diff line change
`@@ -1290,6 +1290,9 @@ class SessionController @Inject constructor(`
`1290`	`1290`	`resources.getString(R.string.error_description_payment_failed),`
`1291`	`1291`	`)`
`1292`	`1292`
	`1293`	`+ // Allow the payment request to be scanned again upon a failure state hit`
	`1294`	`+ scannedRendezvous.remove(paymentConfirmation.payload.rendezvous.publicKey)`
	`1295`	`+`
`1293`	`1296`	`ErrorUtils.handleError(error)`
`1294`	`1297`	`state.update { uiModel ->`
`1295`	`1298`	`uiModel.copy(`