chore(flipcash/pools): handle NSF errors for bids explicitly

Signed-off-by: Brandon McAnsh <git@bmcreations.dev>

Author: bmc08gt

apps/flipcash/core/src/main/res/values/strings.xml

@@ -215,6 +215,7 @@
 
     <string name="error_title_paymentFailedDueToInsufficientFunds">Insufficient Balance</string>
     <string name="error_description_paymentFailedDueToInsufficientFunds">You don\’t have enough funds to complete this payment</string>
+    <string name="error_description_poolBidFailedDueToInsufficientFunds">You need more funds to join this Pool</string>
 
     <string name="error_title_placeBetFailed">Something Went Wrong</string>
     <string name="error_description_placeBetFailed">We were unable to place your bid. Please try again</string>

apps/flipcash/features/pools/src/main/kotlin/com/flipcash/app/pools/internal/betting/PoolBettingViewModel.kt

@@ -13,6 +13,7 @@ import com.flipcash.app.core.pools.PoolWithBets
 import com.flipcash.app.payments.PaymentController
 import com.flipcash.app.payments.PaymentEvent
 import com.flipcash.app.payments.PaymentRequest
+import com.flipcash.app.payments.internal.PaymentError
 import com.flipcash.app.payments.internal.PoolBidPaymentMetadata
 import com.flipcash.app.pools.PoolUpdater
 import com.flipcash.app.pools.PoolsCoordinator
@@ -347,7 +348,18 @@ internal class PoolBettingViewModel @Inject constructor(
             }.onEach { event ->
                 when (event) {
                     PaymentEvent.OnPaymentCancelled -> Unit
-                    is PaymentEvent.OnPaymentError -> Unit
+                    is PaymentEvent.OnPaymentError -> {
+                        when (event.error) {
+                            is PaymentError.InsufficientBalance -> {
+                                BottomBarManager.showError(
+                                    resources.getString(R.string.error_title_paymentFailedDueToInsufficientFunds),
+                                    resources.getString(R.string.error_description_poolBidFailedDueToInsufficientFunds),
+                                )
+                            }
+                            // other errors are handled internally
+                            else -> Unit
+                        }
+                    }
                     is PaymentEvent.OnRpcFailure -> {
                         BottomBarManager.showError(
                             resources.getString(R.string.error_title_placeBetFailed),

apps/flipcash/shared/payments/src/main/kotlin/com/flipcash/app/payments/internal/InternalPaymentController.kt

@@ -212,7 +212,12 @@ internal class InternalPaymentController(
         when {
             error is PaymentError -> {
                 when (error) {
-                    is PaymentError.InsufficientBalance -> presentInsufficientFundsError()
+                    is PaymentError.InsufficientBalance -> {
+                        if (state.value.request !is PaymentRequest.PoolBid) {
+                            // NSF on pool bids is handled at client level
+                            presentInsufficientFundsError()
+                        }
+                    }
                     is PaymentError.NoOwnerForDistribution -> presentPaymentFailedError()
                     is PaymentError.NoPoolBalance -> presentPaymentFailedError()
                 }