chore(core): replace fixedRateTimer with coroutine polling in NetworkUpdater's

Signed-off-by: Brandon McAnsh <git@bmcreations.dev>

Author: bmc08gt

apps/flipcash/core/src/main/kotlin/com/flipcash/app/core/internal/updater/ProfileUpdater.kt

@@ -2,34 +2,12 @@ package com.flipcash.app.core.internal.updater
 
 import com.flipcash.app.core.updater.NetworkUpdater
 import com.flipcash.services.controllers.ProfileController
-import kotlinx.coroutines.CoroutineScope
-import kotlinx.coroutines.coroutineScope
-import kotlinx.coroutines.launch
 import javax.inject.Inject
-import kotlin.concurrent.fixedRateTimer
-import kotlin.time.Duration
 
 class ProfileUpdater @Inject constructor(
     private val profileController: ProfileController,
 ) : NetworkUpdater() {
-
-    override fun poll(
-        key: Any?,
-        scope: CoroutineScope,
-        frequency: Duration,
-        startIn: Duration
-    ) {
-        stop()
-        updater = fixedRateTimer(
-            name = "update profile",
-            initialDelay = startIn.inWholeMilliseconds,
-            period = frequency.inWholeMilliseconds
-        ) {
-            scope.launch {
-                coroutineScope {
-                    profileController.updateUserProfile()
-                }
-            }
-        }
+    override suspend fun doUpdate() {
+        profileController.updateUserProfile()
     }
-}
+}

apps/flipcash/core/src/main/kotlin/com/flipcash/app/core/updater/NetworkUpdater.kt

@@ -1,23 +1,36 @@
 package com.flipcash.app.core.updater
 
 import kotlinx.coroutines.CoroutineScope
-import java.util.Timer
+import kotlinx.coroutines.Job
+import kotlinx.coroutines.delay
+import kotlinx.coroutines.isActive
+import kotlinx.coroutines.launch
 import kotlin.time.Duration
 import kotlin.time.Duration.Companion.seconds
 
 abstract class NetworkUpdater {
-    protected var updater: Timer? = null
+    private var job: Job? = null
 
-    abstract fun poll(
+    protected abstract suspend fun doUpdate()
+
+    fun poll(
         key: Any? = null,
         scope: CoroutineScope,
         frequency: Duration,
         startIn: Duration = 0.seconds,
-    )
-
-    open fun stop() {
-        updater?.cancel()
-        updater = null
+    ) {
+        stop()
+        job = scope.launch {
+            delay(startIn)
+            while (isActive) {
+                doUpdate()
+                delay(frequency)
+            }
+        }
+    }
 
+    fun stop() {
+        job?.cancel()
+        job = null
     }
-}
+}

apps/flipcash/shared/activityfeed/src/main/kotlin/com/flipcash/app/activityfeed/ActivityFeedUpdater.kt

@@ -1,30 +1,12 @@
 package com.flipcash.app.activityfeed
 
 import com.flipcash.app.core.updater.NetworkUpdater
-import kotlinx.coroutines.CoroutineScope
-import kotlinx.coroutines.launch
 import javax.inject.Inject
-import kotlin.concurrent.fixedRateTimer
-import kotlin.time.Duration
 
 class ActivityFeedUpdater @Inject constructor(
     private val coordinator: ActivityFeedCoordinator,
 ): NetworkUpdater() {
-    override fun poll(
-        key: Any?,
-        scope: CoroutineScope,
-        frequency: Duration,
-        startIn: Duration,
-    ) {
-        stop()
-        updater = fixedRateTimer(
-            name = "update activity feed",
-            initialDelay = startIn.inWholeMilliseconds,
-            period = frequency.inWholeMilliseconds
-        ) {
-            scope.launch {
-                coordinator.fetchSinceLatest(count = 50)
-            }
-        }
+    override suspend fun doUpdate() {
+        coordinator.fetchSinceLatest(count = 50)
     }
-}
+}

apps/flipcash/shared/tokens/src/main/kotlin/com/flipcash/app/tokens/TokenUpdater.kt

@@ -1,30 +1,12 @@
 package com.flipcash.app.tokens
 
 import com.flipcash.app.core.updater.NetworkUpdater
-import kotlinx.coroutines.CoroutineScope
-import kotlinx.coroutines.launch
 import javax.inject.Inject
-import kotlin.concurrent.fixedRateTimer
-import kotlin.time.Duration
 
 class TokenUpdater @Inject constructor(
     private val coordinator: TokenCoordinator,
 ) : NetworkUpdater() {
-    override fun poll(
-        key: Any?,
-        scope: CoroutineScope,
-        frequency: Duration,
-        startIn: Duration,
-    ) {
-        stop()
-        updater = fixedRateTimer(
-            name = "update tokens",
-            initialDelay = startIn.inWholeMilliseconds,
-            period = frequency.inWholeMilliseconds
-        ) {
-            scope.launch {
-                coordinator.update()
-            }
-        }
+    override suspend fun doUpdate() {
+        coordinator.update()
     }
-}
+}