ci(lint): lint library modules from the app's lintDebug (#1743)

* fix(chat): guard MediaStore.getPickImagesMaxLimit on older pickers

rememberChatPhotoPicker called getPickImagesMaxLimit() during composition
with no version check. The method exists only on API 33+, or on API 30-32
with SDK extension R 2+, so an Android 12 device without the MediaProvider
update threw NoSuchMethodError every time a chat opened (Bugsnag
6ac91865991833fd09984195, Samsung SM-N976V).

Only call it where the system picker provides it. Elsewhere androidx falls
back to a picker with no cap of its own, and the result callback already
trims the selection to the remaining slots.

* fix(chat): cap the fallback photo picker at the open slots

Int.MAX_VALUE never reached the picker, since the clamp came out to
remaining anyway, but it read as no cap. Fall back to remaining directly.

* ci(lint): lint library modules from the app's lintDebug

CI runs :apps:flipcash:app:lintDebug, but checkDependencies defaults to
false, so lint only looked at the app module. The unguarded
MediaStore.getPickImagesMaxLimit() call in chat-ui (#1741) shipped
because no lint run ever saw it; with checkDependencies on, lint fails on
it with NewApi.

Turning it on surfaces three other existing errors, which go in the
baseline so the check gates new issues only: WrongConstant in
AppSettingsMapper, UnspecifiedRegisterReceiverFlag in SmsOtpAutofill (the
pre-34 branch, where the flag isn't available), and
UnrememberedMutableState in Flippable.

Author: bmc08gt

apps/flipcash/app/build.gradle.kts

@@ -115,6 +115,7 @@ android {
 
     lint {
         checkReleaseBuilds = false
+        checkDependencies = true
         baseline = file("lint-baseline.xml")
     }
 

apps/flipcash/app/lint-baseline.xml

@@ -377,4 +377,37 @@
             column="31"/>
     </issue>
 
+    <issue
+        id="WrongConstant"
+        message="Must be one or more of: Authenticators.BIOMETRIC_STRONG, Authenticators.BIOMETRIC_WEAK, Authenticators.DEVICE_CREDENTIAL, Authenticators.IDENTITY_CHECK"
+        errorLine1="                val biometricsState = biometricManager.canAuthenticate(Biometrics.TEST_AUTH)"
+        errorLine2="                                                                       ~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/kotlin/com/flipcash/app/appsettings/internal/AppSettingsMapper.kt"
+            line="18"
+            column="72"/>
+    </issue>
+
+    <issue
+        id="UnspecifiedRegisterReceiverFlag"
+        message="`receiver` is missing `RECEIVER_EXPORTED` or `RECEIVER_NOT_EXPORTED` flag for unprotected broadcasts registered for com.google.android.gms.auth.api.phone.SMS_RETRIEVED"
+        errorLine1="            context.registerReceiver(receiver, filter, SmsRetriever.SEND_PERMISSION, null)"
+        errorLine2="            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
+        <location
+            file="src/main/kotlin/com/flipcash/app/phone/components/SmsOtpAutofill.kt"
+            line="104"
+            column="13"/>
+    </issue>
+
+    <issue
+        id="UnrememberedMutableState"
+        message="Creating a state object during composition without using `remember`"
+        errorLine1="        object : State&lt;Float> {"
+        errorLine2="        ^">
+        <location
+            file="src/main/kotlin/com/getcode/ui/components/Flippable.kt"
+            line="57"
+            column="9"/>
+    </issue>
+
 </issues>