chore(scan): scan full static image at various scan qualities to improve parse success rate

Signed-off-by: Brandon McAnsh <git@bmcreations.dev>

Author: bmc08gt

app/src/main/java/com/kik/kikx/kikcodes/implementation/KikCodeAnalyzer.kt

@@ -10,6 +10,7 @@ import com.getcode.media.MediaScanner
 import com.getcode.util.toByteArray
 import com.getcode.utils.ErrorUtils
 import com.kik.kikx.kikcodes.KikCodeScanner
+import com.kik.kikx.kikcodes.ScannerError
 import com.kik.kikx.models.ScannableKikCode
 import dagger.hilt.android.qualifiers.ApplicationContext
 import kotlinx.coroutines.CoroutineScope
@@ -55,7 +56,7 @@ class KikCodeAnalyzer @Inject constructor(
 
             }.onFailure { error ->
                 when (error) {
-                    is KikCodeScanner.NoKikCodeFoundException -> Unit
+                    is ScannerError -> Unit
                     else -> ErrorUtils.handleError(error)
                 }
                 imageProxy.close()
@@ -70,7 +71,7 @@ class KikCodeAnalyzer @Inject constructor(
                     onCodeScanned(result)
                 }.onFailure { error ->
                     when (error) {
-                        is KikCodeScanner.NoKikCodeFoundException -> onNoCodeFound()
+                        is ScannerError -> onNoCodeFound()
                         else -> ErrorUtils.handleError(error)
                     }
                 }

app/src/main/java/com/kik/kikx/kikcodes/implementation/StaticImageHelper.kt

@@ -7,13 +7,15 @@ import android.icu.text.DateFormat
 import android.icu.text.SimpleDateFormat
 import android.net.Uri
 import android.os.Environment
+import com.getcode.BuildConfig
 import com.getcode.analytics.AnalyticsService
 import com.getcode.util.save
 import com.getcode.util.toByteArray
 import com.getcode.util.uriToBitmap
 import com.getcode.utils.TraceType
 import com.getcode.utils.timedTraceSuspend
 import com.kik.kikx.kikcodes.KikCodeScanner
+import com.kik.kikx.kikcodes.ScanQuality
 import com.kik.kikx.models.ScannableKikCode
 import dagger.hilt.android.qualifiers.ApplicationContext
 import kotlinx.coroutines.Dispatchers
@@ -32,11 +34,12 @@ class StaticImageHelper @Inject constructor(
     suspend fun analyze(uri: Uri): Result<ScannableKikCode> {
         val bitmap = context.uriToBitmap(uri)
         return if (bitmap != null) {
-            detectCodeInImage(bitmap) {
+            detectCodeInImage(bitmap) { image, quality ->
                 scanner.scanKikCode(
-                    it.toByteArray(),
-                    it.width,
-                    it.height,
+                    image.toByteArray(),
+                    image.width,
+                    image.height,
+                    quality
                 )
             }
         } else {
@@ -46,7 +49,7 @@ class StaticImageHelper @Inject constructor(
 
     private suspend fun detectCodeInImage(
         bitmap: Bitmap,
-        scan: suspend (Bitmap) -> Result<ScannableKikCode>
+        scan: suspend (Bitmap, ScanQuality) -> Result<ScannableKikCode>
     ): Result<ScannableKikCode> = withContext(Dispatchers.Default) {
         val destinationRoot =
             Environment.getExternalStoragePublicDirectory(Environment.DIRECTORY_PICTURES)
@@ -63,7 +66,7 @@ class StaticImageHelper @Inject constructor(
     private suspend fun search(
         bitmap: Bitmap,
         destination: File,
-        scan: suspend (Bitmap) -> Result<ScannableKikCode>,
+        scan: suspend (Bitmap, ScanQuality) -> Result<ScannableKikCode>,
     ): Result<ScannableKikCode> {
         return timedTraceSuspend(
             message = "analyzing image",
@@ -73,22 +76,24 @@ class StaticImageHelper @Inject constructor(
                 analytics.photoScanned(result.isSuccess, time.inWholeMilliseconds)
             }
         ) {
-            // try scanning raw
-            val raw = scan(bitmap)
-            if (raw.isSuccess) {
-                debugPrint("Code found raw")
-                bitmap.recycle()
-                return@timedTraceSuspend raw
-            } else {
-                debugPrint("No Code found via raw")
+            // try scanning raw at various scan qualities
+            for (quality in ScanQuality.iterator()) {
+                val raw = scan(bitmap, quality)
+                if (raw.isSuccess) {
+                    debugPrint("Code found raw using $quality")
+                    bitmap.recycle()
+                    return@timedTraceSuspend raw
+                } else {
+                    debugPrint("No Code found via raw using $quality")
+                }
             }
 
             val zoomLevels = listOf(1.0)
             val result = slidingWindowSearch(
                 bitmap = bitmap,
                 destination = destination,
                 zoomLevels = zoomLevels,
-                scan = scan,
+                scan = { scan(it, ScanQuality.Medium) },
             )
 
             if (result.isSuccess) {
@@ -235,5 +240,5 @@ private fun debugPrint(message: String) {
     if (DEBUG) println(message)
 }
 
-private const val DEBUG = true
+private val DEBUG = BuildConfig.DEBUG
 private const val SAVE_IMAGES = false