refactor(analytics): send every event through FlipcashAnalytics.track (#1554)

* refactor(analytics): add the track interface beside the legacy service

* refactor(analytics): convert Android domain types for the shared builders

* refactor(analytics): move chat events onto the shared builders

* refactor(analytics): move transfer events onto the shared builders

Every transfer call site now tracks a TransferEvents builder. The amount
conversion follows the type each caller already had (LocalFiat, or the
scanned Fiat on a failed grab), so the property block is unchanged.
Grab Time now goes out as a number instead of a string.

The session delegate tests assert the event each grab, give, claim and
cash-link share sends. TippingCoordinator lost its transfer call in #1463;
only its unused Analytics import goes here.

* refactor(analytics): move add money events onto the shared builders

Every add-money call site now tracks an AddMoneyEvents builder instead of
the legacy Analytics.AddMoney enums and FlipcashAnalyticsService methods.
Fiat/LocalFiat amounts and thrown errors go through their .analytics
converters, so each property block is unchanged except numbers going out
as numbers instead of strings. Analytics.AddMoneySource, AddMoneyMethod,
the AddMoneyEvent sealed interface, and the Mixpanel delegate overrides
are dead now that every caller uses the shared builder, so they are removed.

* refactor(analytics): move onramp events onto the shared builders

The five contact-verification screens now track OnrampEvents.step(...)
from the same LaunchedEffect. The events carry no properties, and a new
test pins each step to the name the screens sent before.

openOnramp, onrampPurchase, OnrampSource, OnrampPurchaseStep and their
eight events had no callers and are deleted.

* refactor(analytics): move wallet events onto the shared builders

Wallet connect/request-amount/failed/cancel in SwapViewModel now go
through WalletEvents instead of the bespoke FlipcashAnalyticsService
methods, so amounts and providers convert through .analytics like the
other builder call sites. transactionSubmittedToWallet had no caller
and is deleted along with its event and property mapping.

* refactor(analytics): move token info events onto the shared builders

TokenInfoEntry.Discovery, Chat and ChatGate used to report as
"Token Info: Opened From Wallet". They now send Opened From Discovery,
Chat and Chat Gate, so the Wallet count drops by what those three
entries carried. Deeplink and Wallet are unchanged. The mapping has no
else branch, so a new TokenInfoEntry fails to compile until it is mapped.

TokenInfoSource.Give and its event have had no caller since 6419a95
and are deleted.

* refactor(analytics): move buy and sell events onto the shared builders

SwapViewModel.trackTransaction now calls the generated SwapEvents.purchase
and SwapEvents.sell builders instead of the ad-hoc Analytics.buy/sell path,
dropping the local Analytics.SwapMethod/PurchaseMethod enums and the
TokenTransactionEvent sealed hierarchy they drove. Fee is sent as a decimal
(events.toml already defines it as `type = "decimal"`) instead of a string.

* refactor(analytics): move scan events onto the shared builders

Gallery scan (Scanner.kt), tip card scan (CodeScanDelegate) and tip card
present (TipCardDelegate) now call analytics.track(ScanEvents.*) instead
of the FlipcashAnalyticsService methods, which are deleted along with
their Events.kt classes and MixpanelAnalyticsDelegate wiring. Tier, Zoom
and Time go out as numbers and Exhausted as a flag, matching the shared
builder; Scanner.kt has no test harness so its three call sites are
reviewed by diff only.

CodeScanDelegateTest and TipCardDelegateTest now assert against
RecordingAnalytics with ScanEvents builders instead of verifying the
legacy methods.

* refactor(analytics): move deeplink events onto the shared builders

App.kt, Scanner.kt and CashLinkDelegate.kt track the DeeplinkEvents
builders instead of the legacy service methods. Two values change:

- Type comes from DeeplinkType.analytics, an explicit string per
  subclass, instead of javaClass.simpleName. The strings match the
  source class names, but no keep rule covers DeeplinkType, so a
  minified release build may have sent R8-renamed names until now.
- The parse-failure Error carries the URL without its query or
  fragment, which can hold secrets.

CashLinkDelegateTest asserts the routed event, with the type as a
string literal, on each early return and on success.

* refactor(analytics): move display name events onto the shared builders

Replaces FlipcashAnalyticsService.displayNameSubmitted(source, hadPreviousName)
with DisplayNameEvents.set/updated from the generated builder, called directly
from NameEntryViewModel. Deletes the old DisplayNameEvent.Set/Updated sealed
classes from Events.kt, the interface/stub method from Analytics.kt, and the
Mixpanel override, since nothing else referenced them.

NameEntryViewModel now takes a DispatcherProvider (wired to BaseViewModel's
defaultDispatcher) so its CheckName pipeline runs deterministically under a
test dispatcher, matching WalletViewModel's existing pattern; needed to cover
the branch through NameEntryViewModelTest with RecordingAnalytics.

* refactor(analytics): move error modal events onto the shared builders

NavMessagingEntryDecorator.kt tracks ErrorModalEvents.displayed instead
of the legacy displayedErrorModal method. Name, keys (Title, Message,
Screen, Call Site) and value types are unchanged; Screen and Call Site
still drop from the map when null, matching :libs:analytics-events'
ErrorModalEventsTest, which already pins that exact name and property
map. The decorator has no test harness, so the call site was reviewed
by diff against that existing builder test rather than given a new one.

Deletes displayedErrorModal from FlipcashAnalyticsService,
StubFlipcashAnalytics and MixpanelAnalyticsDelegate, and
ErrorModalDisplayed from Events.kt. No dead declarations in this
domain.

* refactor(analytics): move button and account events onto the shared builders

Button taps track ButtonEvents.tapped with the shared Button enum, and
the account actions and paidForAccount track AccountEvents. Every event
name is unchanged; Create Account Payment's Fiat goes out as a number.

Actions.kt is gone, along with Button.AllowCamera and Button.Sell, which
had no callers. Compose callers read the service through
rememberAnalytics(), since LocalAnalytics is typed as the base service
without track().

The login tests assert the tracked button events with RecordingAnalytics
instead of verifying action() on a mock.

* refactor(analytics): delete the legacy analytics service

Every caller now goes through FlipcashAnalytics.track/increment, so
FlipcashAnalyticsService, StubFlipcashAnalytics, Events.kt and
:libs:analytics have no users left. LocalAnalytics moves into the
Flipcash analytics module, typed as FlipcashAnalytics, with previews
providing FlipcashAnalytics.None.

The delegate's app-start trace went with the lifecycle hooks it lived in;
nothing called those hooks.

* test(chat): pin State: Failure on a failed chat send

code/cash left successful at its default on this path, so a failed Sent Cash / Sent Tip reported State: Success; this branch sends Failure and the test keeps it that way.

* refactor(analytics): move RecordingAnalytics into test fixtures

It sat in the main source set, so it shipped in the app and production
code could inject it. It now lives in the analytics module's
testFixtures, which the nine modules whose tests use it pull in with
testImplementation(testFixtures(...)), the same way :libs:coroutines and
:ui:resources share their fakes. The fixture compilation needs the
Compose BOM and ui on its classpath because the module applies the
Compose compiler.

* refactor(tipping): drop the unused analytics dependency from TippingCoordinator

TippingCoordinator took a FlipcashAnalytics it never called, both before
and after the track() migration. Remove the constructor parameter and the
module's dependency on :apps:flipcash:shared:analytics.

* test(messenger): run the chat send-failure test on the test dispatcher

ChatViewModel dispatched events on the real Dispatchers.Default, so
ChatSendFailureAnalyticsTest polled for up to 5s and could leave the send
handler running after the test returned. CI then failed
ReportViewModelTest, the next messenger test, with
UncaughtExceptionsBeforeTest, which is how kotlinx-coroutines-test reports
an exception thrown by an earlier test's leftover coroutine. It did not
reproduce locally.

Inject DispatcherProvider into ChatViewModel, as NameEntryViewModel does,
and pass the test's dispatcher so no work outlives the test. Production
still gets Dispatchers.Default.

Author: bmc08gt

apps/flipcash/app/src/main/kotlin/com/flipcash/app/MainActivity.kt

@@ -12,7 +12,7 @@ import androidx.fragment.app.FragmentActivity
 import androidx.lifecycle.lifecycleScope
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
-import com.flipcash.app.analytics.FlipcashAnalyticsService
+import com.flipcash.app.analytics.FlipcashAnalytics
 import com.flipcash.app.android.BuildConfig
 import com.flipcash.app.appsettings.AppSettingsCoordinator
 import com.flipcash.app.appsettings.LocalAppSettings
@@ -49,7 +49,7 @@ import com.flipcash.app.updates.AppUpdateController
 import com.flipcash.app.updates.LocalAppUpdater
 import com.flipcash.services.user.UserManager
 import com.flipcash.shared.tipping.TippingCoordinator
-import com.getcode.libs.analytics.LocalAnalytics
+import com.flipcash.app.analytics.LocalAnalytics
 import com.getcode.opencode.compose.LocalExchange
 import com.getcode.opencode.exchange.Exchange
 import com.getcode.ui.testing.LocalUiTesting
@@ -118,7 +118,7 @@ class MainActivity : FragmentActivity() {
     lateinit var featureFlagController: FeatureFlagController
 
     @Inject
-    lateinit var analytics: FlipcashAnalyticsService
+    lateinit var analytics: FlipcashAnalytics
 
     @Inject
     lateinit var phoneUtils: PhoneUtils
@@ -241,4 +241,4 @@ private fun Activity.handleUncaughtException() {
         killProcess(myPid())
         exitProcess(2)
     }
-}
+}

apps/flipcash/app/src/main/kotlin/com/flipcash/app/internal/ui/App.kt

@@ -37,7 +37,9 @@ import androidx.navigation3.runtime.NavBackStack
 import androidx.navigation3.runtime.NavKey
 import androidx.navigation3.scene.OverlayScene
 import androidx.navigation3.scene.SinglePaneSceneStrategy
+import com.flipcash.analytics.events.DeeplinkEvents
 import com.flipcash.app.analytics.rememberAnalytics
+import com.flipcash.app.analytics.withoutQueryOrFragment
 import com.flipcash.app.android.BuildConfig
 import com.flipcash.app.bill.customization.BillPlaygroundScaffold
 import com.flipcash.app.cardexpand.CardExpansionController
@@ -117,7 +119,7 @@ internal fun App(
     var deeplinkHandled by remember { mutableStateOf(false) }
     val userManager = LocalUserManager.current!!
     DeepLinkListener {
-        analytics.deeplinkOpened(it.data)
+        analytics.track(DeeplinkEvents.open(it.data.withoutQueryOrFragment()))
         deepLink = it
     }
 

apps/flipcash/app/src/main/kotlin/com/flipcash/app/internal/ui/navigation/decorators/NavMessagingEntryDecorator.kt

@@ -6,6 +6,7 @@ import androidx.compose.runtime.remember
 import androidx.navigation3.runtime.NavBackStack
 import androidx.navigation3.runtime.NavEntryDecorator
 import androidx.navigation3.runtime.NavKey
+import com.flipcash.analytics.events.ErrorModalEvents
 import com.flipcash.app.analytics.rememberAnalytics
 import com.flipcash.app.core.AppRoute
 import com.getcode.manager.BottomBarManager
@@ -46,11 +47,13 @@ fun NavMessagingEntryDecorator(
                         BottomBarManager.BottomBarMessageType.DESTRUCTIVE -> Unit
                         BottomBarManager.BottomBarMessageType.ERROR -> {
                             val screen = backStack.lastOrNull()?.screenName()
-                            analytics.displayedErrorModal(
-                                title = message.title,
-                                message = message.subtitle,
-                                screen = screen,
-                                callSite = message.callSite,
+                            analytics.track(
+                                ErrorModalEvents.displayed(
+                                    title = message.title,
+                                    message = message.subtitle,
+                                    screen = screen,
+                                    callSite = message.callSite,
+                                )
                             )
                         }
                         BottomBarManager.BottomBarMessageType.WARNING -> Unit

apps/flipcash/features/balance/build.gradle.kts

@@ -15,6 +15,7 @@ dependencies {
 
     implementation(project(":apps:flipcash:shared:transaction-history"))
     implementation(project(":apps:flipcash:shared:analytics"))
+    testImplementation(testFixtures(project(":apps:flipcash:shared:analytics")))
     implementation(project(":apps:flipcash:shared:chat"))
     implementation(project(":apps:flipcash:shared:featureflags"))
     implementation(project(":apps:flipcash:shared:funding"))

apps/flipcash/features/balance/src/main/kotlin/com/flipcash/app/balance/internal/WalletViewModel.kt

@@ -1,8 +1,9 @@
 package com.flipcash.app.balance.internal
 
 import androidx.lifecycle.viewModelScope
-import com.flipcash.app.analytics.Analytics
-import com.flipcash.app.analytics.FlipcashAnalyticsService
+import com.flipcash.analytics.AddMoneySource
+import com.flipcash.analytics.events.AddMoneyEvents
+import com.flipcash.app.analytics.FlipcashAnalytics
 import com.flipcash.app.core.ui.onboarding.TutorialItem
 import com.flipcash.app.core.AppRoute
 import com.flipcash.shared.transactionhistory.ActivityFeedCoordinator
@@ -35,7 +36,7 @@ internal class WalletViewModel @Inject constructor(
     userFlags: UserFlagsCoordinator,
     dispatchers: DispatcherProvider,
     purchaseMethodController: PurchaseMethodController,
-    analytics: FlipcashAnalyticsService,
+    analytics: FlipcashAnalytics,
     chatCoordinator: ChatCoordinator,
     feedCoordinator: ActivityFeedCoordinator,
     tokenCoordinator: TokenCoordinator,
@@ -176,7 +177,7 @@ internal class WalletViewModel @Inject constructor(
         eventFlow
             .filterIsInstance<Event.PresentDepositOptions>()
             .mapNotNull {
-                analytics.addMoneyOpened(Analytics.AddMoneySource.Balance)
+                analytics.track(AddMoneyEvents.opened(AddMoneySource.BALANCE))
                 purchaseMethodController.presentDepositOptions(popToRoot = true) }
             .onEach { route -> dispatchEvent(Event.OpenScreen(route)) }
             .launchIn(viewModelScope)
@@ -243,4 +244,4 @@ internal class WalletViewModel @Inject constructor(
             }
         }
     }
-}
+}

apps/flipcash/features/balance/src/test/kotlin/com/flipcash/app/balance/internal/BalanceViewModelTest.kt

@@ -1,7 +1,9 @@
 package com.flipcash.app.balance.internal
 
 import androidx.arch.core.executor.testing.InstantTaskExecutorRule
-import com.flipcash.app.analytics.StubFlipcashAnalytics
+import com.flipcash.analytics.AddMoneySource
+import com.flipcash.analytics.events.AddMoneyEvents
+import com.flipcash.app.analytics.RecordingAnalytics
 import com.flipcash.app.core.AppRoute
 import com.flipcash.app.core.MainCoroutineRule
 import com.flipcash.app.core.dispatchers.TestDispatchers
@@ -55,14 +57,16 @@ class BalanceViewModelTest {
         every { pending } returns MutableStateFlow(null)
     }
 
+    private val analytics = RecordingAnalytics()
+
     private lateinit var dispatchers: TestDispatchers
 
     private fun createViewModel() = WalletViewModel(
         userManager = userManager,
         userFlags = userFlags,
         dispatchers = dispatchers,
         purchaseMethodController = purchaseMethodController,
-        analytics = StubFlipcashAnalytics(),
+        analytics = analytics,
         chatCoordinator = chatCoordinator,
         feedCoordinator = feedCoordinator,
         tokenCoordinator = tokenCoordinator,
@@ -83,6 +87,7 @@ class BalanceViewModelTest {
             // The removed AddMoneyUX flag used to short-circuit to a plain Deposit route;
             // the add-money sheet must now always be presented.
             coVerify(exactly = 1) { purchaseMethodController.presentDepositOptions(popToRoot = true) }
+            assertEquals(listOf(AddMoneyEvents.opened(AddMoneySource.BALANCE)), analytics.events)
         }
 
     @Test

apps/flipcash/features/balance/src/test/kotlin/com/flipcash/app/balance/internal/WalletMilestoneGatingTest.kt

@@ -1,7 +1,7 @@
 package com.flipcash.app.balance.internal
 
 import androidx.arch.core.executor.testing.InstantTaskExecutorRule
-import com.flipcash.app.analytics.StubFlipcashAnalytics
+import com.flipcash.app.analytics.FlipcashAnalytics
 import com.flipcash.app.core.ui.onboarding.TutorialItem
 import com.flipcash.app.core.MainCoroutineRule
 import com.flipcash.app.core.dispatchers.TestDispatchers
@@ -67,7 +67,7 @@ class WalletMilestoneGatingTest {
         userFlags = mockk<UserFlagsCoordinator>(relaxed = true),
         dispatchers = dispatchers,
         purchaseMethodController = mockk<PurchaseMethodController>(relaxed = true),
-        analytics = StubFlipcashAnalytics(),
+        analytics = FlipcashAnalytics.None,
         chatCoordinator = chatCoordinator,
         feedCoordinator = feedCoordinator,
         tokenCoordinator = tokenCoordinator,

apps/flipcash/features/cash/build.gradle.kts

@@ -16,6 +16,7 @@ dependencies {
     implementation(libs.kotlin.stdlib)
     implementation(project(":apps:flipcash:shared:amount-entry"))
     implementation(project(":apps:flipcash:shared:analytics"))
+    testImplementation(testFixtures(project(":apps:flipcash:shared:analytics")))
     implementation(project(":apps:flipcash:shared:featureflags"))
     implementation(project(":apps:flipcash:shared:session"))
     implementation(project(":apps:flipcash:shared:tokens"))

apps/flipcash/features/cash/src/main/kotlin/com/flipcash/app/cash/internal/CashScreenViewModel.kt

@@ -1,8 +1,9 @@
 package com.flipcash.app.cash.internal
 
 import androidx.lifecycle.viewModelScope
-import com.flipcash.app.analytics.Analytics
-import com.flipcash.app.analytics.FlipcashAnalyticsService
+import com.flipcash.analytics.AddMoneySource
+import com.flipcash.analytics.events.AddMoneyEvents
+import com.flipcash.app.analytics.FlipcashAnalytics
 import com.flipcash.app.core.AppRoute
 import com.flipcash.app.core.bill.Scannable
 import com.flipcash.app.core.tokens.SwapPurpose
@@ -58,7 +59,7 @@ internal class CashScreenViewModel @Inject constructor(
     private val verifiedFiatCalculator: VerifiedFiatCalculator,
     tokenCoordinator: TokenCoordinator,
     transactionController: TransactionOperations,
-    analytics: FlipcashAnalyticsService,
+    analytics: FlipcashAnalytics,
     dispatchers: DispatcherProvider,
 ) : BaseViewModel<CashScreenViewModel.State, CashScreenViewModel.Event>(
     initialState = State(),
@@ -289,7 +290,7 @@ internal class CashScreenViewModel @Inject constructor(
                 // route directly to the swap amount screen, skipping token info
                 val mint = stateFlow.value.selectedTokenAddress!!
                 if (mint == Mint.usdf) {
-                    analytics.addMoneyOpened(Analytics.AddMoneySource.GiveShortfall)
+                    analytics.track(AddMoneyEvents.opened(AddMoneySource.GIVE_SHORTFALL))
                 }
                 dispatchEvent(
                     Event.OpenScreen(
@@ -340,4 +341,4 @@ internal class CashScreenViewModel @Inject constructor(
             }
         }
     }
-}
+}

apps/flipcash/features/cash/src/test/kotlin/com/flipcash/app/cash/internal/CashScreenViewModelTest.kt

@@ -1,7 +1,9 @@
 package com.flipcash.app.cash.internal
 
 import androidx.arch.core.executor.testing.InstantTaskExecutorRule
-import com.flipcash.app.analytics.StubFlipcashAnalytics
+import com.flipcash.analytics.AddMoneySource
+import com.flipcash.analytics.events.AddMoneyEvents
+import com.flipcash.app.analytics.RecordingAnalytics
 import com.flipcash.app.core.MainCoroutineRule
 import com.flipcash.app.core.dispatchers.TestDispatchers
 import com.flipcash.app.tokens.TokenCoordinator
@@ -51,6 +53,8 @@ class CashScreenViewModelTest {
     private val tokenCoordinator: TokenCoordinator = mockk(relaxed = true)
     private val transactionController: TransactionOperations = mockk(relaxed = true)
 
+    private val analytics = RecordingAnalytics()
+
     private lateinit var dispatchers: TestDispatchers
 
     private val updateStateForEvent = CashScreenViewModel.updateStateForEvent
@@ -79,7 +83,7 @@ class CashScreenViewModelTest {
             verifiedFiatCalculator = verifiedFiatCalculator,
             tokenCoordinator = tokenCoordinator,
             transactionController = transactionController,
-            analytics = StubFlipcashAnalytics(),
+            analytics = analytics,
             dispatchers = dispatchers,
         )
     }
@@ -266,4 +270,26 @@ class CashScreenViewModelTest {
             val result = vm.checkSendLimit()
             assertFalse(result, "checkSendLimit should return false when amount is within limit")
         }
+
+    @Test
+    fun `a USDF shortfall tracks Add Money Opened from Give Shortfall`() = runTest(mainCoroutineRule.dispatcher) {
+        dispatchers = TestDispatchers(testScheduler)
+        val vm = createViewModel()
+        vm.dispatchEvent(CashScreenViewModel.Event.OnTokenSelected(Mint.usdf))
+        vm.dispatchEvent(CashScreenViewModel.Event.AddCashToWallet(Fiat(5.0)))
+        advanceUntilIdle()
+
+        assertEquals(listOf(AddMoneyEvents.opened(AddMoneySource.GIVE_SHORTFALL)), analytics.events)
+    }
+
+    @Test
+    fun `a shortfall in another token tracks nothing`() = runTest(mainCoroutineRule.dispatcher) {
+        dispatchers = TestDispatchers(testScheduler)
+        val vm = createViewModel()
+        vm.dispatchEvent(CashScreenViewModel.Event.OnTokenSelected(Mint("kinXdEcpDQeHPEuQnqmUgtYykqKGVFq6CeVX5iAHJq6")))
+        vm.dispatchEvent(CashScreenViewModel.Event.AddCashToWallet(Fiat(5.0)))
+        advanceUntilIdle()
+
+        assertTrue(analytics.events.isEmpty())
+    }
 }