test: remove LoggingKt static mocks and fix stale onramp tests

trace() now no-ops before initialization, so mockkStatic(LoggingKt)
is no longer needed. Removed from all 19 test files.

Also fixed OnRampControllerTest (removed stale useSandbox param,
added featureFlags dep, updated validation order to match production)
and CoinbaseOnRampEventHandlerTest (commit_success is now skipped).

Author: bmc08gt

apps/flipcash/features/cash/src/test/kotlin/com/flipcash/app/cash/internal/CashScreenViewModelTest.kt

@@ -26,8 +26,6 @@ import com.getcode.util.resources.ResourceHelper
 import com.getcode.view.LoadingSuccessState
 import io.mockk.every
 import io.mockk.mockk
-import io.mockk.mockkStatic
-import io.mockk.unmockkStatic
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.flow.MutableStateFlow
 import kotlinx.coroutines.flow.emptyFlow
@@ -66,8 +64,6 @@ class CashScreenViewModelTest {
     @Before
     fun setUp() {
         BottomBarManager.clear()
-        mockkStatic("com.getcode.utils.LoggingKt")
-        every { com.getcode.utils.trace(any(), any(), any(), any(), any()) } returns Unit
 
         // Stub resource strings used by the ViewModel
         every { resources.getString(R.string.error_title_youNeedMoreCash) } returns "error_title_youNeedMoreCash"
@@ -88,7 +84,6 @@ class CashScreenViewModelTest {
     @After
     fun tearDown() {
         BottomBarManager.clear()
-        unmockkStatic("com.getcode.utils.LoggingKt")
     }
 
     private fun createViewModel(): CashScreenViewModel {

apps/flipcash/features/contact-verification/src/test/kotlin/com/flipcash/app/contact/verification/internal/email/EmailVerificationViewModelErrorTest.kt

@@ -10,8 +10,6 @@ import com.flipcash.app.core.MainCoroutineRule
 import com.flipcash.app.core.dispatchers.TestDispatchers
 import io.mockk.every
 import io.mockk.mockk
-import io.mockk.mockkStatic
-import io.mockk.unmockkStatic
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.test.UnconfinedTestDispatcher
 import kotlinx.coroutines.test.advanceUntilIdle
@@ -41,8 +39,6 @@ class EmailVerificationViewModelErrorTest {
     @Before
     fun setUp() {
         BottomBarManager.clear()
-        mockkStatic("com.getcode.utils.LoggingKt")
-        every { com.getcode.utils.trace(any(), any(), any(), any(), any()) } returns Unit
 
         every { resources.getString(R.string.error_title_failedToSendCodeToEmail) } returns "error_title_failedToSendCodeToEmail"
         every { resources.getString(R.string.error_description_failedToSendCodeToEmail) } returns "error_description_failedToSendCodeToEmail"
@@ -61,7 +57,6 @@ class EmailVerificationViewModelErrorTest {
     @After
     fun tearDown() {
         BottomBarManager.clear()
-        unmockkStatic("com.getcode.utils.LoggingKt")
     }
 
     private fun createViewModel(): EmailVerificationViewModel {

apps/flipcash/features/contact-verification/src/test/kotlin/com/flipcash/app/contact/verification/internal/phone/PhoneVerificationViewModelErrorTest.kt

@@ -11,8 +11,6 @@ import com.flipcash.app.core.MainCoroutineRule
 import com.flipcash.app.core.dispatchers.TestDispatchers
 import io.mockk.every
 import io.mockk.mockk
-import io.mockk.mockkStatic
-import io.mockk.unmockkStatic
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.test.UnconfinedTestDispatcher
 import kotlinx.coroutines.test.advanceUntilIdle
@@ -43,8 +41,6 @@ class PhoneVerificationViewModelErrorTest {
     @Before
     fun setUp() {
         BottomBarManager.clear()
-        mockkStatic("com.getcode.utils.LoggingKt")
-        every { com.getcode.utils.trace(any(), any(), any(), any(), any()) } returns Unit
 
         every { resources.getString(R.string.error_title_failedToSendCodeToPhone) } returns "error_title_failedToSendCodeToPhone"
         every { resources.getString(R.string.error_description_failedToSendCodeToPhone) } returns "error_description_failedToSendCodeToPhone"
@@ -59,7 +55,6 @@ class PhoneVerificationViewModelErrorTest {
     @After
     fun tearDown() {
         BottomBarManager.clear()
-        unmockkStatic("com.getcode.utils.LoggingKt")
     }
 
     private fun createViewModel(): PhoneVerificationViewModel {

apps/flipcash/features/login/src/test/kotlin/com/flipcash/app/login/router/LoginViewModelErrorTest.kt

@@ -47,8 +47,6 @@ class LoginViewModelErrorTest {
     @Before
     fun setUp() {
         BottomBarManager.clear()
-        mockkStatic("com.getcode.utils.LoggingKt")
-        every { com.getcode.utils.trace(any(), any(), any(), any(), any()) } returns Unit
         // android.util.Base64 is stubbed in unit tests; mock it so encodeBase64() doesn't NPE
         mockkStatic(android.util.Base64::class)
         every { android.util.Base64.encodeToString(any(), any()) } answers { java.util.Base64.getEncoder().encodeToString(firstArg()) }
@@ -61,7 +59,6 @@ class LoginViewModelErrorTest {
     @After
     fun tearDown() {
         BottomBarManager.clear()
-        unmockkStatic("com.getcode.utils.LoggingKt")
         unmockkStatic(android.util.Base64::class)
     }
 

apps/flipcash/features/transactions/src/test/kotlin/com/flipcash/app/transactions/internal/TransactionHistoryViewModelErrorTest.kt

@@ -14,8 +14,6 @@ import com.flipcash.app.core.MainCoroutineRule
 import com.flipcash.app.core.dispatchers.TestDispatchers
 import io.mockk.every
 import io.mockk.mockk
-import io.mockk.mockkStatic
-import io.mockk.unmockkStatic
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.test.UnconfinedTestDispatcher
 import kotlinx.coroutines.test.advanceUntilIdle
@@ -50,8 +48,6 @@ class TransactionHistoryViewModelErrorTest {
     @Before
     fun setUp() {
         BottomBarManager.clear()
-        mockkStatic("com.getcode.utils.LoggingKt")
-        every { com.getcode.utils.trace(any(), any(), any(), any(), any()) } returns Unit
 
         every { userManager.accountCluster } returns accountCluster
         every { resources.getString(R.string.error_title_failedToCancelTransfer) } returns "error_title_failedToCancelTransfer"
@@ -61,7 +57,6 @@ class TransactionHistoryViewModelErrorTest {
     @After
     fun tearDown() {
         BottomBarManager.clear()
-        unmockkStatic("com.getcode.utils.LoggingKt")
     }
 
     private fun createViewModel(): TransactionHistoryViewModel {

apps/flipcash/features/withdrawal/src/test/kotlin/com/flipcash/app/withdrawal/WithdrawalViewModelErrorTest.kt

@@ -14,8 +14,6 @@ import com.flipcash.app.core.MainCoroutineRule
 import com.flipcash.app.core.dispatchers.TestDispatchers
 import io.mockk.every
 import io.mockk.mockk
-import io.mockk.mockkStatic
-import io.mockk.unmockkStatic
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.test.UnconfinedTestDispatcher
 import kotlinx.coroutines.test.advanceUntilIdle
@@ -46,8 +44,6 @@ class WithdrawalViewModelErrorTest {
     @Before
     fun setUp() {
         BottomBarManager.clear()
-        mockkStatic("com.getcode.utils.LoggingKt")
-        every { com.getcode.utils.trace(any(), any(), any(), any(), any()) } returns Unit
 
         every { resources.getString(R.string.error_title_failedWithdrawal) } returns "error_title_failedWithdrawal"
         every { resources.getString(R.string.error_description_failedWithdrawal) } returns "error_description_failedWithdrawal"
@@ -56,7 +52,6 @@ class WithdrawalViewModelErrorTest {
     @After
     fun tearDown() {
         BottomBarManager.clear()
-        unmockkStatic("com.getcode.utils.LoggingKt")
     }
 
     private fun createViewModel(): WithdrawalViewModel {

apps/flipcash/shared/authentication/src/test/kotlin/com/flipcash/app/auth/AuthManagerTest.kt

@@ -17,8 +17,6 @@ import io.mockk.coEvery
 import io.mockk.coVerify
 import io.mockk.every
 import io.mockk.mockk
-import io.mockk.mockkStatic
-import io.mockk.unmockkStatic
 import io.mockk.verify
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.ExperimentalCoroutinesApi
@@ -59,8 +57,6 @@ class AuthManagerTest {
     @Before
     fun setUp() {
         Dispatchers.setMain(testDispatcher)
-        mockkStatic("com.getcode.utils.LoggingKt")
-        every { com.getcode.utils.trace(any(), any(), any(), any(), any()) } returns Unit
 
         coEvery { pushTokenProvider.getToken() } returns "fake-token"
 
@@ -88,7 +84,6 @@ class AuthManagerTest {
     @After
     fun tearDown() {
         Dispatchers.resetMain()
-        unmockkStatic("com.getcode.utils.LoggingKt")
     }
 
     @Test

apps/flipcash/shared/onramp/coinbase/src/test/kotlin/com/flipcash/app/onramp/OnRampControllerTest.kt

@@ -2,17 +2,24 @@ package com.flipcash.app.onramp
 
 import com.coinbase.onramp.api.CoinbaseApi
 import com.coinbase.onramp.data.OnRampApiConfig
+import com.flipcash.app.featureflags.FeatureFlagController
 import com.flipcash.services.models.UserProfile
 import com.flipcash.services.user.UserManager
 import com.getcode.opencode.exchange.Exchange
+import com.getcode.opencode.internal.solana.extensions.timelockSwapAccounts
 import com.getcode.opencode.model.accounts.AccountCluster
 import com.getcode.opencode.model.financial.CurrencyCode
 import com.getcode.opencode.model.financial.Fiat
+import com.getcode.opencode.model.financial.Token
+import com.getcode.opencode.model.financial.usdf
 import com.getcode.solana.keys.PublicKey
 import io.mockk.every
 import io.mockk.mockk
+import io.mockk.mockkStatic
+import io.mockk.unmockkStatic
 import kotlinx.coroutines.ExperimentalCoroutinesApi
 import kotlinx.coroutines.test.runTest
+import org.junit.After
 import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
@@ -30,45 +37,56 @@ class OnRampControllerTest {
     private val api = mockk<CoinbaseApi>(relaxed = true)
     private val userManager = mockk<UserManager>(relaxed = true)
     private val exchange = mockk<Exchange>(relaxed = true)
+    private val featureFlags = mockk<FeatureFlagController>(relaxed = true)
 
     private val onRampApiEndpoint = OnRampApiConfig(
         scheme = "https",
         host = "api.example.com",
         path = "onramp/v1/buy",
         method = "POST",
-        useSandbox = false,
     )
 
     private lateinit var controller: OnRampController
 
     @Before
     fun setUp() {
+        // Token.usdf triggers Ed25519 native lib via deriveVirtualMachineAccount;
+        // mock the extension property and timelockSwapAccounts to avoid the native call
+        mockkStatic("com.getcode.opencode.model.financial.MintMetadataKt")
+        mockkStatic("com.getcode.opencode.internal.solana.extensions.TokenKt")
+        val fakeToken = mockk<Token>(relaxed = true)
+        every { Token.usdf } returns fakeToken
+        every { fakeToken.timelockSwapAccounts(any()) } returns mockk(relaxed = true)
+
         controller = OnRampController(
             jwtProvider = jwtProvider,
             onRampApiEndpoint = onRampApiEndpoint,
             api = api,
             userManager = userManager,
             exchange = exchange,
+            featureFlags = featureFlags,
         )
     }
 
-    private fun stubAccountId(present: Boolean = true) {
+    @After
+    fun tearDown() {
+        unmockkStatic("com.getcode.opencode.model.financial.MintMetadataKt")
+        unmockkStatic("com.getcode.opencode.internal.solana.extensions.TokenKt")
+    }
+
+    private fun stubAccountCluster(present: Boolean = true) {
         if (present) {
-            every { userManager.accountId } returns listOf(1, 2, 3, 4).map { it.toByte() }
+            every { userManager.accountCluster } returns mockk<AccountCluster>(relaxed = true)
         } else {
-            every { userManager.accountId } returns null
+            every { userManager.accountCluster } returns null
         }
     }
 
-    private fun stubDepositAddress(present: Boolean = true) {
+    private fun stubAccountId(present: Boolean = true) {
         if (present) {
-            val address = PublicKey(ByteArray(32).toList())
-            val cluster = mockk<AccountCluster>(relaxed = true) {
-                every { usdfDepositAddress } returns address
-            }
-            every { userManager.accountCluster } returns cluster
+            every { userManager.accountId } returns listOf(1, 2, 3, 4).map { it.toByte() }
         } else {
-            every { userManager.accountCluster } returns null
+            every { userManager.accountId } returns null
         }
     }
 
@@ -83,39 +101,39 @@ class OnRampControllerTest {
     }
 
     private fun stubValidUser() {
+        stubAccountCluster()
         stubAccountId()
-        stubDepositAddress()
         stubProfile()
     }
 
     // region placeOrderInclusiveOfFees validation
 
     @Test
-    fun `placeOrderInclusiveOfFees fails when accountId is null`() = runTest {
-        stubAccountId(present = false)
-        stubDepositAddress()
+    fun `placeOrderInclusiveOfFees fails when owner is null`() = runTest {
+        stubAccountCluster(present = false)
+        stubAccountId()
         stubProfile()
 
         val result = controller.placeOrderInclusiveOfFees(Fiat(10, CurrencyCode.USD))
         assertTrue(result.isFailure)
-        assertTrue(result.exceptionOrNull()?.message?.contains("User ID") == true)
+        assertTrue(result.exceptionOrNull()?.message?.contains("Owner") == true)
     }
 
     @Test
-    fun `placeOrderInclusiveOfFees fails when deposit address is null`() = runTest {
-        stubAccountId()
-        stubDepositAddress(present = false)
+    fun `placeOrderInclusiveOfFees fails when accountId is null`() = runTest {
+        stubAccountCluster()
+        stubAccountId(present = false)
         stubProfile()
 
         val result = controller.placeOrderInclusiveOfFees(Fiat(10, CurrencyCode.USD))
         assertTrue(result.isFailure)
-        assertTrue(result.exceptionOrNull()?.message?.contains("Deposit address") == true)
+        assertTrue(result.exceptionOrNull()?.message?.contains("User ID") == true)
     }
 
     @Test
     fun `placeOrderInclusiveOfFees fails when email is null`() = runTest {
+        stubAccountCluster()
         stubAccountId()
-        stubDepositAddress()
         stubProfile(email = null, phone = "+11234567890")
 
         val result = controller.placeOrderInclusiveOfFees(Fiat(10, CurrencyCode.USD))
@@ -126,8 +144,8 @@ class OnRampControllerTest {
 
     @Test
     fun `placeOrderInclusiveOfFees fails when phone is null`() = runTest {
+        stubAccountCluster()
         stubAccountId()
-        stubDepositAddress()
         stubProfile(email = "test@test.com", phone = null)
 
         val result = controller.placeOrderInclusiveOfFees(Fiat(10, CurrencyCode.USD))
@@ -138,8 +156,8 @@ class OnRampControllerTest {
 
     @Test
     fun `placeOrderInclusiveOfFees returns VerificationRequired with correct flags`() = runTest {
+        stubAccountCluster()
         stubAccountId()
-        stubDepositAddress()
         stubProfile(email = null, phone = null)
 
         val result = controller.placeOrderInclusiveOfFees(Fiat(10, CurrencyCode.USD))
@@ -156,8 +174,8 @@ class OnRampControllerTest {
 
     @Test
     fun `placeOrderExclusiveOfFees fails when accountId is null`() = runTest {
+        stubAccountCluster()
         stubAccountId(present = false)
-        stubDepositAddress()
         stubProfile()
 
         val result = controller.placeOrderExclusiveOfFees(Fiat(10, CurrencyCode.USD))
@@ -177,8 +195,8 @@ class OnRampControllerTest {
 
     @Test
     fun `placeOrderExclusiveOfFees fails when email and phone both null`() = runTest {
+        stubAccountCluster()
         stubAccountId()
-        stubDepositAddress()
         stubProfile(email = null, phone = null)
 
         val result = controller.placeOrderExclusiveOfFees(Fiat(10, CurrencyCode.USD))

apps/flipcash/shared/onramp/coinbase/src/test/kotlin/com/flipcash/app/onramp/internal/CoinbaseOnRampEventHandlerTest.kt

@@ -1,10 +1,5 @@
 package com.flipcash.app.onramp.internal
 
-import io.mockk.every
-import io.mockk.mockkStatic
-import io.mockk.unmockkStatic
-import org.junit.After
-import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
 import org.robolectric.RobolectricTestRunner
@@ -19,17 +14,6 @@ import kotlin.test.assertTrue
 @Config(manifest = Config.NONE)
 class CoinbaseOnRampEventHandlerTest {
 
-    @Before
-    fun setUp() {
-        mockkStatic("com.getcode.utils.LoggingKt")
-        every { com.getcode.utils.trace(any(), any(), any(), any(), any()) } returns Unit
-    }
-
-    @After
-    fun tearDown() {
-        unmockkStatic("com.getcode.utils.LoggingKt")
-    }
-
     private var successCount = 0
     private var cancelCount = 0
     private var autoClickCount = 0
@@ -52,9 +36,9 @@ class CoinbaseOnRampEventHandlerTest {
     }
 
     @Test
-    fun commitSuccessTriggersPaymentSuccess() {
+    fun commitSuccessIsExplicitlySkipped() {
         handler.handleEvent("""{"eventName":"onramp_api.commit_success"}""")
-        assertEquals(1, successCount)
+        assertEquals(0, successCount, "commit_success should not trigger onPaymentSuccess")
     }
 
     @Test