chore: make ViewModels testable; add error validation tests for all vm's

Signed-off-by: Brandon McAnsh <git@bmcreations.dev>

Author: bmc08gt

apps/flipcash/app/src/main/kotlin/com/flipcash/app/inject/DispatcherModule.kt

@@ -0,0 +1,18 @@
+package com.flipcash.app.inject
+
+import com.flipcash.libs.coroutines.DispatcherProvider
+import com.flipcash.app.internal.dispatchers.DefaultDispatcherProvider
+import dagger.Module
+import dagger.Provides
+import dagger.hilt.InstallIn
+import dagger.hilt.components.SingletonComponent
+import javax.inject.Singleton
+
+@Module
+@InstallIn(SingletonComponent::class)
+object DispatcherModule {
+
+    @Provides
+    @Singleton
+    fun providesDispatcherProvider(): DispatcherProvider = DefaultDispatcherProvider()
+}

apps/flipcash/app/src/main/kotlin/com/flipcash/app/internal/dispatchers/DefaultDispatcherProvider.kt

@@ -0,0 +1,11 @@
+package com.flipcash.app.internal.dispatchers
+
+import com.flipcash.libs.coroutines.DispatcherProvider
+import kotlinx.coroutines.CoroutineDispatcher
+import kotlinx.coroutines.Dispatchers
+
+class DefaultDispatcherProvider : DispatcherProvider {
+    override val Default: CoroutineDispatcher = Dispatchers.Default
+    override val Main: CoroutineDispatcher = Dispatchers.Main
+    override val IO: CoroutineDispatcher = Dispatchers.IO
+}

apps/flipcash/core/build.gradle.kts

@@ -7,6 +7,9 @@ android {
 }
 
 dependencies {
+    testImplementation(kotlin("test"))
+    testImplementation(libs.bundles.unit.testing)
+
     implementation(libs.androidx.browser)
 
     implementation(libs.kotlinx.serialization.core)

apps/flipcash/core/src/test/kotlin/com/flipcash/app/core/MainCoroutineRule.kt

@@ -0,0 +1,24 @@
+package com.flipcash.app.core
+
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.ExperimentalCoroutinesApi
+import kotlinx.coroutines.test.StandardTestDispatcher
+import kotlinx.coroutines.test.TestDispatcher
+import kotlinx.coroutines.test.resetMain
+import kotlinx.coroutines.test.setMain
+import org.junit.rules.TestWatcher
+import org.junit.runner.Description
+
+@OptIn(ExperimentalCoroutinesApi::class)
+class MainCoroutineRule(
+    val dispatcher: TestDispatcher = StandardTestDispatcher()
+) : TestWatcher() {
+
+    override fun starting(description: Description) {
+        Dispatchers.setMain(dispatcher)
+    }
+
+    override fun finished(description: Description) {
+        Dispatchers.resetMain()
+    }
+}

apps/flipcash/core/src/test/kotlin/com/flipcash/app/core/dispatchers/TestDispatcherProvider.kt

@@ -0,0 +1,14 @@
+package com.flipcash.app.core.dispatchers
+
+import com.flipcash.libs.coroutines.DispatcherProvider
+import kotlinx.coroutines.CoroutineDispatcher
+import kotlinx.coroutines.test.StandardTestDispatcher
+import kotlinx.coroutines.test.TestDispatcher
+
+class TestDispatcherProvider(
+    val testDispatcher: TestDispatcher = StandardTestDispatcher()
+) : DispatcherProvider {
+    override val Default: CoroutineDispatcher get() = testDispatcher
+    override val Main: CoroutineDispatcher get() = testDispatcher
+    override val IO: CoroutineDispatcher get() = testDispatcher
+}

apps/flipcash/core/src/test/kotlin/com/flipcash/app/core/time/FakeTimeProviderTest.kt

@@ -0,0 +1,69 @@
+package com.flipcash.app.core.time
+
+import org.junit.Test
+import kotlin.test.assertEquals
+import kotlin.time.Duration.Companion.milliseconds
+import kotlin.time.Duration.Companion.minutes
+import kotlin.time.Duration.Companion.seconds
+import kotlin.time.Instant
+
+class FakeTimeProviderTest {
+
+    @Test
+    fun `now returns start time initially`() {
+        val startTime = Instant.fromEpochMilliseconds(1_000_000L)
+        val provider = FakeTimeProvider(startTime)
+
+        assertEquals(startTime, provider.now())
+    }
+
+    @Test
+    fun `currentTimeMillis returns epoch millis of now`() {
+        val startTime = Instant.fromEpochMilliseconds(1_000_000L)
+        val provider = FakeTimeProvider(startTime)
+
+        assertEquals(1_000_000L, provider.currentTimeMillis())
+    }
+
+    @Test
+    fun `advanceBy moves time forward`() {
+        val startTime = Instant.fromEpochMilliseconds(0L)
+        val provider = FakeTimeProvider(startTime)
+
+        provider.advanceBy(5.seconds)
+
+        assertEquals(5_000L, provider.currentTimeMillis())
+    }
+
+    @Test
+    fun `advanceBy accumulates across multiple calls`() {
+        val startTime = Instant.fromEpochMilliseconds(0L)
+        val provider = FakeTimeProvider(startTime)
+
+        provider.advanceBy(1.minutes)
+        provider.advanceBy(30.seconds)
+
+        assertEquals(90_000L, provider.currentTimeMillis())
+    }
+
+    @Test
+    fun `setTime overrides current time`() {
+        val provider = FakeTimeProvider(Instant.fromEpochMilliseconds(0L))
+        val newTime = Instant.fromEpochMilliseconds(999_999L)
+
+        provider.setTime(newTime)
+
+        assertEquals(newTime, provider.now())
+        assertEquals(999_999L, provider.currentTimeMillis())
+    }
+
+    @Test
+    fun `advanceBy works after setTime`() {
+        val provider = FakeTimeProvider(Instant.fromEpochMilliseconds(0L))
+
+        provider.setTime(Instant.fromEpochMilliseconds(10_000L))
+        provider.advanceBy(500.milliseconds)
+
+        assertEquals(10_500L, provider.currentTimeMillis())
+    }
+}

apps/flipcash/features/advanced/src/main/kotlin/com/flipcash/app/advanced/internal/AdvancedFeaturesScreenViewModel.kt

@@ -7,6 +7,7 @@ import com.flipcash.app.featureflags.FeatureFlagController
 import com.flipcash.app.menu.MenuItem
 import com.flipcash.services.user.UserManager
 import com.getcode.util.resources.ResourceHelper
+import com.flipcash.libs.coroutines.DispatcherProvider
 import com.getcode.view.BaseViewModel2
 import dagger.hilt.android.lifecycle.HiltViewModel
 import kotlinx.coroutines.flow.combine
@@ -24,9 +25,11 @@ private val FullMenuList = buildList {
 internal class AdvancedFeaturesScreenViewModel @Inject constructor(
     userManager: UserManager,
     featureFlagController: FeatureFlagController,
+    dispatchers: DispatcherProvider,
 ) : BaseViewModel2<AdvancedFeaturesScreenViewModel.State, AdvancedFeaturesScreenViewModel.Event>(
     initialState = State(),
-    updateStateForEvent = updateStateForEvent
+    updateStateForEvent = updateStateForEvent,
+    defaultDispatcher = dispatchers.Default,
 ) {
     data class State(
         val isBetaEnabled: Boolean = false,

apps/flipcash/features/balance/src/main/kotlin/com/flipcash/app/balance/internal/BalanceViewModel.kt

@@ -5,6 +5,7 @@ import com.flipcash.app.core.AppRoute
 import com.flipcash.services.internal.model.thirdparty.OnRampProvider
 import com.flipcash.services.user.AuthState
 import com.flipcash.services.user.UserManager
+import com.flipcash.libs.coroutines.DispatcherProvider
 import com.getcode.view.BaseViewModel2
 import dagger.hilt.android.lifecycle.HiltViewModel
 import kotlinx.coroutines.flow.filter
@@ -17,9 +18,11 @@ import javax.inject.Inject
 @HiltViewModel
 internal class BalanceViewModel @Inject constructor(
     userManager: UserManager,
+    dispatchers: DispatcherProvider,
 ) : BaseViewModel2<BalanceViewModel.State, BalanceViewModel.Event>(
     initialState = State(),
-    updateStateForEvent = updateStateForEvent
+    updateStateForEvent = updateStateForEvent,
+    defaultDispatcher = dispatchers.Default,
 ) {
     data class State(
         val preferredOnRampProvider: OnRampProvider? = null,

apps/flipcash/features/cash/src/main/kotlin/com/flipcash/app/cash/internal/CashScreenViewModel.kt

@@ -15,7 +15,7 @@ import com.flipcash.services.internal.model.thirdparty.OnRampProvider
 import com.flipcash.services.internal.model.thirdparty.OnRampType
 import com.getcode.manager.BottomBarAction
 import com.getcode.manager.BottomBarManager
-import com.getcode.opencode.controllers.TransactionController
+import com.getcode.opencode.controllers.TransactionOperations
 import com.getcode.opencode.exchange.Exchange
 import com.getcode.opencode.model.financial.Currency
 import com.getcode.opencode.model.financial.CurrencyCode
@@ -29,6 +29,7 @@ import com.getcode.solana.keys.Mint
 import com.getcode.ui.components.text.AmountAnimatedInputUiModel
 import com.getcode.ui.components.text.NumberInputHelper
 import com.getcode.util.resources.ResourceHelper
+import com.flipcash.libs.coroutines.DispatcherProvider
 import com.getcode.view.BaseViewModel2
 import com.getcode.view.LoadingSuccessState
 import dagger.hilt.android.lifecycle.HiltViewModel
@@ -52,12 +53,14 @@ internal class CashScreenViewModel @Inject constructor(
     private val resources: ResourceHelper,
     private val exchange: Exchange,
     tokenCoordinator: TokenCoordinator,
-    transactionController: TransactionController,
+    transactionController: TransactionOperations,
     onrampController: OnRampAmountController,
     analytics: FlipcashAnalyticsService,
+    dispatchers: DispatcherProvider,
 ) : BaseViewModel2<CashScreenViewModel.State, CashScreenViewModel.Event>(
     initialState = State(),
-    updateStateForEvent = updateStateForEvent
+    updateStateForEvent = updateStateForEvent,
+    defaultDispatcher = dispatchers.Default,
 ) {
 
     private val numberInputHelper = NumberInputHelper()

apps/flipcash/features/contact-verification/build.gradle.kts

@@ -7,6 +7,11 @@ android {
 }
 
 dependencies {
+    testImplementation(kotlin("test"))
+    testImplementation(libs.bundles.unit.testing)
+    testImplementation(libs.mockito.kotlin)
+    testImplementation(project(":libs:test-utils"))
+
     implementation(libs.compose.activities)
 
     implementation(libs.kotlinx.serialization.json)