use params for query (microsoft#273563)

Author: meganrogge

src/vs/workbench/contrib/chat/browser/actions/chatContext.ts

@@ -278,8 +278,8 @@ export class TerminalContext implements IChatContextValueItem {
 		if (!terminal) {
 			return;
 		}
-
-		const command = terminal.capabilities.get(TerminalCapability.CommandDetection)?.commands.find(cmd => cmd.id === this._resource.query.replace('command=', ''));
+		const params = new URLSearchParams(this._resource.query);
+		const command = terminal.capabilities.get(TerminalCapability.CommandDetection)?.commands.find(cmd => cmd.id === params.get('command'));
 		if (!command) {
 			return;
 		}

src/vs/workbench/contrib/terminal/browser/terminalService.ts

@@ -775,7 +775,8 @@ export class TerminalService extends Disposable implements ITerminalService {
 		if (instance) {
 			this.revealTerminal(instance);
 			const commands = instance.capabilities.get(TerminalCapability.CommandDetection)?.commands;
-			const relevantCommand = commands?.find(c => c.id === resource.query.replace('command=', ''));
+			const params = new URLSearchParams(resource.query);
+			const relevantCommand = commands?.find(c => c.id === params.get('command'));
 			if (relevantCommand) {
 				instance.xterm?.markTracker.revealCommand(relevantCommand);
 			}

src/vs/workbench/contrib/terminal/browser/terminalUri.ts

@@ -22,12 +22,15 @@ export function parseTerminalUri(resource: URI): ITerminalIdentifier {
 }
 
 export function getTerminalUri(workspaceId: string, instanceId: number, title?: string, commandId?: string): URI {
-
+	const params = new URLSearchParams();
+	if (commandId) {
+		params.set('command', commandId);
+	}
 	return URI.from({
 		scheme: Schemas.vscodeTerminal,
 		path: `/${workspaceId}/${instanceId}`,
 		fragment: title || undefined,
-		query: `command=${commandId}`
+		query: commandId ? params.toString() : undefined
 	});
 }