Skip to content

Commit 491e090

Browse files
authored
Fix lm provider disposable leak (microsoft#269565)
Prevent disposable leak
1 parent 1c0caeb commit 491e090

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

src/vs/workbench/api/browser/mainThreadLanguageModels.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,14 +55,14 @@ export class MainThreadLanguageModels implements MainThreadLanguageModelsShape {
5555
}
5656

5757
$registerLanguageModelProvider(vendor: string): void {
58-
const dipsosables = new DisposableStore();
59-
dipsosables.add(this._chatProviderService.registerLanguageModelProvider(vendor, {
60-
onDidChange: Event.filter(this._lmProviderChange.event, e => e.vendor === vendor, dipsosables) as unknown as Event<void>,
58+
const disposables = this._store.add(new DisposableStore());
59+
disposables.add(this._chatProviderService.registerLanguageModelProvider(vendor, {
60+
onDidChange: Event.filter(this._lmProviderChange.event, e => e.vendor === vendor, disposables) as unknown as Event<void>,
6161
provideLanguageModelChatInfo: async (options, token) => {
6262
const modelsAndIdentifiers = await this._proxy.$provideLanguageModelChatInfo(vendor, options, token);
6363
modelsAndIdentifiers.forEach(m => {
6464
if (m.metadata.auth) {
65-
dipsosables.add(this._registerAuthenticationProvider(m.metadata.extension, m.metadata.auth));
65+
disposables.add(this._registerAuthenticationProvider(m.metadata.extension, m.metadata.auth));
6666
}
6767
});
6868
return modelsAndIdentifiers;
@@ -96,7 +96,7 @@ export class MainThreadLanguageModels implements MainThreadLanguageModelsShape {
9696
return this._proxy.$provideTokenLength(modelId, str, token);
9797
},
9898
}));
99-
this._providerRegistrations.set(vendor, dipsosables);
99+
this._providerRegistrations.set(vendor, disposables);
100100
}
101101

102102
$onLMProviderChange(vendor: string): void {

0 commit comments

Comments
 (0)