Skip to content

Commit 370ea76

Browse files
authored
Merge pull request microsoft#273594 from microsoft/benibenj/disastrous-termite
Finalize secondary sidebar view contribution point
2 parents 0d4e501 + c1d7cfd commit 370ea76

3 files changed

Lines changed: 1 addition & 11 deletions

File tree

src/vs/platform/extensions/common/extensionsApiProposals.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -142,9 +142,6 @@ const _allApiProposals = {
142142
contribRemoteHelp: {
143143
proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribRemoteHelp.d.ts',
144144
},
145-
contribSecondarySidebar: {
146-
proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribSecondarySidebar.d.ts',
147-
},
148145
contribShareMenu: {
149146
proposal: 'https://raw.githubusercontent.com/microsoft/vscode/main/src/vscode-dts/vscode.proposed.contribShareMenu.d.ts',
150147
},

src/vs/workbench/api/browser/viewsExtensionPoint.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ import { VIEWLET_ID as REMOTE } from '../../contrib/remote/browser/remoteExplore
3030
import { VIEWLET_ID as SCM } from '../../contrib/scm/common/scm.js';
3131
import { WebviewViewPane } from '../../contrib/webviewView/browser/webviewViewPane.js';
3232
import { Extensions as ExtensionFeaturesRegistryExtensions, IExtensionFeatureTableRenderer, IExtensionFeaturesRegistry, IRenderedData, IRowData, ITableData } from '../../services/extensionManagement/common/extensionFeatures.js';
33-
import { checkProposedApiEnabled, isProposedApiEnabled } from '../../services/extensions/common/extensions.js';
33+
import { isProposedApiEnabled } from '../../services/extensions/common/extensions.js';
3434
import { ExtensionMessageCollector, ExtensionsRegistry, IExtensionPoint, IExtensionPointUser } from '../../services/extensions/common/extensionsRegistry.js';
3535

3636
export interface IUserFriendlyViewsContainerDescriptor {
@@ -329,7 +329,6 @@ class ViewsExtensionHandler implements IWorkbenchContribution {
329329
panelOrder = this.registerCustomViewContainers(value, description, panelOrder, existingViewContainers, ViewContainerLocation.Panel);
330330
break;
331331
case 'secondarySidebar':
332-
checkProposedApiEnabled(description, 'contribSecondarySidebar');
333332
auxiliaryBarOrder = this.registerCustomViewContainers(value, description, auxiliaryBarOrder, existingViewContainers, ViewContainerLocation.AuxiliaryBar);
334333
break;
335334
}

src/vscode-dts/vscode.proposed.contribSecondarySidebar.d.ts

Lines changed: 0 additions & 6 deletions
This file was deleted.

0 commit comments

Comments
 (0)