Rename internal method getConnection() to createConnection()

Author: clue

src/Client.php

@@ -174,8 +174,9 @@ public function createConnector()
      * @param int    $port
      * @return Promise Promise<Stream,Exception>
      * @internal use self::createConnector() instead
+     * @see self::createConnector()
      */
-    public function getConnection($host, $port)
+    public function createConnection($host, $port)
     {
         if (strlen($host) > 255 || $port > 65535 || $port < 0) {
             $deferred = new Deferred();

src/Connector.php

@@ -34,6 +34,6 @@ public function __construct(Client $socksClient)
 
     public function create($host, $port)
     {
-        return $this->client->getConnection($host, $port);
+        return $this->client->createConnection($host, $port);
     }
 }

tests/ClientTest.php

@@ -151,9 +151,9 @@ public function testCreateSecureConnector()
     /**
      * @dataProvider providerAddress
      */
-    public function testGetConnection($host, $port)
+    public function testCreateConnection($host, $port)
     {
-        $this->assertInstanceOf('\React\Promise\PromiseInterface', $this->client->getConnection($host, $port));
+        $this->assertInstanceOf('\React\Promise\PromiseInterface', $this->client->createConnection($host, $port));
     }
 
     public function providerAddress()

tests/FunctionalTest.php

@@ -25,78 +25,78 @@ public function setUp()
 
     public function testConnection()
     {
-        $this->assertResolveStream($this->client->getConnection('www.google.com', 80));
+        $this->assertResolveStream($this->client->createConnection('www.google.com', 80));
     }
 
     public function testConnectionSocks4()
     {
         $this->server->setProtocolVersion(4);
         $this->client->setProtocolVersion(4);
 
-        $this->assertResolveStream($this->client->getConnection('www.google.com', 80));
+        $this->assertResolveStream($this->client->createConnection('www.google.com', 80));
     }
 
     public function testConnectionSocks5()
     {
         $this->server->setProtocolVersion(5);
         $this->client->setProtocolVersion(5);
 
-        $this->assertResolveStream($this->client->getConnection('www.google.com', 80));
+        $this->assertResolveStream($this->client->createConnection('www.google.com', 80));
     }
 
     public function testConnectionInvalidSocks4aRemote()
     {
         $this->client->setProtocolVersion('4a');
         $this->client->setResolveLocal(false);
 
-        $this->assertResolveStream($this->client->getConnection('www.google.com', 80));
+        $this->assertResolveStream($this->client->createConnection('www.google.com', 80));
     }
 
     public function testConnectionSocks5Remote()
     {
         $this->client->setProtocolVersion(5);
         $this->client->setResolveLocal(false);
 
-        $this->assertResolveStream($this->client->getConnection('www.google.com', 80));
+        $this->assertResolveStream($this->client->createConnection('www.google.com', 80));
     }
 
     public function testConnectionAuthentication()
     {
         $this->server->setAuthArray(array('name' => 'pass'));
         $this->client->setAuth('name', 'pass');
 
-        $this->assertResolveStream($this->client->getConnection('www.google.com', 80));
+        $this->assertResolveStream($this->client->createConnection('www.google.com', 80));
     }
 
     public function testConnectionAuthenticationUnused()
     {
         $this->client->setAuth('name', 'pass');
 
-        $this->assertResolveStream($this->client->getConnection('www.google.com', 80));
+        $this->assertResolveStream($this->client->createConnection('www.google.com', 80));
     }
 
     public function testConnectionInvalidProtocolMismatch()
     {
         $this->server->setProtocolVersion(5);
         $this->client->setProtocolVersion(4);
 
-        $this->assertRejectPromise($this->client->getConnection('www.google.com', 80));
+        $this->assertRejectPromise($this->client->createConnection('www.google.com', 80));
     }
 
     public function testConnectionInvalidNoAuthentication()
     {
         $this->server->setAuthArray(array('name' => 'pass'));
         $this->client->setProtocolVersion(5);
 
-        $this->assertRejectPromise($this->client->getConnection('www.google.com', 80));
+        $this->assertRejectPromise($this->client->createConnection('www.google.com', 80));
     }
 
     public function testConnectionInvalidAuthenticationMismatch()
     {
         $this->server->setAuthArray(array('name' => 'pass'));
         $this->client->setAuth('user', 'other');
 
-        $this->assertRejectPromise($this->client->getConnection('www.google.com', 80));
+        $this->assertRejectPromise($this->client->createConnection('www.google.com', 80));
     }
 
     public function testConnectorOkay()