Skip to content

Commit d7ae1d9

Browse files
authored
Merge pull request #297 from clue-labs/php8.5
Run tests on PHP 8.5 and update test environment
2 parents 628ec52 + e1fb520 commit d7ae1d9

5 files changed

Lines changed: 25 additions & 19 deletions

File tree

.github/workflows/ci.yml

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ jobs:
1414
- ubuntu-24.04
1515
- windows-2022
1616
php:
17+
- 8.5
1718
- 8.4
1819
- 8.3
1920
- 8.2
@@ -24,7 +25,7 @@ jobs:
2425
- 7.2
2526
- 7.1
2627
steps:
27-
- uses: actions/checkout@v4
28+
- uses: actions/checkout@v6
2829
- uses: shivammathur/setup-php@v2
2930
with:
3031
php-version: ${{ matrix.php }}
@@ -48,6 +49,7 @@ jobs:
4849
strategy:
4950
matrix:
5051
php:
52+
- 8.5
5153
- 8.4
5254
- 8.3
5355
- 8.2
@@ -58,7 +60,7 @@ jobs:
5860
- 7.2
5961
- 7.1
6062
steps:
61-
- uses: actions/checkout@v4
63+
- uses: actions/checkout@v6
6264
- uses: shivammathur/setup-php@v2
6365
with:
6466
php-version: ${{ matrix.php }}
@@ -72,6 +74,7 @@ jobs:
7274
strategy:
7375
matrix:
7476
php:
77+
- 8.5
7578
- 8.4
7679
- 8.3
7780
- 8.2
@@ -82,7 +85,7 @@ jobs:
8285
- 7.2
8386
- 7.1
8487
steps:
85-
- uses: actions/checkout@v4
88+
- uses: actions/checkout@v6
8689
- uses: shivammathur/setup-php@v2
8790
with:
8891
php-version: ${{ matrix.php }}
@@ -100,10 +103,10 @@ jobs:
100103
- "Dockerfile-basics"
101104
- "Dockerfile-production"
102105
steps:
103-
- uses: actions/checkout@v4
106+
- uses: actions/checkout@v6
104107
- uses: shivammathur/setup-php@v2
105108
with:
106-
php-version: 8.4
109+
php-version: 8.5
107110
- run: composer install -d tests/integration/
108111
- run: docker build -f tests/integration/${{ matrix.dockerfile }} tests/integration/
109112
- run: docker run -d -p 8080:8080 -v "$PWD/composer.json":/app/composer.json $(docker images -q | head -n1)
@@ -124,10 +127,10 @@ jobs:
124127
- name: minimal reverse proxy
125128
path: nginx-reverse-proxy-minimal.conf
126129
steps:
127-
- uses: actions/checkout@v4
130+
- uses: actions/checkout@v6
128131
- uses: shivammathur/setup-php@v2
129132
with:
130-
php-version: 8.4
133+
php-version: 8.5
131134
- run: composer install -d tests/integration/
132135
- run: docker build -f tests/integration/Dockerfile-basics tests/integration/
133136
- run: docker run -d -p 8080:8080 -v "$PWD/composer.json":/app/composer.json $(docker images -q | head -n1)
@@ -146,6 +149,7 @@ jobs:
146149
strategy:
147150
matrix:
148151
php:
152+
- 8.5
149153
- 8.4
150154
- 8.3
151155
- 8.2
@@ -156,7 +160,7 @@ jobs:
156160
- 7.2
157161
- 7.1
158162
steps:
159-
- uses: actions/checkout@v4
163+
- uses: actions/checkout@v6
160164
- uses: shivammathur/setup-php@v2
161165
with:
162166
php-version: ${{ matrix.php }}
@@ -174,6 +178,7 @@ jobs:
174178
strategy:
175179
matrix:
176180
php:
181+
- 8.5
177182
- 8.4
178183
- 8.3
179184
- 8.2
@@ -184,7 +189,7 @@ jobs:
184189
- 7.2
185190
- 7.1
186191
steps:
187-
- uses: actions/checkout@v4
192+
- uses: actions/checkout@v6
188193
- uses: shivammathur/setup-php@v2
189194
with:
190195
php-version: ${{ matrix.php }}
@@ -201,6 +206,7 @@ jobs:
201206
strategy:
202207
matrix:
203208
php:
209+
- 8.5
204210
- 8.4
205211
- 8.3
206212
- 8.2
@@ -211,7 +217,7 @@ jobs:
211217
- 7.2
212218
- 7.1
213219
steps:
214-
- uses: actions/checkout@v4
220+
- uses: actions/checkout@v6
215221
- uses: shivammathur/setup-php@v2
216222
with:
217223
php-version: ${{ matrix.php }}
@@ -224,6 +230,6 @@ jobs:
224230
name: Docs
225231
runs-on: ubuntu-24.04
226232
steps:
227-
- uses: actions/checkout@v4
233+
- uses: actions/checkout@v6
228234
- run: docker compose -f docs/compose.yaml run build
229235
- run: ls -la build/docs/

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"react/async": "^4.3 || ^3.1",
1717
"react/http": "^1.11",
1818
"react/promise": "^3.3",
19-
"react/socket": "^1.15"
19+
"react/socket": "^1.17"
2020
},
2121
"require-dev": {
2222
"phpstan/phpstan": "1.12.11 || 1.4.10",

docs/best-practices/deployment.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ If you're not already running an Apache server, you can run your X project with
229229
Apache in a temporary Docker container like this:
230230

231231
```bash
232-
$ docker run -it --rm -p 80:80 -v "$PWD":/srv php:8.4-apache sh -c "rmdir /var/www/html;ln -s /srv/public /var/www/html;ln -s /etc/apache2/mods-available/rewrite.load /etc/apache2/mods-enabled; apache2-foreground"
232+
$ docker run -it --rm -p 80:80 -v "$PWD":/srv php:8.5-apache sh -c "rmdir /var/www/html;ln -s /srv/public /var/www/html;ln -s /etc/apache2/mods-available/rewrite.load /etc/apache2/mods-enabled; apache2-foreground"
233233
```
234234

235235
In order to check your web application responds as expected, you can use your
@@ -313,10 +313,10 @@ limit to match your concurrency workload. On Ubuntu- or Debian-based systems,
313313
you may change your PHP configuration like this:
314314

315315
```bash
316-
$ sudoedit /etc/php/8.4/cli/php.ini
316+
$ sudoedit /etc/php/8.5/cli/php.ini
317317
```
318318

319-
```diff title="/etc/php/8.4/cli/php.ini"
319+
```diff title="/etc/php/8.5/cli/php.ini"
320320
- memory_limit = 128M
321321
+ memory_limit = -1
322322
```
@@ -620,7 +620,7 @@ be achieved by using a `Dockerfile` with the following contents:
620620

621621
```docker title="Dockerfile"
622622
# syntax=docker/dockerfile:1
623-
FROM php:8.4-cli
623+
FROM php:8.5-cli
624624

625625
WORKDIR /app/
626626
COPY public/ public/
@@ -642,7 +642,7 @@ be achieved by using a `Dockerfile` with the following contents:
642642
COPY composer.json composer.lock ./
643643
RUN composer install --no-dev --ignore-platform-reqs --optimize-autoloader
644644

645-
FROM php:8.4-alpine
645+
FROM php:8.5-alpine
646646

647647
# recommended: install optional extensions ext-ev and ext-sockets
648648
RUN apk --no-cache add ${PHPIZE_DEPS} libev linux-headers \

tests/integration/Dockerfile-basics

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# syntax=docker/dockerfile:1
2-
FROM php:8.4-cli
2+
FROM php:8.5-cli
33

44
WORKDIR /app/
55
COPY public/ public/

tests/integration/Dockerfile-production

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ COPY composer.json composer.lock ./
88
# dev environment already has dependencies installed:
99
COPY vendor/ vendor/
1010

11-
FROM php:8.4-alpine
11+
FROM php:8.5-alpine
1212

1313
# recommended: install optional extensions ext-ev and ext-sockets
1414
RUN apk --no-cache add ${PHPIZE_DEPS} libev linux-headers \

0 commit comments

Comments
 (0)